This repository was archived by the owner on Oct 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Replace Button's default slot with an attribute #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6bb888d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ynotdraw
approved these changes
Sep 23, 2024
danwenzel
approved these changes
Sep 23, 2024
ynotdraw
reviewed
Sep 23, 2024
|
||
```html | ||
<glide-core-button size="small">Button</glide-core-button> | ||
<glide-core-button label="Button" size="small"></glide-core-button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch!
clintcs
commented
Sep 23, 2024
dylankcrwd
approved these changes
Sep 24, 2024
563c31c
to
22594a7
Compare
Pushed an amended commit moving |
22594a7
to
6bb888d
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
A
label
attribute instead of a default slot to restrict Button's content.📋 Checklist
🔬 How to Test
A quick poke around Storybook should do.
📸 Images/Videos of Functionality
N/A