+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Sep 23, 2024

🚀 Description

A label attribute instead of a default slot to restrict Button's content.

📋 Checklist

🔬 How to Test

A quick poke around Storybook should do.

📸 Images/Videos of Functionality

N/A

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 6bb888d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs marked this pull request as ready for review September 23, 2024 20:40
Copy link
Contributor


```html
<glide-core-button size="small">Button</glide-core-button>
<glide-core-button label="Button" size="small"></glide-core-button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch!

@clintcs clintcs force-pushed the button-attribute-instead-of-default-slot branch from 563c31c to 22594a7 Compare September 24, 2024 13:27
@clintcs
Copy link
Collaborator Author

clintcs commented Sep 24, 2024

Pushed an amended commit moving label above name in button.ts.

@clintcs clintcs force-pushed the button-attribute-instead-of-default-slot branch from 22594a7 to 6bb888d Compare September 24, 2024 14:37
@clintcs clintcs merged commit efe4812 into main Sep 24, 2024
7 checks passed
@clintcs clintcs deleted the button-attribute-instead-of-default-slot branch September 24, 2024 14:44
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载