This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Make Dropdown optionally filterable #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dabd7fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
59505dd to
878622a
Compare
878622a to
e1f964e
Compare
clintcs
commented
Sep 6, 2024
| }, | ||
| }; | ||
|
|
||
| export const Filterable: StoryObj = { |
There was a problem hiding this comment.
No need for this story now Dropdown has a filterable control.
5db5087 to
5841720
Compare
5841720 to
bab7929
Compare
ynotdraw
reviewed
Sep 6, 2024
Co-authored-by: Tony Ward <8069555+ynotdraw@users.noreply.github.com>
dylankcrwd
approved these changes
Sep 9, 2024
ynotdraw
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Adds a
filterableattribute to Dropdown. Consumers can use it to force Dropdown to be filterable when there are fewer than 11 options. When there are 11 or more options, Dropdown will be filterable regardless offilterable.📋 Checklist
🔬 How to Test
filterablecontrol totrue.📸 Images/Videos of Functionality
N/A