This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Don't assert in Form Controls Layout's split setter
#275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab5ffab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1b5e0df to
ab5ffab
Compare
clintcs
commented
Aug 2, 2024
There was a problem hiding this comment.
Storybook's rerendering behavior is unusual. But consumers could be doing a rerender as well, for whatever reason. Thus the changeset.
ynotdraw
approved these changes
Aug 2, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Form Controls Layout's
splitcontrol is broken in Storybook.Storybook rerenders components when one of the controls is interacted with. So the
splitsetter was running before Form Control Layout's default slot was established, causing theowassertion in thesplitsetter to fail. I removed the assertion.📋 Checklist
🔬 How to Test
splitcontrol. Make sure it works.📸 Images/Videos of Functionality
N/A