This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Migrate Dropdown to Label #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d170e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
96615ac to
695bea9
Compare
clintcs
commented
May 20, 2024
| grid-column: 2; | ||
| line-height: var(--cs-body-xs-line-height); | ||
| margin-block-start: var(--cs-spacing-xxxs); | ||
| margin-block-start: var(--cs-spacing-xxs); |
There was a problem hiding this comment.
Figma calls for --cs-spacing-xxs.
695bea9 to
af0dd28
Compare
clintcs
commented
May 20, 2024
| }, | ||
| }, | ||
| args: { | ||
| label: 'Label', |
There was a problem hiding this comment.
Aha! It's args not argTypes that determines the order.
Before
After
I'll move required attributes to the top of args across the board in a followup followup PR.
1733c7d to
043d714
Compare
clintcs
commented
May 20, 2024
| </div> | ||
| </div> | ||
| <div |
There was a problem hiding this comment.
The mockups were incomplete. Dropdown is meant to have a description like every other control.
e1e989d to
84028ab
Compare
84028ab to
d18381c
Compare
danwenzel
approved these changes
May 21, 2024
Co-authored-by: Dan Wenzel <11724146+danwenzel@users.noreply.github.com>
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
labelattribute to Dropdown's test fixtures.📋 Checklist
🔬 How to Test
Have a look at Dropdown. Make sure it looks like production. Run it through a screenreader. Make sure its label is announced even when hidden. Make sure its validation message is announced when the component is invalid.
📸 Images/Videos of Functionality
Horizontal
Vertical