🦋 Changeset detected

Latest commit: e93d567

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Preview URL

https://glide-core.crowdstrike-ux.workers.dev/tooltip-fixes

Hi @clintcs I upgraded core version to 0.3.2 and can see this change impacted the position of tooltip icon a bit in accordions. Should we adapt to this change and make some changes at our end in internals repo?

Thanks for letting us know and apologies the churn. Without a line-height on Tooltip, Tooltip is assuming the line-height of .summary.

The fix is actually on our end. The existing .target { display: inline-flex } ensures the target's box wraps neatly around it so that the tooltip is horizontally and vertically centered. We can also add .component { display: flex } so the inherited line-height doesn't apply.

I'll open a PR shortly.

Thanks for letting us know and apologies the churn. Without a line-height on Tooltip, Tooltip is assuming the line-height of .summary.

The fix is actually on our end. The existing .target { display: inline-flex } ensures the target's box wraps neatly around it so that the tooltip is horizontally and vertically centered. We can also add .component { display: flex } so the inherited line-height doesn't apply.

I'll open a PR shortly.

Awesome thanks :)

No problem! #124