+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented May 14, 2024

🚀 Description

Ensures Floating UI isn't doing expensive stuff in the background when Tooltip is hidden.

📋 Checklist

  • I have read and followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have created or updated stories in Storybook to document the new functionality.
  • I have included a changeset with this Pull Request if it adds/updates/removes functionality for consumers.
  • I have scheduled a Design Review for these changes, if one is required.
  • I have followed the ARIA Authoring Practices Guide and/or met with the Accessibility Team to ensure this functionality is accessible.
  • I have added the component to exports in packages/components/package.json (if applicable).

🔬 How to Test

Make sure the tooltip is still visible on hover and focus.

📸 Images/Videos of Functionality

N/A

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 52d5bb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs changed the title Clean up Tooltip's Floating UI on hide Clean up Tooltip's Floating UI when hidden May 14, 2024
@clintcs clintcs force-pushed the tooltip-clean-up-floating-ui-on-hide branch from ab38d4c to 52d5bb3 Compare May 14, 2024 15:00
Copy link
Contributor

@clintcs clintcs marked this pull request as ready for review May 14, 2024 15:04
@clintcs clintcs merged commit 79ebcf0 into main May 14, 2024
@clintcs clintcs deleted the tooltip-clean-up-floating-ui-on-hide branch May 14, 2024 15:24
@github-actions github-actions bot mentioned this pull request May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载