This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Expose Menu placement attribute
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2731196 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c356292 to
f968420
Compare
clintcs
commented
May 14, 2024
| set open(isOpen) { | ||
| this.#isOpen = isOpen; | ||
|
|
||
| if (isOpen) { |
There was a problem hiding this comment.
This makes sure Menu responds to assignments to placement after render. It also ensures Floating UI isn't doing stuff in the background when Menu is closed.
ca7069e to
39bfd54
Compare
clintcs
commented
May 14, 2024
| return html`<div style="height: 8rem;"> | ||
| <cs-menu size=${arguments_.size || nothing} ?open=${arguments_.open}> | ||
| return html`<div | ||
| style="height: 13rem; display: flex; align-items: center; justify-content: center;" |
There was a problem hiding this comment.
Make room for the various placement options.
clintcs
commented
May 14, 2024
There was a problem hiding this comment.
This is the only case I know of where we were setting the default this way.
ynotdraw
approved these changes
May 14, 2024
danwenzel
approved these changes
May 14, 2024
39bfd54 to
2731196
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
N/A
📋 Checklist
exportsinpackages/components/package.json(if applicable).🔬 How to Test
Open Storybook and play around with the
placementoptions.📸 Images/Videos of Functionality
N/A