This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Ditch remaining uses of @query #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74812e9 to
d27334a
Compare
🦋 Changeset detectedLatest commit: 1d55b9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clintcs
commented
Dec 19, 2024
| slotElements!: GlideCoreTreeItem[]; | ||
|
|
||
| @queryAssignedElements({ slot: 'suffix' }) | ||
| suffixSlotAssignedElements!: HTMLElement[]; |
clintcs
commented
Dec 19, 2024
| And, [unlike](https://github.com/lit/lit/issues/4020#issuecomment-1743735312) the decorators, refs can be made private. | ||
| So we can be sure they're only used internally. | ||
|
|
||
| ```ts |
There was a problem hiding this comment.
Rather than give examples, I thought we could defer to Lit's documentation—which is linked above.
There was a problem hiding this comment.
@ynotdraw: Can we lint against @query decorators?
There was a problem hiding this comment.
You bet! I'll add it to my list. Should be quick, I'll try and knock it out tomorrow.
c972c39 to
02629be
Compare
clintcs
commented
Dec 19, 2024
| `); | ||
|
|
||
| const childItems = component.querySelectorAll<TreeItem>( | ||
| ':scope > glide-core-tree-item', |
There was a problem hiding this comment.
02629be to
7559530
Compare
7559530 to
5369908
Compare
danwenzel
approved these changes
Dec 19, 2024
src/tree.item.ts
Outdated
| ); | ||
| } | ||
|
|
||
| // Checks if focus has moved to an element within this tree item itself, |
There was a problem hiding this comment.
Unintentional comment shift?
ynotdraw
approved these changes
Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Added to
CONTRIBUTING.md:📋 Checklist
🔬 How to Test
The tests should have us covered. But a poke around Storybook wouldn't hurt.
📸 Images/Videos of Functionality
N/A