Switch to xlightest background for pinned Drawer #539
Conversation
🦋 Changeset detectedLatest commit: f0d2f37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| visibility: hidden; | ||
| &.pinned { | ||
| background-color: var(--glide-core-surface-base-xlightest); |
There was a problem hiding this comment.
I know design likely gave you this color, but in light mode there's no visuals to help a user know where the Drawer ends and begins. Is this intended?
In dark mode there is a difference, so thought I'd ask!
Screen.Recording.2024-12-16.at.8.35.31.PM.mov
There was a problem hiding this comment.
That's a great question, I'll ask design about that. I think at the moment they're assuming the background behind the drawer is not white
Note that this is already the case in main. The base color in either case is white (#ffffff), this just changes the opacity, so if you're against a white background (as we are in Storybook), there's no change. Adding pinned also removes the shadow (which was the existing functionality), which creates the issue you mentioned.
For that reason, I'm assuming this isn't a blocker to this PR?
Co-authored-by: Tony Ward <8069555+ynotdraw@users.noreply.github.com>
🚀 Description
The background color for a pinned Drawer now has a slightly less transparent background
📋 Checklist
🔬 How to Test
📸 Images/Videos of Functionality