This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Add disabled attribute to Dropdown Option #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 382480a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a7a5d8f to
be7a935
Compare
clintcs
commented
Dec 5, 2024
| <glide-core-dropdown-option | ||
| label="Two" | ||
| value="two" | ||
| ?selected=${arguments_['<glide-core-dropdown-option>.two.selected']} |
There was a problem hiding this comment.
For testing purposes. I'll revert this and everything below before merging.
be7a935 to
5b0f1f5
Compare
clintcs
commented
Dec 5, 2024
src/dropdown.stories.ts
Outdated
| 'reportValidity()': '', | ||
| required: false, | ||
| 'select-all': false, | ||
| 'select-all': true, |
There was a problem hiding this comment.
Suggested change
| 'select-all': true, | |
| 'select-all': false, |
clintcs
commented
Dec 5, 2024
src/dropdown.stories.ts
Outdated
Comment on lines
59
to
60
| '<glide-core-dropdown-option>.label': | ||
| 'Lorem Ipsum is simply dummy text of the printing and typesetting industry.', |
There was a problem hiding this comment.
Suggested change
| '<glide-core-dropdown-option>.label': | |
| 'Lorem Ipsum is simply dummy text of the printing and typesetting industry.', | |
| '<glide-core-dropdown-option>.label': 'One', |
clintcs
commented
Dec 5, 2024
src/dropdown.stories.ts
Outdated
| '<glide-core-dropdown-option>.label': | ||
| 'Lorem Ipsum is simply dummy text of the printing and typesetting industry.', | ||
| '<glide-core-dropdown-option>.addEventListener(event, handler)': false, | ||
| '<glide-core-dropdown-option>.disabled': true, |
There was a problem hiding this comment.
Suggested change
| '<glide-core-dropdown-option>.disabled': true, | |
| '<glide-core-dropdown-option>.disabled': false, |
b8d59c9 to
914f778
Compare
clintcs
commented
Dec 5, 2024
| reflect: true, | ||
| type: Boolean, | ||
| }) | ||
| privateDisableLabelTooltip = false; |
There was a problem hiding this comment.
I talked to Design. They don't want the tooltip shown on hover when an option is disabled. This property makes that happen.
7554d5f to
1761d3a
Compare
clintcs
commented
Dec 5, 2024
| --- | ||
|
|
||
| - Dropdown Options now support a `disabled` attribute. | ||
| - Dropdown now dispatches "input" events before "change" to match native. |
e74efd4 to
c4dc796
Compare
ynotdraw
approved these changes
Dec 6, 2024
danwenzel
approved these changes
Dec 6, 2024
c4dc796 to
382480a
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
N/A
📋 Checklist
🔬 How to Test
📸 Images/Videos of Functionality