This repository was archived by the owner on Oct 14, 2025. It is now read-only.
More dark mode updates #493
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| '@crowdstrike/glide-core': patch | ||
| --- | ||
|
|
||
| `@crowdstrike/glide-core/styles/variables.css` has been updated with the `data-viz` colors from Figma: | ||
|
|
||
| ## Light | ||
|
|
||
| ### Added | ||
|
|
||
| ```diff | ||
| + --glide-core-data-viz-cobalt-cobalt: #5183df; | ||
| + --glide-core-data-viz-cyan-cyan: #299ed1; | ||
| + --glide-core-data-viz-gold-gold: #cc8519; | ||
| + --glide-core-data-viz-gray-dark: #424242; | ||
| + --glide-core-data-viz-gray-darker: #212121; | ||
| + --glide-core-data-viz-gray-default: #6d6d6d; | ||
| + --glide-core-data-viz-gray-light: #8a8a8a; | ||
| + --glide-core-data-viz-gray-lighter: #c9c9c9; | ||
| + --glide-core-data-viz-gray-lightest: #f0f0f0; | ||
| + --glide-core-data-viz-gray-x-lighter: #e3e3e3; | ||
| + --glide-core-data-viz-indigo-indigo: #6563d9; | ||
| + --glide-core-data-viz-lilac-lilac: #ce66e5; | ||
| + --glide-core-data-viz-magenta-magenta: #f9338b; | ||
| + --glide-core-data-viz-moss-moss: #959328; | ||
| + --glide-core-data-viz-olive-olive: #7f994d; | ||
| + --glide-core-data-viz-red-red: #db2d24; | ||
| + --glide-core-data-viz-rose-rose: #ea5da3; | ||
| + --glide-core-data-viz-teal-teal: #39a288; | ||
| + --glide-core-data-viz-turquoise-turqoise: #339da3; | ||
| + --glide-core-data-viz-violet-violet: #af52de; | ||
| ``` | ||
|
|
||
| ## Dark | ||
|
|
||
| ### Added | ||
|
|
||
| ```diff | ||
| + --glide-core-data-viz-cobalt-cobalt: #6e8ec4; | ||
| + --glide-core-data-viz-cyan-cyan: #4b98b9; | ||
| + --glide-core-data-viz-gold-gold: #b98d4b; | ||
| + --glide-core-data-viz-gray-dark: #424242; | ||
| + --glide-core-data-viz-gray-darker: #212121; | ||
| + --glide-core-data-viz-gray-default: #6d6d6d; | ||
| + --glide-core-data-viz-gray-light: #8a8a8a; | ||
| + --glide-core-data-viz-gray-lighter: #c9c9c9; | ||
| + --glide-core-data-viz-gray-lightest: #000000e5; | ||
| + --glide-core-data-viz-gray-x-lighter: #e3e3e3; | ||
| + --glide-core-data-viz-indigo-indigo: #7574e5; | ||
| + --glide-core-data-viz-lilac-lilac: #b37cc5; | ||
| + --glide-core-data-viz-magenta-magenta: #c2678f; | ||
| + --glide-core-data-viz-moss-moss: #949151; | ||
| + --glide-core-data-viz-olive-olive: #7a845c; | ||
| + --glide-core-data-viz-red-red: #db4743; | ||
| + --glide-core-data-viz-rose-rose: #be7e9f; | ||
| + --glide-core-data-viz-teal-teal: #5c9d8c; | ||
| + --glide-core-data-viz-turquoise-turqoise: #639d9f; | ||
| + --glide-core-data-viz-violet-violet: #a66dc3; | ||
| ``` | ||
|
There was a problem hiding this comment. I wanted to explicitly call out the renamed variables so they aren't lost in the release notes. I'm not married to it, but thought it may be helpful for folks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| '@crowdstrike/glide-core': minor | ||
| --- | ||
|
|
||
| The following CSS variables were renamed: | ||
|
|
||
| ```diff | ||
| - --glide-core-background-fill | ||
| + --glide-core-surface-background-image | ||
|
|
||
| - --glide-core-border-radius-none | ||
| + --glide-core-border-radius-zero | ||
|
|
||
| - --glide-core-border-width-none | ||
| + --glide-core-border-width-zero | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| --- | ||
| '@crowdstrike/glide-core': minor | ||
| --- | ||
|
|
||
| `@crowdstrike/glide-core/styles/variables.css` has been updated with the latest from Figma: | ||
|
|
||
| ## Light | ||
|
|
||
| ### Added | ||
|
|
||
| ```diff | ||
| + --glide-core-border-attention: #f8f0d1; | ||
| + --glide-core-border-error: #ffdcda; | ||
| + --glide-core-border-informational: #d7e7ff; | ||
| + --glide-core-border-warning: #ffebce; | ||
|
|
||
| + --glide-core-effects-shadow-small-blur: 0.5rem; | ||
| + --glide-core-effects-shadow-small-fill: #b5b5b540; | ||
| + --glide-core-effects-shadow-small-spread: 0rem; | ||
| + --glide-core-effects-shadow-small-x: 0rem; | ||
| + --glide-core-effects-shadow-small-y: 0.125rem; | ||
|
|
||
| + --glide-core-effects-shadow-switcher-blur: 0.125rem; | ||
| + --glide-core-effects-shadow-switcher-fill: #ffffff59; | ||
| + --glide-core-effects-shadow-switcher-spread: 0rem; | ||
| + --glide-core-effects-shadow-switcher-x: 0.0625rem; | ||
| + --glide-core-effects-shadow-switcher-y: 0.0625rem; | ||
|
|
||
| + --glide-core-surface-background-image: #00000000; | ||
| ``` | ||
|
|
||
| ### Removed | ||
|
|
||
| ```diff | ||
| - --glide-core-background-fill: #15141400; | ||
| - --glide-core-generic-border-active: #6d6d6d; | ||
| ``` | ||
|
|
||
| ## Dark | ||
|
|
||
| ### Added | ||
|
|
||
| ```diff | ||
| + --glide-core-border-attention: #f8f0d1; | ||
| + --glide-core-border-error: #ffdcda; | ||
| + --glide-core-border-informational: #d7e7ff; | ||
| + --glide-core-border-warning: #ffebce; | ||
|
|
||
| + --glide-core-effects-shadow-small-blur: 0.5rem; | ||
| + --glide-core-effects-shadow-small-fill: #00000040; | ||
| + --glide-core-effects-shadow-small-spread: 0rem; | ||
| + --glide-core-effects-shadow-small-x: 0rem; | ||
| + --glide-core-effects-shadow-small-y: 0.125rem; | ||
|
|
||
| + --glide-core-effects-shadow-switcher-blur: 0.125rem; | ||
| + --glide-core-effects-shadow-switcher-fill: #0000000d; | ||
| + --glide-core-effects-shadow-switcher-spread: 0rem; | ||
| + --glide-core-effects-shadow-switcher-x: 0.0625rem; | ||
| + --glide-core-effects-shadow-switcher-y: 0.0625rem; | ||
|
|
||
| + --glide-core-surface-background-image: #151414f7; | ||
| ``` | ||
|
|
||
| ### Removed | ||
|
|
||
| ```diff | ||
| - --glide-core-background-fill: #151414f7; | ||
| - --glide-core-generic-border-active: #6d6d6d; | ||
| ``` | ||
|
|
||
| ### Changed | ||
|
|
||
| ```diff | ||
| - --glide-core-effects-shadow-large-blur: 3.125rem; | ||
| + --glide-core-effects-shadow-large-blur: 0.75rem; | ||
|
|
||
| - --glide-core-effects-shadow-large-y: 0.625rem; | ||
| + --glide-core-effects-shadow-large-y: 0.125rem; | ||
| ``` | ||
|
|
||
| ## System | ||
|
|
||
| ### Added | ||
|
|
||
| ```diff | ||
| + --glide-core-border-radius-zero: 0rem; | ||
| + --glide-core-border-width-zero: 0rem; | ||
| ``` | ||
|
|
||
| ### Removed | ||
|
|
||
| ```diff | ||
| - --glide-core-border-radius-none: 0rem; | ||
| - --glide-core-border-width-none: 0rem; | ||
| - --glide-core-number-14: 0.875rem; | ||
| - --glide-core-page-size-details-panel: 27.375rem; | ||
| ``` | ||
|
|
||
| ## Miscellaneous | ||
|
|
||
| ### Changed | ||
|
|
||
| ```diff | ||
| - --glide-core-shadow-sm: 0px 2.275px 8.342px 0px rgba(181, 181, 181, 0.25); | ||
| + --glide-core-shadow-sm: var(--glide-core-effects-shadow-small-x) var(--glide-core-effects-shadow-small-y) var(--glide-core-effects-shadow-small-blur) var(--glide-core-effects-shadow-small-spread) var(--glide-core-effects-shadow-small-fill); | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@crowdstrike/glide-core': patch | ||
| --- | ||
|
|
||
| Tree Item's selected hover background color was updated for more contrast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@crowdstrike/glide-core': patch | ||
| --- | ||
|
|
||
| Dropdown's visual design for "select all" and "add" were reverted back to the previous state after additional design review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty odd to have the repeated name here (e.g.,
cobalt-cobalt), but it's due to the way they're structured on the Figma side. Talking with Zheng, these should get a lot simpler in our next major iteration on tokens, but this is what we have to roll with for now.