More dark mode updates #493
Conversation
🦋 Changeset detectedLatest commit: 357fa61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8641875 to
2cd5faa
Compare
2cd5faa to
2ac5b3d
Compare
| ### Added | ||
|
|
||
| ```diff | ||
| + --glide-core-data-viz-cobalt-cobalt: #5183df; |
There was a problem hiding this comment.
It looks pretty odd to have the repeated name here (e.g., cobalt-cobalt), but it's due to the way they're structured on the Figma side. Talking with Zheng, these should get a lot simpler in our next major iteration on tokens, but this is what we have to roll with for now.
There was a problem hiding this comment.
I wanted to explicitly call out the renamed variables so they aren't lost in the release notes. I'm not married to it, but thought it may be helpful for folks.
| } | ||
| }, | ||
| fileId: 'WUB2u7DW0sLp04vFzQVFx1', | ||
| fileId: 'U5EY5xuIIibSN68gGRKlqt', |
There was a problem hiding this comment.
Moved the fileId back to the original one, so that we are no longer on a branch in Figma 🎉
.changeset/lazy-rockets-admire.md
Outdated
| - `--glide-core-background-fill` is now `--glide-core-surface-background-image`. | ||
| - `--glide-core-border-radius-none` is now `--glide-core-border-radius-zero`. | ||
| - `--glide-core-border-width-none` is now `--glide-core-border-width-zero`. |
There was a problem hiding this comment.
Diff syntax?
- --glide-core-background-fill
+ --glide-core-surface-background-image
- --glide-core-border-radius-none
+ --glide-core-border-radius-zero
- --glide-core-border-width-none
+ --glide-core-border-width-zero2ac5b3d to
ae2acc9
Compare
ae2acc9 to
357fa61
Compare
|
Snuck in a few more variables to unblock @mayuri-todkar's inline alert component: --glide-core-border-attention: #f8f0d1;
--glide-core-border-error: #ffdcda;
--glide-core-border-informational: #d7e7ff;
--glide-core-border-warning: #ffebce; |
🚀 Description
data-vizcolors from Figma as requested.selectedhover state background color as requested.background-coloradjustment instead after things went through another design review with Mary and Joe.--glide-core-shadow-smto work in both light and dark modes.📋 Checklist
🔬 How to Test
📸 Images/Videos of Functionality