+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

dylankcrwd
Copy link
Contributor

@dylankcrwd dylankcrwd commented Apr 17, 2024

Moves tab, tab-panel, and tab-group from glide to glide-core.

Will squash and add changeset on approval.

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 616162f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@dylankcrwd dylankcrwd changed the title feat(Tab,Tab Panel, Tab Group): adds tab, tab panel and tab group from glide to glide-core feat(Tab,Tab Panel, Tab Group): move from glide to glide-core Apr 17, 2024
@dylankcrwd dylankcrwd changed the title feat(Tab,Tab Panel, Tab Group): move from glide to glide-core feat(Tab, Tab Panel, Tab Group): move from glide to glide-core Apr 17, 2024
@dylankcrwd dylankcrwd marked this pull request as ready for review April 23, 2024 14:30
@dylankcrwd dylankcrwd changed the title feat(Tab, Tab Panel, Tab Group): move from glide to glide-core feat(tab, tab panel, tab group): move from glide to glide-core Apr 23, 2024
Copy link
Collaborator

@ynotdraw ynotdraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Dylan! I left a few comments around it registers tests and you'll want to add a patch changeset, but other than that this looks good to ship to me. :shipit:

@dylankcrwd dylankcrwd merged commit 4bc3b10 into main Apr 30, 2024
@dylankcrwd dylankcrwd deleted the add-tab branch April 30, 2024 20:04
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载