This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Remove the sticky attribute from Tab Group #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed41476 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clintcs
approved these changes
Nov 8, 2024
| '@crowdstrike/glide-core': minor | ||
| --- | ||
|
|
||
| The `sticky` attribute for Tab Group wasn't fully thought through. It was decided it is safe to remove it in favor of making the Tab Panel scroll when needed instead. |
There was a problem hiding this comment.
Was it not fully thought through on our end? Or did another team say they needed it but didn't?
There was a problem hiding this comment.
A bit of both. Does that change how you feel about this note? I don't mind rewording if you'd like.
There was a problem hiding this comment.
I'm cool with it. Just wanted to make sure we weren't owning something outside our control.
danwenzel
approved these changes
Nov 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Adding
stickywasn't a fully thought out solution unfortunately, and @danwenzel tinkered elsewhere and found something that works better. Due to that, let's remove it.📋 Checklist
🔬 How to Test
N/A - removing functionality.
📸 Images/Videos of Functionality
N/A - removing functionality.