+
Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Oct 10, 2024

🚀 Description

Checkbox Group no longer unchecks Checkboxes whose value is changed programmatically.

📋 Checklist

🔬 How to Test

  1. Navigate to Checkbox Group in Storybook.
  2. Check the first Checkbox.
  3. Using DevTools, change the value of that Checkbox.
  4. Verify that Checkbox is still checked.
  5. Using DevTools, verify that the value of Checkbox Group includes the new Checkbox value.

📸 Images/Videos of Functionality

N/A

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: a54cba9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clintcs clintcs force-pushed the checkbox-group-uncheck branch 4 times, most recently from 1517826 to 9aeb74c Compare October 10, 2024 14:22
Copy link
Contributor

@clintcs clintcs marked this pull request as ready for review October 10, 2024 14:28
@clintcs clintcs force-pushed the checkbox-group-uncheck branch from 9aeb74c to a54cba9 Compare October 10, 2024 14:28
@clintcs clintcs changed the title Checkbox group uncheck Set Checkbox's value before dispatching "private-value-changed" Oct 10, 2024
@clintcs clintcs merged commit 38b7c7d into main Oct 10, 2024
7 checks passed
@clintcs clintcs deleted the checkbox-group-uncheck branch October 10, 2024 20:14
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载