This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Remove the status-indicator component #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f9049a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ynotdraw
commented
Sep 24, 2024
| } | ||
| .label { | ||
| color: var(--glide-core-text-body-2); |
There was a problem hiding this comment.
Explicitly set the colors, otherwise the color of the icon would get inherited by the text.
c2efdf3 to
fa2529a
Compare
clintcs
approved these changes
Sep 24, 2024
.changeset/moody-horses-smoke.md
Outdated
| '@crowdstrike/glide-core': minor | ||
| --- | ||
|
|
||
| Removed the Status Indicator component. |
fa2529a to
b4a0dd0
Compare
clintcs
reviewed
Sep 25, 2024
Co-authored-by: clintcs <114178960+clintcs@users.noreply.github.com>
danwenzel
approved these changes
Sep 25, 2024
dylankcrwd
approved these changes
Sep 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Moving Status Indicator upstream as it's only used in Toasts and has variants specific to one application, allowing Core to focus on shared components.
📋 Checklist
🔬 How to Test
📸 Images/Videos of Functionality
N/A