-
Notifications
You must be signed in to change notification settings - Fork 201
Comparing changes
Open a pull request
base repository: OWASP/pytm
base: v1.3.0
head repository: OWASP/pytm
compare: v1.3.1
- 12 commits
- 4 files changed
- 4 contributors
Commits on Mar 13, 2024
-
In #234 @colesmj suggested to move the import of pydal into the sqlDumb function. This commit does this and if the import fails raises an UIError with an explanation on how to proceed. The text is just a first draft. To move the import the function get_table was also moved inside the sqlDump function.
Configuration menu - View commit details
-
Copy full SHA for a53b3fd - Browse repository at this point
Copy the full SHA a53b3fdView commit details -
Merge pull request #235 from raphaelahrens/master
Added a first draft for #234
Configuration menu - View commit details
-
Copy full SHA for c4a81a4 - Browse repository at this point
Copy the full SHA c4a81a4View commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dafc08f - Browse repository at this point
Copy the full SHA dafc08fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 424f5d7 - Browse repository at this point
Copy the full SHA 424f5d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f57ca9 - Browse repository at this point
Copy the full SHA 8f57ca9View commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f868ffd - Browse repository at this point
Copy the full SHA f868ffdView commit details
Commits on Apr 12, 2024
-
Added
prerequisites
andlikelihood
to ThreatIn threats.json the two properties ("prerequisites", "Likelihood Of Attack") are defined, but are not used in the rest of pytm. This commit adds the two properties to the Threat class, so they can be used by other parts of pytm. For me this was relevant, since I started to experiment with a different format for threats mentioned in #237 . And after exporting threat.json to a markdown format and back into threat.json these two fields where missing.
Configuration menu - View commit details
-
Copy full SHA for bd363e9 - Browse repository at this point
Copy the full SHA bd363e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1295915 - Browse repository at this point
Copy the full SHA 1295915View commit details -
Merge pull request #241 from raphaelahrens/master
Added `prerequisites` and `likelihood` to Threat
Configuration menu - View commit details
-
Copy full SHA for 6ca9f75 - Browse repository at this point
Copy the full SHA 6ca9f75View commit details
Commits on Apr 18, 2024
-
Fixed #221 Got an error "AttributeError: 'str' ...
When pytm was run with the `--sqldump` flag with the example `tm.py` from the repository the execution failed with ``` AttributeError: 'str' object has no attribute 'name'" ``` This was caused by the `assumptions` attribute https://github.com/izar/pytm/blob/6ca9f75ddaa5bda3503a6b8cbce5e6700e03e644/tm.py#L20-L22 When dumping the model into the database all attributes of the TM class are turned into strings, by first turning the obj into a dictionary, where specific attributes are removed and some are converted, and then each value in the dictionary are turned into strings. This filtering and conversion is done by the `serilaize(obj, nested=False)` function. `sqlDump` transforms the values into strings. The problem in #221 was that when `nested` is false the default behavior of `serialize()` is to assume that any list of values holds objects which have either a `.name` or are an instance of `Finding`. Since `assumptions` is a list of strings this fails. The fix was to add `assumptions` to an already existing check for similar attributes. Also the check was changed from `i == x or ...` to an `in` check. But to be honest this code is very complex and holds many assumptions, which are not true for all classes and is constantly checking the type of the class. Maybe it would be best to write specific serialize functions for some classes, and only have a genral serialize function which takes in an object and a blacklist of attributes. The `to_serializable` singledispatch function already crates special functions for each class for the JSON conversion, maybe this can be extended.
Configuration menu - View commit details
-
Copy full SHA for 9c90a25 - Browse repository at this point
Copy the full SHA 9c90a25View commit details -
Merge pull request #242 from raphaelahrens/master
Fixed #221 Got an error "AttributeError: 'str' ...
Configuration menu - View commit details
-
Copy full SHA for 03a4747 - Browse repository at this point
Copy the full SHA 03a4747View commit details
Commits on Apr 20, 2024
-
Merge pull request #240 from izar/revealjs
Revealjs & update scorecard action version
Configuration menu - View commit details
-
Copy full SHA for b0c4388 - Browse repository at this point
Copy the full SHA b0c4388View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.3.0...v1.3.1