Fixed instances where HTTP methods don't match the type of params #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NARKOZ Need a review to merge this. |
|
Sorry, I'll get to this today. |
NARKOZ
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #581, I noticed a mismatch where a
querywas passed instead of abodyin aputrequest. I fixed it in https://github.com/NARKOZ/gitlab/pull/582/files#diff-02a255696d374d3f496912f418e45429L61-R71I suspected there might be similar issues with
post,putanddeletein other endpoints as well. Ran a few simple checks, and found a few mismatches. Have cross-checked with the API docs and found a few that are rightly so, but a few actual bugs as well. This PR fixes all those mismatches.