Fixes session ticket / PSK not set #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaukas Wang <i@gaukas.wang>
gaukas
approved these changes
Jul 16, 2024
Contributor
gaukas
left a comment
There was a problem hiding this comment.
Looks good, I appreciate your efforts in catching and fixing the bug!
Contributor
|
If no more edits are going to be made on this pull request, I will be merging it by the end of day. Let me know before that if you want me to hold @adotkhan. |
adotkhan
added a commit
to Psiphon-Labs/utls
that referenced
this pull request
Dec 10, 2024
* Add setters for SessionState fields createdAt, UseBy, and AgeAdd * chore: remove accidental comments from code * fix: incorrect clientHelloBuildStatus after BuildHandshakeStateWithoutSession Reviewed-by: Gaukas Wang <i@gaukas.wang> * chore: add empty lines between functions Signed-off-by: Gaukas Wang <i@gaukas.wang> --------- Signed-off-by: Gaukas Wang <i@gaukas.wang> Co-authored-by: Gaukas Wang <i@gaukas.wang>
adotkhan
added a commit
to Psiphon-Labs/utls
that referenced
this pull request
Dec 10, 2024
* Add setters for SessionState fields createdAt, UseBy, and AgeAdd * chore: remove accidental comments from code * fix: incorrect clientHelloBuildStatus after BuildHandshakeStateWithoutSession Reviewed-by: Gaukas Wang <i@gaukas.wang> * chore: add empty lines between functions Signed-off-by: Gaukas Wang <i@gaukas.wang> --------- Signed-off-by: Gaukas Wang <i@gaukas.wang> Co-authored-by: Gaukas Wang <i@gaukas.wang>
adotkhan
added a commit
to Psiphon-Labs/utls
that referenced
this pull request
Feb 5, 2025
* Add setters for SessionState fields createdAt, UseBy, and AgeAdd * chore: remove accidental comments from code * fix: incorrect clientHelloBuildStatus after BuildHandshakeStateWithoutSession Reviewed-by: Gaukas Wang <i@gaukas.wang> * chore: add empty lines between functions Signed-off-by: Gaukas Wang <i@gaukas.wang> --------- Signed-off-by: Gaukas Wang <i@gaukas.wang> Co-authored-by: Gaukas Wang <i@gaukas.wang>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(*sessionController).shouldLoadSessionalways returnsshouldReturn.Review by the uTLS maintainers is much appreciated.