[ci-skip][doc] Fix typos and errors in wishlists.md #56001
Conversation
[ci-skip][doc] Fix filename in wishlist.md [ci-skip][doc] Fix link paths in wishlists.md [ci-skip][doc] Fix pluralize method in wishlists.md [ci-skip][doc] Fix assertion in wishlists.md
| class Product < ApplicationRecord | ||
| include Notifications | ||
| has_many :subscribers, dependent: :destroy |
There was a problem hiding this comment.
Do the highlighted lines need to be updated?
There was a problem hiding this comment.
I think so. In getting_started.md, the concern pp/models/product/notifications.rb already has the one:
module Product::Notifications
extend ActiveSupport::Concern
included do
has_many :subscribers, dependent: :destroy # this should work
after_update_commit :notify_subscribers, if: :back_in_stock?
endAs far as I followed the steps in getting_started.md, the highlighted line has_many :subscribers, dependent: :destroy is unnecessary.
There was a problem hiding this comment.
I'm sorry, I should have been more specific: at the top of this code block is rb#5-6 which causes lines 5 through 6 to be highlighted in the generated guide. Since we're removing a line shouldn't we update which line numbers should be highlighted as well?
There was a problem hiding this comment.
Aha, now I get this😅 Yes, I should have also updated the highlight from 5-6 to 4-5. Just a moment.
[ci-skip][doc] Fix typos and errors in wishlists.md
Motivation / Background
This Pull Request has been created because wishlists.md contains some errors and typos that disturbs running tests.
Detail
This Pull Request contains the following:
has_many :subscribers, dependent: :destroyfromProductmodel because it includesNotificationsconcern that already declares thehas_many: subscribersassociation. Current declaration is redundant and inconsistent with the finalProductmodel in getting_started.md.app/models/wishlist.rbtoapp/models/wishlist_product.rb.store_products_pathtostore_wishlists_path.pluralize "Subscriber", @subscribers.counttopluralize @subscribers.count, "Subscriber".Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]