fix(linter/plugins): block access to context.settings in createOnce (#15394)

overlookmotel · overlookmotel · commit fde753e02303 · 2025-11-06T17:33:57.000Z
Follow-on after #14724. Prevent accessing `context.settings` in `createOnce`. Settings are per-file, so they shouldn't be available in `createOnce`.
diff --git a/apps/oxlint/src-js/plugins/context.ts b/apps/oxlint/src-js/plugins/context.ts
@@ -56,7 +56,7 @@ let cwd: string | null = null;
 export let setupContextForFile: (context: Context, ruleIndex: number, filePath: string) => void;
 
 // Settings for current file. Set before linting a file by `setSettingsForFile`.
-let settings: Record<string, unknown> = {};
+let settings: Record<string, unknown> = null;
 
 /**
  * Updates the settings record for the file.
@@ -164,6 +164,7 @@ export class Context {
   }
 
   get settings() {
+    getInternal(this, 'access `context.settings`');
     return settings;
   }
 
diff --git a/apps/oxlint/test/fixtures/createOnce/output.snap.md b/apps/oxlint/test/fixtures/createOnce/output.snap.md
@@ -75,6 +75,12 @@
    : ^
    `----
 
+  x create-once-plugin(always-run): createOnce: settings: Cannot access `context.settings` in `createOnce`
+   ,-[files/1.js:1:1]
+ 1 | let x;
+   : ^
+   `----
+
   x create-once-plugin(always-run): createOnce: sourceCode: Cannot access `context.sourceCode` in `createOnce`
    ,-[files/1.js:1:1]
  1 | let x;
@@ -207,6 +213,12 @@
    : ^
    `----
 
+  x create-once-plugin(always-run): createOnce: settings: Cannot access `context.settings` in `createOnce`
+   ,-[files/2.js:1:1]
+ 1 | let y;
+   : ^
+   `----
+
   x create-once-plugin(always-run): createOnce: sourceCode: Cannot access `context.sourceCode` in `createOnce`
    ,-[files/2.js:1:1]
  1 | let y;
@@ -267,7 +279,7 @@
    :     ^
    `----
 
-Found 0 warnings and 44 errors.
+Found 0 warnings and 46 errors.
 Finished in Xms on 2 files using X threads.
 ```
 
diff --git a/apps/oxlint/test/fixtures/createOnce/plugin.ts b/apps/oxlint/test/fixtures/createOnce/plugin.ts
@@ -34,6 +34,7 @@ const alwaysRunRule: Rule = {
     const physicalFilenameError = tryCatch(() => context.physicalFilename);
     const optionsError = tryCatch(() => context.options);
     const sourceCodeError = tryCatch(() => context.sourceCode);
+    const settingsError = tryCatch(() => context.settings);
     const reportError = tryCatch(() => context.report({ message: 'oh no', node: SPAN }));
 
     return {
@@ -45,6 +46,7 @@ const alwaysRunRule: Rule = {
         context.report({ message: `createOnce: physicalFilename: ${physicalFilenameError?.message}`, node: SPAN });
         context.report({ message: `createOnce: options: ${optionsError?.message}`, node: SPAN });
         context.report({ message: `createOnce: sourceCode: ${sourceCodeError?.message}`, node: SPAN });
+        context.report({ message: `createOnce: settings: ${settingsError?.message}`, node: SPAN });
         context.report({ message: `createOnce: report: ${reportError?.message}`, node: SPAN });
 
         context.report({ message: `before hook: id: ${context.id}`, node: SPAN });

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ let cwd: string \| null = null;`
`56`	`56`	`export let setupContextForFile: (context: Context, ruleIndex: number, filePath: string) => void;`
`57`	`57`
`58`	`58`	// Settings for current file. Set before linting a file by `setSettingsForFile`.
`59`		`-let settings: Record<string, unknown> = {};`
	`59`	`+let settings: Record<string, unknown> = null;`
`60`	`60`
`61`	`61`	`/**`
`62`	`62`	`* Updates the settings record for the file.`
`@@ -164,6 +164,7 @@ export class Context {`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`get settings() {`
	`167`	+ getInternal(this, 'access `context.settings`');
`167`	`168`	`return settings;`
`168`	`169`	`}`
`169`	`170`