Update cralwer to crawl all io.opentelemetry.* groups #7316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
May 2, 2025
| @@ -146,6 +182,7 @@ static List<String> crawlJavaDocs(HttpClient client, List<Artifact> artifacts) | |||
| .append("/package-summary.html"); | |||
|
|
|||
| HttpRequest crawlRequest = HttpRequest.newBuilder(URI.create(path.toString())).GET().build(); | |||
| logger.info(String.format("Crawling %s at: %s", artifact, path)); | |||
There was a problem hiding this comment.
I find extra logging is almost always helpful for scripts
In this case, logging helped me discover that we were scanning a bunch of old artifacts, and not scanning artifacts from other groups (maven must have exact matching on groups, rather than startsWith matching).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7316 +/- ##
=========================================
Coverage 90.03% 90.03%
Complexity 6915 6915
=========================================
Files 787 787
Lines 20864 20864
Branches 2023 2023
=========================================
Hits 18784 18784
Misses 1441 1441
Partials 639 639 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding on @jaydeluca's javadoc crawler work from #7300 to crawl all groups we publish artifacts to: