这是indexloc提供的服务，不要输入任何密码
Skip to content

cephfs/admin: Add API to fetch subvolume snapshot path #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2025
Merged

cephfs/admin: Add API to fetch subvolume snapshot path #1113

merged 3 commits into from
May 25, 2025

Conversation

@anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented May 2, 2025

based on ceph/ceph#62708

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@anoopcs9 anoopcs9 force-pushed the add-subvol-snappath-api branch from 0b60425 to abd2051 Compare May 2, 2025 10:45
@anoopcs9 anoopcs9 requested review from ansiwen and phlogistonjohn May 2, 2025 13:39
@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label May 2, 2025
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented May 2, 2025

cc: @rishabh-d-dave @gregsfortytwo

phlogistonjohn
phlogistonjohn approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoopcs9 anoopcs9 closed this May 9, 2025
@anoopcs9 anoopcs9 deleted the add-subvol-snappath-api branch May 9, 2025 18:40
@anoopcs9 anoopcs9 restored the add-subvol-snappath-api branch May 9, 2025 18:40
@anoopcs9 anoopcs9 reopened this May 9, 2025
@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented May 15, 2025

@Mergifyio rebase

anoopcs9 added 3 commits May 15, 2025 14:17
@anoopcs9 @phlogistonjohn
cephfs/admin: Add SubVolumeSnapshotPath API
0544455 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 @phlogistonjohn
cephfs/admin: Add tests for SubVolumeSnapshotPath API
32f45a3 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 @phlogistonjohn
docs: Add SubVolumeSnapshotPath API to api-status
8b2f469 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@mergify
Copy link

mergify bot commented May 15, 2025

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the add-subvol-snappath-api branch from abd2051 to 8b2f469 Compare May 15, 2025 14:17
@mergify mergify bot merged commit e674030 into ceph:master May 25, 2025
15 of 16 checks passed
@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented May 25, 2025

I'm not entirely sure why mergify merged this today. Maybe it got tired of waiting for reviews...

More seriously, there is a "time limit" rule but it doesn't indicate that the rule got applied when you look at the status. 🤷

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented May 26, 2025

More seriously, there is a "time limit" rule but it doesn't indicate that the rule got applied when you look at the status. 🤷

You are right that the status doesn't mention it but the timeline perfectly aligns with the following rule:

        - and:
          - label=API
          - "#approved-reviews-by>=1"
          - "updated-at<10 days ago"

This can very well be a bug on mergify side..who knows !

@anoopcs9 anoopcs9 deleted the add-subvol-snappath-api branch May 26, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@ansiwen ansiwen Awaiting requested review from ansiwen

Assignees

No one assigned

Labels

API This PR includes a change to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anoopcs9 @phlogistonjohn