refactor: add caching for client rects and improve highlight cleanup logic #1551
+113
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced caching for client rects using a WeakMap to optimize performance. - Enhanced highlightElement function to use a document fragment for batch DOM updates. - Added cleanup function to manage event listeners and overlay elements efficiently. - Implemented throttling for position updates during scroll and resize events. - Updated getXPathTree to cache results for improved efficiency.
|
|
Contributor
There was a problem hiding this comment.
mrge reviewed 1 file and found no issues. Review this PR in mrge.io.
dharam1291
pushed a commit
to dharam1291/browser-use
that referenced
this pull request
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by mrge
Added caching for client rects and XPath lookups to speed up DOM operations, and improved highlight cleanup to manage overlays and event listeners more efficiently.