From 4d5f1743e29b4d9742a06d08d46d8ba4932ef263 Mon Sep 17 00:00:00 2001
From: Ruwen <13171091-ruwen@users.noreply.gitlab.com>
Date: Tue, 28 Oct 2025 10:38:28 +1100
Subject: [PATCH] fix(protected_packages): fix invalid types

The API docs clearly state strings but the SDK is currently using int64.
This fixes this.
---
 protected_packages.go      | 8 ++++----
 protected_packages_test.go | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/protected_packages.go b/protected_packages.go
index 711427c8..890765e6 100644
--- a/protected_packages.go
+++ b/protected_packages.go
@@ -69,8 +69,8 @@ type ListPackageProtectionRulesOptions struct {
 type CreatePackageProtectionRulesOptions struct {
 	PackageNamePattern          *string `url:"package_name_pattern" json:"package_name_pattern"`
 	PackageType                 *string `url:"package_type" json:"package_type"`
-	MinimumAccessLevelForDelete *int64  `url:"minimum_access_level_for_delete" json:"minimum_access_level_for_delete"`
-	MinimumAccessLevelForPush   *int64  `url:"minimum_access_level_for_push" json:"minimum_access_level_for_push"`
+	MinimumAccessLevelForDelete *string `url:"minimum_access_level_for_delete" json:"minimum_access_level_for_delete"`
+	MinimumAccessLevelForPush   *string `url:"minimum_access_level_for_push" json:"minimum_access_level_for_push"`
 }
 
 // UpdatePackageProtectionRulesOptions represents the available
@@ -81,8 +81,8 @@ type CreatePackageProtectionRulesOptions struct {
 type UpdatePackageProtectionRulesOptions struct {
 	PackageNamePattern          *string `url:"package_name_pattern" json:"package_name_pattern"`
 	PackageType                 *string `url:"package_type" json:"package_type"`
-	MinimumAccessLevelForDelete *int64  `url:"minimum_access_level_for_delete" json:"minimum_access_level_for_delete"`
-	MinimumAccessLevelForPush   *int64  `url:"minimum_access_level_for_push" json:"minimum_access_level_for_push"`
+	MinimumAccessLevelForDelete *string `url:"minimum_access_level_for_delete" json:"minimum_access_level_for_delete"`
+	MinimumAccessLevelForPush   *string `url:"minimum_access_level_for_push" json:"minimum_access_level_for_push"`
 }
 
 func (s *ProtectedPackagesService) ListPackageProtectionRules(pid any, opts *ListPackageProtectionRulesOptions, options ...RequestOptionFunc) ([]*PackageProtectionRule, *Response, error) {
diff --git a/protected_packages_test.go b/protected_packages_test.go
index 088645db..7b783859 100644
--- a/protected_packages_test.go
+++ b/protected_packages_test.go
@@ -73,8 +73,8 @@ func TestProtectedPackagesService_CreatePackageProtectionRules(t *testing.T) {
 	opts := &CreatePackageProtectionRulesOptions{
 		PackageNamePattern:          Ptr("@my-scope/my-package-*"),
 		PackageType:                 Ptr("npm"),
-		MinimumAccessLevelForDelete: Ptr(int64(MaintainerPermissions)),
-		MinimumAccessLevelForPush:   Ptr(int64(OwnerPermissions)),
+		MinimumAccessLevelForDelete: Ptr("maintainer"),
+		MinimumAccessLevelForPush:   Ptr("owner"),
 	}
 
 	rule, resp, err := client.ProtectedPackages.CreatePackageProtectionRules(1, opts)
@@ -112,7 +112,7 @@ func TestProtectedPackagesService_UpdatePackageProtectionRules(t *testing.T) {
 
 	opts := &UpdatePackageProtectionRulesOptions{
 		PackageNamePattern:        Ptr("@my-scope/my-package-updated"),
-		MinimumAccessLevelForPush: Ptr(int64(OwnerPermissions)),
+		MinimumAccessLevelForPush: Ptr("owner"),
 	}
 
 	rule, resp, err := client.ProtectedPackages.UpdatePackageProtectionRules(1, int64(123), opts)
-- 
GitLab