From 8aa321f29ac7dbea93b00484b6b645559383ce3a Mon Sep 17 00:00:00 2001
From: zubeen <zubeenqadry@gmail.com>
Date: Wed, 8 Oct 2025 04:32:22 +0530
Subject: [PATCH 1/3] test:add UT for formatPackageURL

---
 generic_packages_test.go | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/generic_packages_test.go b/generic_packages_test.go
index eff706e6..7f2f1868 100644
--- a/generic_packages_test.go
+++ b/generic_packages_test.go
@@ -64,3 +64,19 @@ func TestDownloadPackageFile(t *testing.T) {
 		t.Errorf("GenericPackages.DownloadPackageFile returned %+v, want %+v", packageBytes, want)
 	}
 }
+
+func TestFormatPackageURL(t *testing.T) {
+	t.Parallel()
+	_, client := setup(t)
+	service := &GenericPackagesService{client: client}
+
+	url, err := service.FormatPackageURL(1234, "foo", "0.1.2", "bar-baz.txt")
+	if err != nil {
+		t.Fatalf("FormatPackageURL returned error: %v", err)
+	}
+
+	want := "projects/1234/packages/generic/foo/0%2E1%2E2/bar-baz%2Etxt"
+	if url != want {
+		t.Errorf("FormatPackageURL returned %q, want %q", url, want)
+	}
+}
-- 
GitLab


From 8143478912d2b7f1c7f214d5bc29696a43ae3313 Mon Sep 17 00:00:00 2001
From: zubeen <zubeenqadry@gmail.com>
Date: Fri, 17 Oct 2025 22:09:01 +0530
Subject: [PATCH 2/3] resolve review comments

---
 generic_packages_test.go | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/generic_packages_test.go b/generic_packages_test.go
index 7f2f1868..e928fb5b 100644
--- a/generic_packages_test.go
+++ b/generic_packages_test.go
@@ -18,6 +18,7 @@ package gitlab
 
 import (
 	"fmt"
+	"github.com/stretchr/testify/assert"
 	"net/http"
 	"reflect"
 	"strings"
@@ -68,15 +69,10 @@ func TestDownloadPackageFile(t *testing.T) {
 func TestFormatPackageURL(t *testing.T) {
 	t.Parallel()
 	_, client := setup(t)
-	service := &GenericPackagesService{client: client}
 
-	url, err := service.FormatPackageURL(1234, "foo", "0.1.2", "bar-baz.txt")
-	if err != nil {
-		t.Fatalf("FormatPackageURL returned error: %v", err)
-	}
+	url, err := client.GenericPackages.FormatPackageURL(1234, "foo", "0.1.2", "bar-baz.txt")
+	assert.NoError(t, err)
 
 	want := "projects/1234/packages/generic/foo/0%2E1%2E2/bar-baz%2Etxt"
-	if url != want {
-		t.Errorf("FormatPackageURL returned %q, want %q", url, want)
-	}
+	assert.Equal(t, want, url)
 }
-- 
GitLab


From cbff5afd1c1eb954ba6565d4fc353eac79dbc855 Mon Sep 17 00:00:00 2001
From: zubeen <zubeenqadry@gmail.com>
Date: Fri, 17 Oct 2025 22:18:17 +0530
Subject: [PATCH 3/3] resolve review comments

---
 generic_packages_test.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/generic_packages_test.go b/generic_packages_test.go
index e928fb5b..5d0181ca 100644
--- a/generic_packages_test.go
+++ b/generic_packages_test.go
@@ -18,11 +18,12 @@ package gitlab
 
 import (
 	"fmt"
-	"github.com/stretchr/testify/assert"
 	"net/http"
 	"reflect"
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
 func TestPublishPackageFile(t *testing.T) {
-- 
GitLab