这是indexloc提供的服务，不要输入任何密码
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chartjs/chartjs-plugin-annotation
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: yusufozturk/chartjs-plugin-annotation
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 12 files changed
  • 2 contributors

Commits on May 20, 2017

  1. Check "Scales" on ChartOptions 

    Check Scales on ChartOptions to avoid null errors.
    @yusufozturk @compwright
    yusufozturk authored and compwright committed May 20, 2017
    Configuration menu
    Copy the full SHA
    3fc490f View commit details
    Browse the repository at this point in the history

  2. Support for non-numeric values on axis 

    Annotation plugin only supports numeric values on Axis. Because of that, you can not set annotation on axis values like date or string values.

Fixes #47
    @yusufozturk @compwright
    yusufozturk authored and compwright committed May 20, 2017
    Configuration menu
    Copy the full SHA
    d464195 View commit details
    Browse the repository at this point in the history

  3. Changing default draw behavior of Annotation plugin 

    Annotation plugin must be drawn before Tooltips, otherwise tooltips are not visible. This is for best look.
    @yusufozturk @compwright
    yusufozturk authored and compwright committed May 20, 2017
    Configuration menu
    Copy the full SHA
    19bbcbc View commit details
    Browse the repository at this point in the history

  4. Checking Events property if its null or not 

    If there is no defined event, back end code like c# may send "Events" as null.
In that case, watchFor control gives error because it's just checking Length, before checking if object is null or not.
    @yusufozturk @compwright
    yusufozturk authored and compwright committed May 20, 2017
    Configuration menu
    Copy the full SHA
    c4edbdc View commit details
    Browse the repository at this point in the history

  5. Don’t run on charts that do not have scales 

    Pie, polar area, and radar charts are not supported because they do not have two scales
    @compwright
    compwright committed May 20, 2017
    Configuration menu
    Copy the full SHA
    c20897f View commit details
    Browse the repository at this point in the history

  6. Add working examples and update readme

    @compwright
    compwright committed May 20, 2017
    Configuration menu
    Copy the full SHA
    7d2c256 View commit details
    Browse the repository at this point in the history
Loading