这是indexloc提供的服务，不要输入任何密码
Skip to content

[cookies] Add --cookies-from-browser support for Zen #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[cookies] Add --cookies-from-browser support for Zen #14596

wants to merge 4 commits into from
+38 −22

Conversation

@hermitpopcorn
Copy link

@hermitpopcorn hermitpopcorn commented Oct 11, 2025

Description of your pull request and other information

Duplicate of #13323. The original PR author (rolandcrosby) seems to be inactive so I took their commit and created a new PR to see why the CI core test failed (it was so long ago that the log has expired) and try to fix it myself.

Add --cookies-from-browser support for Zen, which is based on Firefox. Should also make it straightforward to add other Firefox-based browsers that use the same cookie format.

Tested by the original author on macOS, and I tested it on Windows.

I was only able to test this on macOS. For Windows and Linux, I'm using the profile paths listed in the Zen FAQ here.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:

What is the purpose of your pull request? Check those that apply and remove the others:

@doe1080 doe1080 added core-triage triage requested from a core dev core:cookies Related to core cookie handling (e.g. --cookies or --cookies-from-browser) duplicate This issue or pull request already exists labels Oct 11, 2025
@hermitpopcorn
Copy link
Author

hermitpopcorn commented Oct 13, 2025

Windows fatal exception: code 0xc0000374
Thread 0x00001910 (most recent call first):
File "C:\hostedtoolcache\windows\Python\3.14.0\x64\Lib\socket.py"Windows fatal exception: access violation

It feels to me like the tests failed not because of the changes in the PR itself but because of a segfault by a program used to run the tests

@MonterraByte
Copy link

MonterraByte commented Oct 14, 2025

It feels to me like the tests failed not because of the changes in the PR itself but because of a segfault by a program used to run the tests

See #14067.

paralin
paralin reviewed Nov 13, 2025
View reviewed changes
Copy link

@paralin paralin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@paralin
Copy link

paralin commented Nov 13, 2025

Rebased this commit here: paralin@1e464a0

@bashonly
Copy link
Member

bashonly commented Nov 13, 2025

Is this doing anything besides adding default profile paths for Zen?

We typically don't add browser forks/variants unless they need special handling that can't be achieved via command line

--cookies-from-browser firefox:/path/to/zen/profile should work just fine, yeah?

@hermitpopcorn
Copy link
Author

hermitpopcorn commented Nov 14, 2025

Is this doing anything besides adding default profile paths for Zen?

No, I don't think so.

We typically don't add browser forks/variants unless they need special handling that can't be achieved via command line

Sorry, I didn't know about this. Seeing the cookies.py file it looked to me like the chromium variants aren't doing much so I assumed this one would be a fair addition (but then again I didn't actually work on this and only resolved the merge conflicts).

Still would be great if I could just type --cookies-from-browser zen without having to specify the profile path every time so personally I'd still like to ask for this to be approved for merge, but you can close this PR if it doesn't match the project rules/guidelines.

@paralin
Copy link

paralin commented Nov 15, 2025

I and many other Ublock-enjoyers switched from Chrome to Firefox a while back and then from Firefox to Zen when the whole "left side bar" concept came around. It's pretty popular / famous and used by many big names in software.

Thank you for coming to my pro-Zen ted talk. I would just like to also vote for --cookies-from-browser zen to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@paralin paralin paralin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core:cookies Related to core cookie handling (e.g. --cookies or --cookies-from-browser) core-triage triage requested from a core dev duplicate This issue or pull request already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hermitpopcorn @MonterraByte @paralin @bashonly @doe1080 @rolandcrosby