release-19.1: util/log: ensure stderr is only redirected to th… (cock…

…roachdb#40942)

release-19.1: util/log: ensure stderr is only redirected to the main log

Merge pull request cockroachdb#40753 from ajkr/release-2.0-rocksdb-co…

…mparator-fix

release-2.0: c-deps: bump rocksdb for comparator fix

Merge pull request cockroachdb#40752 from ajkr/release-2.1-rocksdb-co…

…mparator-fix

release-2.1: c-deps: bump rocksdb for comparator fix

Merge pull request cockroachdb#40752 from ajkr/release-2.1-rocksdb-co…

…mparator-fix

release-2.1: c-deps: bump rocksdb for comparator fix

Merge cockroachdb#40609 cockroachdb#40617 cockroachdb#40619

40609: roachtest: update 19.1 hibernate blacklist r=rafiss a=rafiss

The blacklist had too many expected failures. Most of them were related
to earlier issues with the test being unable to connect to the cluster. Also, remove
the `--info` option from the test runner command, since it makes too much output.

touches cockroachdb#40538

Release note: None

40617: opt: fix scalar building error handling r=RaduBerinde a=RaduBerinde

We are incorrectly returning `nil` error in an error case. This leads
to an assertion error instead of a "could not decorrelate subquery"
error.

Fixes cockroachdb#40590.

Release note: None

40619: cliccl: Change license acquisition URL r=rohany a=rohany

Change the cockroach demo license acquisition URLs to point to a new URL.

Release note: None

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>

Merge cockroachdb#40577

40577: exec: bugfix to CASE operator with no input r=jordanlewis a=jordanlewis

Previously, the CASE operator short-circuited if there were no input
rows. This was problematic, because without running all of the arms of
the operator at least once, its output batch might not get extended to
the width that downstream operators expect.

Also, add CASE arms to EXPLAIN(VEC) to help with debugging.
The first child of CASE is its input. The 2nd-(n-1)th children are the
CASE arms. The nth child is the ELSE arm.

Fixes cockroachdb#40574.

Release note: None


Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>

Merge cockroachdb#40545

40545: exec: add statistics for TPCH tables in tpch vec logic test r=yuzefovich a=yuzefovich

Previously, the tables were created without any stats on them which
caused the plans to be different from the ones we would get when
running on actual TPCH dataset. Now we add statistics for scale
factor 1, and the plans are realistic.

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>

Merge cockroachdb#40527

40527: Revert "closedts: shorten target_duration from 30s to 5s" r=andy-kimball a=ajwerner

This reverts commit 3e97e57.

The last couple of weeks of experience show that tests become flakey with
the target_duration set to 5s. This isn't overly surprising given that updates
to table descriptors observe their own timestamp and thus can never be
refreshed.

See https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/sqlbase/structured.go#L1496-L1509

References cockroachdb#39643.

Release note: None

Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>

Merge cockroachdb#40468

40468: opt: fix error due to incorrect number of columns after EliminateDistinct r=rytaft a=rytaft

This commit fixes an error that could occur due to the `EliminateDistinct`
rule, which eliminates a `DistinctOn` operator when the grouping columns
are known to form a strong key. The problem with eliminating the `DistinctOn`
completely is that it has a secondary purpose as a `Project` operator, and
removing it could result in an incorrect number of output columns. This
commit fixes that rule so that it replaces the `DistinctOn` with a `Project`
operator.

Fixes cockroachdb#40295

Release note (bug fix): Fixed an internal planning error that could
occur when a DISTINCT or GROUP BY expression was contained in a subquery.

Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>

Merge pull request cockroachdb#40353 from ajkr/backport2.1-35210

release-2.1: libroach: disable rocksdb subcompactions