-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Batch and BufferImprovements in internal data structures, temporary labelImprovements in internal data structures, temporary labelbreaking changesChanges in public interfaces. Includes small changes or changes in keysChanges in public interfaces. Includes small changes or changes in keysrefactoringNo change to functionalityNo change to functionality
Description
Currently Batch.__getitem__ will always create a new object. This is counterintuitive and destroys equality checks. E.g.,
b = Batch(...)
id1 = id(b[0])
id2 = id(b[0])will result in id1 != id2, which leads to b[0] == b[0] being False
Related to #922
Metadata
Metadata
Assignees
Labels
Batch and BufferImprovements in internal data structures, temporary labelImprovements in internal data structures, temporary labelbreaking changesChanges in public interfaces. Includes small changes or changes in keysChanges in public interfaces. Includes small changes or changes in keysrefactoringNo change to functionalityNo change to functionality
Type
Projects
Status
Done