diff --git a/CODEOWNERS b/CODEOWNERS index da449e896c4c9d..888a4bbc89e013 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -15,6 +15,9 @@ /scripts/ @Grimler91 @thunder-coding /repo.json @Grimler91 @thunder-coding +# Build script linter +/scripts/lint-packages.sh @TomJo2000 + # Repository Health Check /scripts/check-repository-health.js @thunder-coding /scripts/generate-apt-packages-list.sh @thunder-coding diff --git a/scripts/lint-packages.sh b/scripts/lint-packages.sh index 65d8e71c4fdb67..2f0dab26dace94 100755 --- a/scripts/lint-packages.sh +++ b/scripts/lint-packages.sh @@ -148,14 +148,14 @@ check_version() { (( i++ )) # Is this version valid? - dpkg --validate-version "${version}" &>/dev/null || { + dpkg --validate-version "${version}" &> /dev/null || { printf 'INVALID %s\n' "$(dpkg --validate-version "${version}" 2>&1)" (( error++ )) continue } # Was the package modified in this branch? - git diff --exit-code "${base_commit}" -- "${package_dir}" 2> /dev/null && { + git diff --exit-code "${base_commit}" -- "${package_dir}" &> /dev/null && { printf '%s\n' "PASS - ${version} (not modified in this branch)" continue } @@ -175,7 +175,7 @@ check_version() { # Is ${version_old} valid? local version_old_is_bad="" - dpkg --validate-version "${version_old}" &>/dev/null || version_old_is_bad="0~invalid" + dpkg --validate-version "${version_old}" &> /dev/null || version_old_is_bad="0~invalid" # If ${version_new} isn't greater than "$version_old" that's an issue. # If ${version_old} isn't valid this check is a no-op.