Fixed: Fix markdown link generation

agnostic-apollo · agnostic-apollo · commit 8ee0c5a6ec67 · 2021-08-20T06:19:25.000+05:00
The `]` characters in label and `)` characters in url must be escaped.
diff --git a/termux-shared/src/main/java/com/termux/shared/markdown/MarkdownUtils.java b/termux-shared/src/main/java/com/termux/shared/markdown/MarkdownUtils.java
@@ -119,9 +119,9 @@ public static String getMultiLineMarkdownStringEntry(String label, Object object
             return "**" + label + "**: " + def + "\n";
     }
 
-    public static String getLinkMarkdownString(String label, Object object) {
-        if (object != null)
-            return "[" + label + "](" + object +  ")";
+    public static String getLinkMarkdownString(String label, String url) {
+        if (url != null)
+            return "[" + label.replaceAll("]", "\\\\]") + "](" + url.replaceAll("\\)", "\\\\)") +  ")";
         else
             return label;
     }

Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,9 @@ public static String getMultiLineMarkdownStringEntry(String label, Object object`
`119`	`119`	`return "" + label + ": " + def + "\n";`
`120`	`120`	`}`
`121`	`121`
`122`		`- public static String getLinkMarkdownString(String label, Object object) {`
`123`		`- if (object != null)`
`124`		`- return "[" + label + "](" + object + ")";`
	`122`	`+ public static String getLinkMarkdownString(String label, String url) {`
	`123`	`+ if (url != null)`
	`124`	`+ return "[" + label.replaceAll("]", "\\\\]") + "](" + url.replaceAll("\\)", "\\\\)") + ")";`
`125`	`125`	`else`
`126`	`126`	`return label;`
`127`	`127`	`}`