Fixed: Do not use colon character ":" in log tag since it is invalid and breaks logcat command filterspecs argument

agnostic-apollo · agnostic-apollo · commit 1b794b35181c · 2022-01-23T01:40:22.000+05:00
diff --git a/termux-shared/src/main/java/com/termux/shared/logger/Logger.java b/termux-shared/src/main/java/com/termux/shared/logger/Logger.java
@@ -450,11 +450,17 @@ public static int setLogLevel(Context context, int logLevel) {
         return CURRENT_LOG_LEVEL;
     }
 
+    /** The colon character ":" must not exist inside the tag, otherwise the `logcat` command
+     * filterspecs arguments `<tag>[:priority]` will not work and will throw `Invalid filter expression`
+     * error.
+     * https://cs.android.com/android/platform/superproject/+/android-12.0.0_r4:system/logging/liblog/logprint.cpp;l=363
+     * https://cs.android.com/android/platform/superproject/+/android-12.0.0_r4:system/logging/logcat/logcat.cpp;l=884
+     * */
     public static String getFullTag(String tag) {
         if (DEFAULT_LOG_TAG.equals(tag))
             return tag;
         else
-            return DEFAULT_LOG_TAG + ":" + tag;
+            return DEFAULT_LOG_TAG + "." + tag;
     }
 
     public static boolean isLogLevelValid(Integer logLevel) {
