Changed|Fixed: Use TERMUX_API_FILE_SHARE_URI_AUTHORITY for content provided uri and fix sharing paths with "#"

agnostic-apollo · agnostic-apollo · commit 9a9e3eaee674 · 2022-03-14T22:57:23.000+05:00
diff --git a/app/src/main/java/com/termux/api/TermuxAPIConstants.java b/app/src/main/java/com/termux/api/TermuxAPIConstants.java
@@ -11,4 +11,7 @@ public class TermuxAPIConstants {
      */
     public static final String TERMUX_API_RECEIVER_NAME = TERMUX_API_PACKAGE_NAME + ".TermuxApiReceiver"; // Default to "com.termux.api.TermuxApiReceiver"
 
+    /** The Uri authority for Termux:API app file shares */
+    public static final String TERMUX_API_FILE_SHARE_URI_AUTHORITY = TERMUX_PACKAGE_NAME + ".sharedfiles"; // Default: "com.termux.sharedfiles"
+
 }
diff --git a/app/src/main/java/com/termux/api/apis/ShareAPI.java b/app/src/main/java/com/termux/api/apis/ShareAPI.java
@@ -12,9 +12,11 @@
 import android.webkit.MimeTypeMap;
 
 import com.termux.api.R;
+import com.termux.api.TermuxAPIConstants;
 import com.termux.api.TermuxApiReceiver;
 import com.termux.api.util.ResultReturner;
 import com.termux.shared.logger.Logger;
+import com.termux.shared.net.uri.UriUtils;
 
 import java.io.File;
 import java.io.FileNotFoundException;
@@ -88,7 +90,9 @@ public void writeResult(PrintWriter out) {
 
                 Intent sendIntent = new Intent();
                 sendIntent.setAction(finalIntentAction);
-                Uri uriToShare = Uri.parse("content://com.termux.sharedfiles" + fileToShare.getAbsolutePath());
+
+                // Do not create Uri with Uri.parse() and use Uri.Builder().path(), check UriUtils.getUriFilePath().
+                Uri uriToShare = UriUtils.getContentUri(TermuxAPIConstants.TERMUX_API_FILE_SHARE_URI_AUTHORITY, fileToShare.getAbsolutePath());
                 sendIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_GRANT_READ_URI_PERMISSION);
 
                 String contentTypeToUse;

Original file line number	Diff line number	Diff line change
`@@ -11,4 +11,7 @@ public class TermuxAPIConstants {`
`11`	`11`	`*/`
`12`	`12`	`public static final String TERMUX_API_RECEIVER_NAME = TERMUX_API_PACKAGE_NAME + ".TermuxApiReceiver"; // Default to "com.termux.api.TermuxApiReceiver"`
`13`	`13`
	`14`	`+ /** The Uri authority for Termux:API app file shares */`
	`15`	`+ public static final String TERMUX_API_FILE_SHARE_URI_AUTHORITY = TERMUX_PACKAGE_NAME + ".sharedfiles"; // Default: "com.termux.sharedfiles"`
	`16`	`+`
`14`	`17`	`}`