Fixed(NfcAPI): Check if NfcAdapter is available and not null in NfcActivity.onResume() in addition to onCreate() before calling its methods otherwise would trigger a NullPointerException

agnostic-apollo · agnostic-apollo · commit 4ba140ddecda · 2025-05-23T02:40:58.000+05:00
diff --git a/app/src/main/java/com/termux/api/apis/NfcAPI.java b/app/src/main/java/com/termux/api/apis/NfcAPI.java
@@ -33,7 +33,8 @@ public static void onReceive(final Context context, final Intent intent) {
 
     public static class NfcActivity extends AppCompatActivity {
 
-        private NfcAdapter adapter;
+        private Intent mIntent;
+        private NfcAdapter mAdapter;
         static String socket_input;
         static String socket_output;
         String mode;
@@ -66,6 +67,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
             super.onCreate(savedInstanceState);
             Intent intent = this.getIntent();
             if (intent != null) {
+                mIntent = intent;
                 mode = intent.getStringExtra("mode");
                 if (null == mode)
                     mode = "noData";
@@ -94,14 +96,21 @@ protected void onResume() {
             Logger.logVerbose(LOG_TAG, "onResume");
 
             super.onResume();
-            adapter = NfcAdapter.getDefaultAdapter(this);
+
+            mAdapter = NfcAdapter.getDefaultAdapter(this);
+            if (mAdapter == null || !mAdapter.isEnabled()) {
+                if (mIntent != null)
+                    errorNfc(this, mIntent,"");
+                finish();
+                return;
+            }
             Intent intentNew = new Intent(this, NfcActivity.class).addFlags(Intent.FLAG_RECEIVER_REPLACE_PENDING);
             PendingIntent pendingIntent = PendingIntent.getActivity(this, 0, intentNew, 0);
             IntentFilter[] intentFilter = new IntentFilter[]{
                     new IntentFilter(NfcAdapter.ACTION_NDEF_DISCOVERED),
                     new IntentFilter(NfcAdapter.ACTION_TAG_DISCOVERED),
                     new IntentFilter(NfcAdapter.ACTION_TECH_DISCOVERED)};
-            adapter.enableForegroundDispatch(this, pendingIntent, intentFilter, null);
+            mAdapter.enableForegroundDispatch(this, pendingIntent, intentFilter, null);
         }
 
         @Override
@@ -126,7 +135,7 @@ protected void onNewIntent(Intent intent) {
         protected void onPause() {
             Logger.logDebug(LOG_TAG, "onPause");
 
-            adapter.disableForegroundDispatch(this);
+            mAdapter.disableForegroundDispatch(this);
             super.onPause();
         }
 
