Fixed: Fix crash if input or output socket extras are not set

agnostic-apollo · agnostic-apollo · commit 3b85bc1e4844 · 2022-04-23T00:30:42.000+05:00
`com.termux.api A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 23068 (Thread-4)`
diff --git a/app/src/main/java/com/termux/api/util/ResultReturner.java b/app/src/main/java/com/termux/api/util/ResultReturner.java
@@ -18,6 +18,7 @@
 
 import java.io.ByteArrayOutputStream;
 import java.io.FileDescriptor;
+import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.PrintWriter;
@@ -154,6 +155,8 @@ public static void returnData(Object context, final Intent intent, final ResultW
                 final ParcelFileDescriptor[] pfds = { null };
                 outputSocket = new LocalSocket();
                 String outputSocketAdress = intent.getStringExtra(SOCKET_OUTPUT_EXTRA);
+                if (outputSocketAdress == null || outputSocketAdress.isEmpty())
+                    throw new IOException("Missing '" + SOCKET_OUTPUT_EXTRA + "' extra");
                 Logger.logDebug(LOG_TAG, "Connecting to output socket \"" + outputSocketAdress + "\"");
                 outputSocket.connect(new LocalSocketAddress(outputSocketAdress));
                 writer = new PrintWriter(outputSocket.getOutputStream());
@@ -166,6 +169,8 @@ public static void returnData(Object context, final Intent intent, final ResultW
                     if (resultWriter instanceof WithInput) {
                         try (LocalSocket inputSocket = new LocalSocket()) {
                             String inputSocketAdress = intent.getStringExtra(SOCKET_INPUT_EXTRA);
+                            if (inputSocketAdress == null || inputSocketAdress.isEmpty())
+                                throw new IOException("Missing '" + SOCKET_INPUT_EXTRA + "' extra");
                             inputSocket.connect(new LocalSocketAddress(inputSocketAdress));
                             ((WithInput) resultWriter).setInput(inputSocket.getInputStream());
                             resultWriter.writeResult(writer);
