Fixed: Fix NullPointerException triggered when trying to show keyboard without dialog view in focus by pressing outside of bottom sheets dialog

agnostic-apollo · agnostic-apollo · commit 30a58d7ec968 · 2022-03-17T02:07:45.000+05:00
`termux-dialog sheet -v 'Item One','Item Two'` ``` java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.IBinder android.view.View.getWindowToken()' on a null object reference at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:1668) at android.view.inputmethod.InputMethodManager.showSoftInput(InputMethodManager.java:1592) at com.termux.api.apis.DialogAPI$DialogActivity$BottomSheetInputMethod.showKeyboard(DialogAPI.java:719) at com.termux.api.apis.DialogAPI$DialogActivity$BottomSheetInputMethod$1.cancel(DialogAPI.java:666) at com.google.android.material.bottomsheet.BottomSheetDialog$2.onClick(BottomSheetDialog.java:327) ``` Closes #486
diff --git a/app/src/main/java/com/termux/api/apis/DialogAPI.java b/app/src/main/java/com/termux/api/apis/DialogAPI.java
@@ -50,6 +50,7 @@
 import com.termux.shared.termux.theme.TermuxThemeUtils;
 import com.termux.shared.theme.NightMode;
 import com.termux.shared.theme.ThemeUtils;
+import com.termux.shared.view.KeyboardUtils;
 
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
@@ -712,15 +713,11 @@ public void setupDialog(final Dialog dialog, int style) {
              */
 
             protected void hideKeyboard() {
-                Objects.requireNonNull(getDialog()).getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_HIDDEN);
+                KeyboardUtils.setSoftKeyboardAlwaysHiddenFlags(getActivity());
             }
 
             protected void showKeyboard() {
-                getInputMethodManager().showSoftInput(getView(), InputMethodManager.SHOW_FORCED);
-            }
-
-            protected InputMethodManager getInputMethodManager() {
-                return (InputMethodManager) requireContext().getSystemService(Context.INPUT_METHOD_SERVICE);
+                KeyboardUtils.showSoftKeyboard(getActivity(), getView());
             }
 
             /**
