Fixed: Fix typo in CameraPhotoAPI and StorageGetAPI that was getting basename instead of dirname of file paths for parent dir

agnostic-apollo · agnostic-apollo · commit 24fbea780f1e · 2022-04-23T00:20:31.000+05:00
Created in cc186d0 and 950f9be
diff --git a/app/src/main/java/com/termux/api/apis/CameraPhotoAPI.java b/app/src/main/java/com/termux/api/apis/CameraPhotoAPI.java
@@ -54,9 +54,10 @@ public static void onReceive(TermuxApiReceiver apiReceiver, final Context contex
                 return;
             }
 
-            // Get canonical path of filePath
+            // Get canonical path of photoFilePath
             String photoFilePath = TermuxFileUtils.getCanonicalPath(filePath, null, true);
-            String photoDirPath = FileUtils.getFileBasename(photoFilePath);
+            String photoDirPath = FileUtils.getFileDirname(photoFilePath);
+            Logger.logVerbose(LOG_TAG, "photoFilePath=\"" + photoFilePath + "\", photoDirPath=\"" + photoDirPath + "\"");
 
             // If workingDirectory is not a directory, or is not readable or writable, then just return
             // Creation of missing directory and setting of read, write and execute permissions are only done if workingDirectory is
diff --git a/app/src/main/java/com/termux/api/apis/StorageGetAPI.java b/app/src/main/java/com/termux/api/apis/StorageGetAPI.java
@@ -41,7 +41,8 @@ public static void onReceive(TermuxApiReceiver apiReceiver, final Context contex
 
             // Get canonical path of fileExtra
             String filePath = TermuxFileUtils.getCanonicalPath(fileExtra, null, true);
-            String fileParentDirPath = FileUtils.getFileBasename(filePath);
+            String fileParentDirPath = FileUtils.getFileDirname(filePath);
+            Logger.logVerbose(LOG_TAG, "filePath=\"" + filePath + "\", fileParentDirPath=\"" + fileParentDirPath + "\"");
 
             Error error = FileUtils.checkMissingFilePermissions("file parent directory", fileParentDirPath, "rw-", true);
             if (error != null) {
