Nschris/shipping address selection draft #5074
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: LinkCollapsingListView.swift:107 warning: Parameter 'sender' is unused
LinkPaymentMethodListView-Cell.swift:252 warning: Parameter 'sender' is unused
LinkPaymentMethodListView.swift:178 warning: Parameter 'animated' is unused
LinkShippingAddressListView-Cell.swift:22 warning: Property 'iconViewSize' is unused
LinkShippingAddressListView-Cell.swift:219 warning: Parameter 'sender' is unused
LinkShippingAddressListView-CellContentView.swift:9 warning: Imported module 'StripePayments' is unused
LinkShippingAddressListView-CellContentView.swift:18 warning: Property 'contentSpacing' is unused
LinkShippingAddressListView-CellContentView.swift:19 warning: Property 'iconSize' is unused
LinkShippingAddressListView.swift:23 warning: Parameter 'sourceRect' is unused
LinkShippingAddressListView.swift:181 warning: Parameter 'animated' is unused
PayWithLinkViewController-BaseViewController.swift:10 warning: Imported module 'StripeCore' is unused
PayWithLinkViewController-BaseViewController.swift:15 warning: Class 'AddressBaseViewController' is unused
PayWithLinkViewController-WalletViewController.swift:726 warning: Parameter 'sourceRect' is unused
PayWithLinkViewController-WalletViewController.swift:849 warning: Function 'paymentDetailsPickerDidTapOnAddShippingAddress(sourceRect:)' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog