This is my quick-fix. I use an exec so I can avoid making the rpm-macro file if there isn't one already, meaning the "all" behaviour is preserved rather than restricted to the list in $locales. Perhaps it would be better to introduce the restrictiveness, but for me that would be a potentially breaking behaviour change on many servers.

Don't really know how to do this cleanly in the module itself.

    if $::osfamily == 'RedHat' and versioncmp($::operatingsystemrelease, '8.0') < 0 {
      # A bit of an ugly hack needed on EL7 where there is no separate
      # glibc-langpack-en.  By default, this RPM macro expands to
      # 'all', which means all locales are generated.  On a minimal
      # install, it is set to only include C and en_US, and we want
      # en_IE.utf8 to get 24 hour time from date etc.  On EL8 we use
      # C.utf8, which is part of the minimal install, but this is
      # unsupported on EL7.
      #
      # See also https://github.com/saz/puppet-locales/issues/48

      Exec { path => '/usr/bin:/bin' }
      exec { 'Update rpm macro _install_langs':
        environment => [
          inline_template('VALUE=%_install_langs <%= @locales.map { |l| l.split(/[. ]/)[0] }.uniq.join(":") %>'),
          'FILE=/etc/rpm/macros.langs',
        ],
        command     => "sh -c 'echo \$VALUE > \$FILE'",
        onlyif      => "sh -c '[ -f \$FILE ] && ! grep -q -x \"\$VALUE\" \$FILE'"
      }
      ~> exec { 'reinstall glibc-common':
        command     => 'yum -y reinstall glibc-common',
        refreshonly => true,
      }
    }

Does not add/remove locales on Centos #48

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions