这是indexloc提供的服务,不要输入任何密码
Skip to content

depends on old forks of ginkgo ang gomega #3427

@come-maiz

Description

@come-maiz

In https://github.com/redis/go-redis/pull/2371/files#diff-bad3813d50ebba4650caa871281a86833024b6876453dfe1fc0d7c853b904453 the ginkgo and gomega dependencies were replaced by forks.

These forks haven't been updated in 2 years, while the original projects keep being actively maintained.

I think it's healthier to use the original projects instead of forking them, even if that will require additional dependencies. It is healthier to contribute with these upstreams, and to frequently review their code and to update downstream code to use the new features. Otherwise, these projects are not the correct dependency for what is needed.

Please update these two dependencies to use onsi's versions.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions