From 69bf16b621d317ae682f28b09c6195754cc05c22 Mon Sep 17 00:00:00 2001 From: Self-Hosting-Group <155233284+Self-Hosting-Group@users.noreply.github.com> Date: Tue, 15 Jul 2025 00:00:00 +0000 Subject: [PATCH] UPnP IGD & PCP: Add `Allow Third-Party Mapping` option. Implement #16273 To allow adding port maps for non-requesting IP addresses --- src/usr/local/pkg/miniupnpd.inc | 6 ++++-- src/usr/local/pkg/miniupnpd.xml | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/usr/local/pkg/miniupnpd.inc b/src/usr/local/pkg/miniupnpd.inc index 056f3025e93..1ad6ef70f7c 100644 --- a/src/usr/local/pkg/miniupnpd.inc +++ b/src/usr/local/pkg/miniupnpd.inc @@ -236,8 +236,10 @@ $config_text .= "system_uptime=yes\n"; } - /* set secure_mode */ - $config_text .= "secure_mode=yes\n"; + if ($upnp_config['allow_third_party_mapping'] == 'on') { + $config_text .= "secure_mode=no\n"; + $config_text .= "pcp_allow_thirdparty=yes\n"; + } /* set webgui url */ $webgui_config = config_get_path('system/webgui'); diff --git a/src/usr/local/pkg/miniupnpd.xml b/src/usr/local/pkg/miniupnpd.xml index ecc2cc63910..b88db6ac135 100644 --- a/src/usr/local/pkg/miniupnpd.xml +++ b/src/usr/local/pkg/miniupnpd.xml @@ -35,13 +35,13 @@ Service Settings listtopic - enable_upnp,enable_natpmp,ext_iface,iface_array,download,upload,overridewanip,upnpqueue,logpackets,sysuptime,permdefault + enable_upnp,enable_natpmp,ext_iface,iface_array,download,upload,overridewanip,allow_third_party_mapping,upnpqueue,logpackets,sysuptime,permdefault Enable enable checkbox - enable_upnp,enable_natpmp,ext_iface,iface_array,download,upload,overridewanip,upnpqueue,logpackets,sysuptime,permdefault + enable_upnp,enable_natpmp,ext_iface,iface_array,download,upload,overridewanip,allow_third_party_mapping,upnpqueue,logpackets,sysuptime,permdefault Enable port mapping service Advanced Settings listtopic + + Allow Third-Party Mapping + allow_third_party_mapping + + + + checkbox + Download Speed download