这是indexloc提供的服务,不要输入任何密码
Skip to content

[BUG] First color swatch not updating properly on different scenarios #943

@Jose-Moreno

Description

@Jose-Moreno

--Issue Summary--

First swatch of color palette does not update when changing the color while using the color wheel.

--Actual Results--

On a vector layer, the first color swatch updates on the canvas when you click a different swatch, or if you change the color first and draw a new stroke with the same swatch, it will update only after you draw again, however the thumbnail does not update in either case.

25-SEP-2018: There was an issue that I failed to report at first. When you use another swatch and then switch back to the first swatch in the list, the color value from the previous swatch is assigned to the first swatch.

Note: Considering the new palette workflow that has been implemented through the "replace" command allowing the swatches to be replaced only by user choice, a few scenarios for this issue were removed from description.

--Expected Results--

The first swatch and any other swatch should update properly after being selected and changing the color through the wheel.

Bitmap Layer: First swatch

  • Fix: Swatch color value update (Replace only) (03/06/2019 - The fix is only partial, the replace command only changes the swatch thumbnail but not the RGB value)
  • Fix: Swatch is assigned color value from last selected swatch

Vector Layer: First swatch

  • Fix: Swatch color value update (Replace only)
  • Fix: Swatch is assigned color value from last selected swatch
  • Fix: Swatch color should not update on canvas drawing (Replace only)
  • Fix: Swatch color should not update after using the color wheel (Replace only)

--Video or Image Reference--

Note: The video outlines the original issue for the vector layer before the palette workflow changed. This issue has been reviewed with 0.6.2 and thus the checkboxes above have been updated to consider this new workflow
https://www.youtube.com/watch?v=i3MagndT1P8&feature=youtu.be

--Steps to reproduce--

Please take a look at the video for one of the main tests and it's steps.

--System Information--

  • Pencil2D Version:
    Version: 0.6.1
    commit: 708d418
    date: 2018-04-02_20:38:44
    Development build
    Operating System: Windows 7 SP 1 (6.1)
    CPU Architecture: x86_64

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions