Improved pull request "Files Changed" experience feedback #163932
Replies: 937 comments 342 replies
-
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state
Example of desired state
This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
The tab for |
Beta Was this translation helpful? Give feedback.
-
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
Seems like sometimes syntax highlighting breaks when reviewing large PRs until I reload |
Beta Was this translation helpful? Give feedback.
-
IMO, the new "Submit Review" sliding in from the right makes it a lot slower to provide feedback to a pull request. The old pop down makes it easy and puts it right in front of your face versus being so high up in the new view. Please consider bringing that back, or a variant of it. |
Beta Was this translation helpful? Give feedback.
-
When looking at the PR in "commits since my last review" mode, I receive a |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
edit: nvm, it seems like top level review comments are now required. Doesn't have anything to do with self reviews. |
Beta Was this translation helpful? Give feedback.
-
When submitting a PR Review, if the login session with my organization expires, the new experience reports an obscure "invalid JSON" error. I believe in the prior experience, the PR review would still submit successfully, and then github would prompt you to log-in again/refresh SSO. |
Beta Was this translation helpful? Give feedback.
-
Still no "mark all unviewed" button which makes me sad. |
Beta Was this translation helpful? Give feedback.
-
I like using the copilot chat to ask about changes in a PR, but it scrolls me back to the top of the window after I close out of the chat window |
Beta Was this translation helpful? Give feedback.
-
It's really useful to have an option to filter by 'viewed' or 'not yet viewed' files back. This is present in the current Files Changed experience, but I couldn't find it in the new experience |
Beta Was this translation helpful? Give feedback.
-
The code font gets a little big bigger and it get's a bit more annoying to read because lines don't fit to the code area like before. Other than that I like it! |
Beta Was this translation helpful? Give feedback.
-
I'm liking the general idea of the change but the Submit Review sidebar is not an improvement for experience in it's current state. |
Beta Was this translation helpful? Give feedback.
-
Bug: the "add gif to comment" option (which, as we all know, is critical in every code review) does nothing. It just hangs with a big black square |
Beta Was this translation helpful? Give feedback.
-
the 300 files limit is great for responsiveness.. but make it impossible to actually review (unfortunately) large PRs. a pagination can easily mitigate this issue |
Beta Was this translation helpful? Give feedback.
-
The new side-by-side file view is missing newlines if you copy/paste from it. I have some external tools I use to check for duplicates in submissions - the result is sometimes ambiguous so I haven't added them as workflows but run them manually on my local PC when reviewing. In the previous UI I could just copy and paste file contents from the review screen into a test file to run the tools against, but now the content gets pasted as a single line. |
Beta Was this translation helpful? Give feedback.
-
Hi. Re accessibility: From the initial pr screen, there used to be a button next to where you select reviewers called "review now", which would (as the title say) start a review. This button is now gone, making it one extra click to start a review, and as someone that's used GH for a long time, I personally find this change strange and unintuitive, especially considering how it mentions reviews throughout the rest of the page, yet there doesn't seem to be a way to start one... |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions