diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 908e1ca5..b1cf3744 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
platform: [ ubuntu-latest ]
- java-version: [ 8, 11, 17, 21, 24 ]
+ java-version: [21, 24 ]
runs-on: ${{ matrix.platform }}
env:
diff --git a/omod/pom.xml b/omod/pom.xml
index 12cd729b..344a1084 100755
--- a/omod/pom.xml
+++ b/omod/pom.xml
@@ -51,6 +51,12 @@
org.openmrs.api
openmrs-api
jar
+
+
+ org.codehaus.groovy
+ groovy-all
+
+
@@ -111,25 +117,14 @@
org.openmrs.contrib
dwr
- 2.0.8-mod-SNAPSHOT
+ 3.0.0-SNAPSHOT
-
- javax.servlet
- javax.servlet-api
- 3.0.1
- provided
-
-
jfree
jfreechart
-
- javax.servlet
- jsp-api
-
org.mockito
@@ -137,7 +132,12 @@
test
-
+
+ org.apache.commons
+ commons-fileupload2-jakarta
+ 2.0.0-M1
+ provided
+
diff --git a/omod/src/main/java/org/openmrs/hl7/web/HL7InQueueProcessorServlet.java b/omod/src/main/java/org/openmrs/hl7/web/HL7InQueueProcessorServlet.java
index c3c8fb59..4160ca68 100644
--- a/omod/src/main/java/org/openmrs/hl7/web/HL7InQueueProcessorServlet.java
+++ b/omod/src/main/java/org/openmrs/hl7/web/HL7InQueueProcessorServlet.java
@@ -11,12 +11,12 @@
import java.io.IOException;
-import javax.servlet.ServletException;
-import javax.servlet.ServletOutputStream;
-import javax.servlet.http.HttpServlet;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletOutputStream;
+import jakarta.servlet.http.HttpServlet;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.openmrs.api.context.Context;
import org.openmrs.hl7.HL7InQueueProcessor;
diff --git a/omod/src/main/java/org/openmrs/module/web/controller/ModuleListController.java b/omod/src/main/java/org/openmrs/module/web/controller/ModuleListController.java
index db9d8387..f522f074 100644
--- a/omod/src/main/java/org/openmrs/module/web/controller/ModuleListController.java
+++ b/omod/src/main/java/org/openmrs/module/web/controller/ModuleListController.java
@@ -23,10 +23,10 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/module/web/controller/ModuleManagementController.java b/omod/src/main/java/org/openmrs/module/web/controller/ModuleManagementController.java
index c45649fb..afefca88 100644
--- a/omod/src/main/java/org/openmrs/module/web/controller/ModuleManagementController.java
+++ b/omod/src/main/java/org/openmrs/module/web/controller/ModuleManagementController.java
@@ -12,8 +12,8 @@
import java.io.IOException;
import java.util.List;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/module/web/controller/ModulePropertiesFormController.java b/omod/src/main/java/org/openmrs/module/web/controller/ModulePropertiesFormController.java
index 79303024..76671956 100644
--- a/omod/src/main/java/org/openmrs/module/web/controller/ModulePropertiesFormController.java
+++ b/omod/src/main/java/org/openmrs/module/web/controller/ModulePropertiesFormController.java
@@ -12,10 +12,10 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/module/web/filter/AdminPageFilter.java b/omod/src/main/java/org/openmrs/module/web/filter/AdminPageFilter.java
index 8beec6ae..35dced76 100644
--- a/omod/src/main/java/org/openmrs/module/web/filter/AdminPageFilter.java
+++ b/omod/src/main/java/org/openmrs/module/web/filter/AdminPageFilter.java
@@ -11,12 +11,12 @@
import java.io.IOException;
-import javax.servlet.Filter;
-import javax.servlet.FilterChain;
-import javax.servlet.FilterConfig;
-import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.ServletResponse;
+import jakarta.servlet.Filter;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.FilterConfig;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
public class AdminPageFilter implements Filter {
diff --git a/omod/src/main/java/org/openmrs/module/web/filter/ForcePasswordChangeFilter.java b/omod/src/main/java/org/openmrs/module/web/filter/ForcePasswordChangeFilter.java
index 21d1d828..241315f3 100644
--- a/omod/src/main/java/org/openmrs/module/web/filter/ForcePasswordChangeFilter.java
+++ b/omod/src/main/java/org/openmrs/module/web/filter/ForcePasswordChangeFilter.java
@@ -11,14 +11,14 @@
import java.io.IOException;
-import javax.servlet.Filter;
-import javax.servlet.FilterChain;
-import javax.servlet.FilterConfig;
-import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.ServletResponse;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.Filter;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.FilterConfig;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.openmrs.api.context.Context;
import org.openmrs.web.user.UserProperties;
diff --git a/omod/src/main/java/org/openmrs/module/web/filter/RedirectAfterLoginFilter.java b/omod/src/main/java/org/openmrs/module/web/filter/RedirectAfterLoginFilter.java
index 7bcfc27b..9d8298a5 100644
--- a/omod/src/main/java/org/openmrs/module/web/filter/RedirectAfterLoginFilter.java
+++ b/omod/src/main/java/org/openmrs/module/web/filter/RedirectAfterLoginFilter.java
@@ -11,14 +11,14 @@
import static org.openmrs.web.WebConstants.OPENMRS_LOGIN_REDIRECT_HTTPSESSION_ATTR;
-import javax.servlet.Filter;
-import javax.servlet.FilterChain;
-import javax.servlet.FilterConfig;
-import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.ServletResponse;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.Filter;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.FilterConfig;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpSession;
import java.io.IOException;
import org.apache.commons.lang.StringUtils;
diff --git a/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPointTag.java b/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPointTag.java
index 72e178a7..f5eabaaf 100644
--- a/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPointTag.java
+++ b/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPointTag.java
@@ -16,11 +16,11 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.jsp.JspException;
-import javax.servlet.jsp.JspTagException;
-import javax.servlet.jsp.tagext.BodyContent;
-import javax.servlet.jsp.tagext.BodyTag;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.jsp.JspException;
+import jakarta.servlet.jsp.JspTagException;
+import jakarta.servlet.jsp.tagext.BodyContent;
+import jakarta.servlet.jsp.tagext.BodyTag;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -153,7 +153,7 @@ public int doStartTag() {
}
/**
- * @see javax.servlet.jsp.tagext.BodyTag#doInitBody()
+ * @see jakarta.servlet.jsp.tagext.BodyTag#doInitBody()
*/
public void doInitBody() throws JspException {
getBodyContent().clearBody();
@@ -164,7 +164,7 @@ public void doInitBody() throws JspException {
}
/**
- * @see javax.servlet.jsp.tagext.IterationTag#doAfterBody()
+ * @see jakarta.servlet.jsp.tagext.IterationTag#doAfterBody()
*/
public int doAfterBody() throws JspException {
if (extensions.hasNext()) {
@@ -205,7 +205,7 @@ private void iterate() {
}
/**
- * @see javax.servlet.jsp.tagext.Tag#doEndTag()
+ * @see jakarta.servlet.jsp.tagext.Tag#doEndTag()
*/
public int doEndTag() throws JspException {
try {
diff --git a/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPopupMenuTag.java b/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPopupMenuTag.java
index fee4b2c3..3f8cda40 100644
--- a/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPopupMenuTag.java
+++ b/omod/src/main/java/org/openmrs/module/web/taglib/ExtensionPopupMenuTag.java
@@ -15,9 +15,9 @@
import java.util.Random;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.jsp.JspException;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.jsp.JspException;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/notification/web/ForEachAlertTag.java b/omod/src/main/java/org/openmrs/notification/web/ForEachAlertTag.java
index 0b7b5ace..4697f42d 100644
--- a/omod/src/main/java/org/openmrs/notification/web/ForEachAlertTag.java
+++ b/omod/src/main/java/org/openmrs/notification/web/ForEachAlertTag.java
@@ -12,8 +12,8 @@
import java.util.Iterator;
import java.util.List;
-import javax.servlet.jsp.JspTagException;
-import javax.servlet.jsp.jstl.core.LoopTagSupport;
+import jakarta.servlet.jsp.JspTagException;
+import jakarta.servlet.jsp.jstl.core.LoopTagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/notification/web/controller/AlertFormController.java b/omod/src/main/java/org/openmrs/notification/web/controller/AlertFormController.java
index d89fdc69..7b6309f5 100644
--- a/omod/src/main/java/org/openmrs/notification/web/controller/AlertFormController.java
+++ b/omod/src/main/java/org/openmrs/notification/web/controller/AlertFormController.java
@@ -16,9 +16,9 @@
import java.util.Map;
import java.util.Vector;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/notification/web/controller/AlertListController.java b/omod/src/main/java/org/openmrs/notification/web/controller/AlertListController.java
index ea9e9936..688a8142 100644
--- a/omod/src/main/java/org/openmrs/notification/web/controller/AlertListController.java
+++ b/omod/src/main/java/org/openmrs/notification/web/controller/AlertListController.java
@@ -16,9 +16,9 @@
import java.util.Map;
import java.util.Vector;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/notification/web/dwr/DWRMessageService.java b/omod/src/main/java/org/openmrs/notification/web/dwr/DWRMessageService.java
index 3e8a8328..3a67393c 100644
--- a/omod/src/main/java/org/openmrs/notification/web/dwr/DWRMessageService.java
+++ b/omod/src/main/java/org/openmrs/notification/web/dwr/DWRMessageService.java
@@ -11,7 +11,7 @@
import java.util.Vector;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
diff --git a/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java b/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java
index 065bea00..104e8704 100644
--- a/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java
+++ b/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java
@@ -15,10 +15,10 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -29,6 +29,7 @@
import org.openmrs.web.WebUtil;
import org.springframework.beans.propertyeditors.CustomDateEditor;
import org.springframework.beans.propertyeditors.CustomNumberEditor;
+import org.springframework.context.support.MessageSourceAccessor;
import org.springframework.validation.BindException;
import org.springframework.validation.Errors;
import org.springframework.web.bind.ServletRequestDataBinder;
@@ -147,7 +148,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
view = getSuccessView();
Object[] args = new Object[] { WebUtil.escapeHTML(task.getName()) };
- String success = getMessageSourceAccessor().getMessage("Scheduler.taskForm.saved", args);
+ String success = new MessageSourceAccessor(Context.getMessageSourceService()).getMessage("Scheduler.taskForm.saved", args);
httpSession.setAttribute(WebConstants.OPENMRS_MSG_ATTR, success);
return new ModelAndView(new RedirectView(view));
diff --git a/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerListController.java b/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerListController.java
index 6a4385a0..fcac693b 100644
--- a/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerListController.java
+++ b/omod/src/main/java/org/openmrs/scheduler/web/controller/SchedulerListController.java
@@ -13,10 +13,10 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/CopyLegacyUiContentToWebInf.java b/omod/src/main/java/org/openmrs/web/CopyLegacyUiContentToWebInf.java
index 2ab5be0b..af6e93f2 100644
--- a/omod/src/main/java/org/openmrs/web/CopyLegacyUiContentToWebInf.java
+++ b/omod/src/main/java/org/openmrs/web/CopyLegacyUiContentToWebInf.java
@@ -14,7 +14,7 @@
import java.util.ArrayList;
import java.util.List;
-import javax.servlet.ServletContext;
+import jakarta.servlet.ServletContext;
import org.apache.commons.io.FileUtils;
import org.apache.commons.logging.Log;
diff --git a/omod/src/main/java/org/openmrs/web/LegacyUIJavaConfig.java b/omod/src/main/java/org/openmrs/web/LegacyUIJavaConfig.java
new file mode 100644
index 00000000..f67e3de1
--- /dev/null
+++ b/omod/src/main/java/org/openmrs/web/LegacyUIJavaConfig.java
@@ -0,0 +1,41 @@
+/**
+ * This Source Code Form is subject to the terms of the Mozilla Public License,
+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+ * obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under
+ * the terms of the Healthcare Disclaimer located at http://openmrs.org/license.
+ *
+ * Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS
+ * graphic logo is a trademark of OpenMRS Inc.
+ */
+package org.openmrs.web;
+
+import org.springframework.context.annotation.Configuration;
+import org.springframework.web.servlet.config.annotation.InterceptorRegistry;
+import org.springframework.web.servlet.config.annotation.ViewControllerRegistry;
+import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;
+
+@Configuration
+public class LegacyUIJavaConfig implements WebMvcConfigurer {
+
+ @Override
+ public void addInterceptors(InterceptorRegistry registry) {
+ var localeChangeInterceptor = new org.springframework.web.servlet.i18n.LocaleChangeInterceptor();
+ localeChangeInterceptor.setParamName("lang");
+ registry.addInterceptor(localeChangeInterceptor);
+
+ var themeChangeInterceptor = new org.springframework.web.servlet.theme.ThemeChangeInterceptor();
+ themeChangeInterceptor.setParamName("theme");
+ registry.addInterceptor(themeChangeInterceptor);
+ }
+
+ @Override
+ public void addViewControllers(ViewControllerRegistry registry) {
+ registry.addViewController("findPatient.htm").setViewName("module/legacyui/findPatient");
+ registry.addViewController("admin/index.htm").setViewName("module/legacyui/admin/index");
+ registry.addViewController("dictionary/index.htm").setViewName("module/legacyui/dictionary/index");
+ registry.addViewController("patients/index.htm").setViewName("module/legacyui/admin/patients/index");
+ registry.addViewController("encounters/index.htm").setViewName("module/legacyui/admin/encounters/index");
+ registry.addViewController("observations/index.htm").setViewName("module/legacyui/admin/observations/index");
+ registry.addViewController("help.htm").setViewName("module/legacyui/help");
+ }
+}
diff --git a/omod/src/main/java/org/openmrs/web/OpenmrsCookieLocaleResolver.java b/omod/src/main/java/org/openmrs/web/OpenmrsCookieLocaleResolver.java
index d50862b3..b2828da6 100644
--- a/omod/src/main/java/org/openmrs/web/OpenmrsCookieLocaleResolver.java
+++ b/omod/src/main/java/org/openmrs/web/OpenmrsCookieLocaleResolver.java
@@ -11,9 +11,9 @@
import java.util.Locale;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.openmrs.api.context.Context;
import org.springframework.web.servlet.i18n.CookieLocaleResolver;
diff --git a/omod/src/main/java/org/openmrs/web/SessionListener.java b/omod/src/main/java/org/openmrs/web/SessionListener.java
index a0368abf..9170080b 100644
--- a/omod/src/main/java/org/openmrs/web/SessionListener.java
+++ b/omod/src/main/java/org/openmrs/web/SessionListener.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web;
-import javax.servlet.http.HttpSessionEvent;
-import javax.servlet.http.HttpSessionListener;
+import jakarta.servlet.http.HttpSessionEvent;
+import jakarta.servlet.http.HttpSessionListener;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java
index 595f9335..5ac816d2 100644
--- a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java
+++ b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java
@@ -9,10 +9,11 @@
*/
package org.openmrs.web;
-import javax.servlet.DispatcherType;
-import javax.servlet.FilterRegistration.Dynamic;
-import javax.servlet.ServletContext;
-import javax.servlet.ServletRegistration;
+import jakarta.annotation.Nonnull;
+import jakarta.servlet.DispatcherType;
+import jakarta.servlet.FilterRegistration.Dynamic;
+import jakarta.servlet.ServletContext;
+import jakarta.servlet.ServletRegistration;
import java.util.EnumSet;
import org.openmrs.contrib.dwr.servlet.EfficientShutdownServletContextAttributeListener;
@@ -26,8 +27,7 @@
public class WebComponentRegistrar implements ServletContextAware {
@Override
- public void setServletContext(ServletContext servletContext) {
-
+ public void setServletContext(@Nonnull ServletContext servletContext) {
try {
String[] mappings = { "*.htm", "*.form", "*.list", "*.json", "*.field", "*.portlet", "*.page", "*.action" };
@@ -66,9 +66,11 @@ public void setServletContext(ServletContext servletContext) {
}
private void addMappings(ServletRegistration reg, String... mappings) {
- for (String mapping : mappings) {
- reg.addMapping(mapping);
- }
+ if (reg != null) {
+ for (String mapping : mappings) {
+ reg.addMapping(mapping);
+ }
+ }
}
}
diff --git a/omod/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java b/omod/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java
index ea7311b3..ecbf4c97 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java
@@ -16,7 +16,7 @@
import java.util.regex.Matcher;
import java.util.regex.Pattern;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.lang.StringUtils;
import org.openmrs.api.context.Context;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/BooleanFieldGenDatatypeHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/BooleanFieldGenDatatypeHandler.java
index 3918c798..f3c6eaf8 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/BooleanFieldGenDatatypeHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/BooleanFieldGenDatatypeHandler.java
@@ -12,7 +12,7 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.lang.StringUtils;
import org.openmrs.api.context.Context;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/DateFieldGenDatatypeHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/DateFieldGenDatatypeHandler.java
index 9fdd44b8..2238b088 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/DateFieldGenDatatypeHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/DateFieldGenDatatypeHandler.java
@@ -13,7 +13,7 @@
import java.util.Date;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.lang.StringUtils;
import org.openmrs.api.context.Context;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/FieldGenDatatypeHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/FieldGenDatatypeHandler.java
index cc0fa446..a8e7d9ba 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/FieldGenDatatypeHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/FieldGenDatatypeHandler.java
@@ -11,7 +11,7 @@
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.customdatatype.CustomDatatype;
import org.openmrs.customdatatype.CustomDatatypeHandler;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextFileUploadHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextFileUploadHandler.java
index 668f98fc..67612660 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextFileUploadHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextFileUploadHandler.java
@@ -12,7 +12,7 @@
import java.io.IOException;
import java.io.OutputStream;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.customdatatype.CustomDatatype;
import org.openmrs.customdatatype.DownloadableDatatypeHandler;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextTextareaHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextTextareaHandler.java
index 63696b65..e0c3d047 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextTextareaHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/LongFreeTextTextareaHandler.java
@@ -13,7 +13,7 @@
import java.io.OutputStream;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.customdatatype.CustomDatatype;
import org.openmrs.customdatatype.CustomDatatypeUtil;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandler.java
index 104b9f03..cbee80f2 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandler.java
@@ -11,7 +11,7 @@
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/SerializingFieldGenDatatypeHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/SerializingFieldGenDatatypeHandler.java
index a14cfdcf..6535e032 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/SerializingFieldGenDatatypeHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/SerializingFieldGenDatatypeHandler.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.attribute.handler;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import java.beans.PropertyEditor;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/SpecifiedTextOptionsDropdownHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/SpecifiedTextOptionsDropdownHandler.java
index 29ead5cb..395b0d58 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/SpecifiedTextOptionsDropdownHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/SpecifiedTextOptionsDropdownHandler.java
@@ -14,7 +14,7 @@
import org.openmrs.customdatatype.datatype.SpecifiedTextOptionsDatatype;
import org.springframework.stereotype.Component;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import java.util.HashMap;
import java.util.Map;
diff --git a/omod/src/main/java/org/openmrs/web/attribute/handler/WebDatatypeHandler.java b/omod/src/main/java/org/openmrs/web/attribute/handler/WebDatatypeHandler.java
index e3b3c6e6..01034e9e 100644
--- a/omod/src/main/java/org/openmrs/web/attribute/handler/WebDatatypeHandler.java
+++ b/omod/src/main/java/org/openmrs/web/attribute/handler/WebDatatypeHandler.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.attribute.handler;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.customdatatype.CustomDatatype;
import org.openmrs.customdatatype.CustomDatatypeHandler;
diff --git a/omod/src/main/java/org/openmrs/web/controller/ConceptFormController.java b/omod/src/main/java/org/openmrs/web/controller/ConceptFormController.java
index 93abe55e..0dbcf7e8 100644
--- a/omod/src/main/java/org/openmrs/web/controller/ConceptFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/ConceptFormController.java
@@ -26,10 +26,10 @@
import java.util.Objects;
import java.util.Set;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.collections.FactoryUtils;
import org.apache.commons.collections.ListUtils;
@@ -38,6 +38,7 @@
import org.openmrs.Concept;
import org.openmrs.ConceptAnswer;
import org.openmrs.ConceptAttribute;
+import org.openmrs.ConceptAttributeType;
import org.openmrs.ConceptComplex;
import org.openmrs.ConceptDescription;
import org.openmrs.ConceptMap;
@@ -81,6 +82,7 @@
import org.springframework.beans.propertyeditors.CustomNumberEditor;
import org.springframework.context.support.MessageSourceAccessor;
import org.springframework.dao.DataIntegrityViolationException;
+import org.springframework.transaction.annotation.Transactional;
import org.springframework.util.StringUtils;
import org.springframework.validation.BindException;
import org.springframework.validation.Errors;
@@ -139,7 +141,7 @@ protected void initBinder(HttpServletRequest request, ServletRequestDataBinder b
protected ModelAndView processFormSubmission(HttpServletRequest request, HttpServletResponse response, Object object,
BindException errors) throws Exception {
- if (getMessageSourceAccessor().getMessage("Concept.cancel").equals(request.getParameter("action"))) {
+ if (Context.getMessageSourceService().getMessage("Concept.cancel").equals(request.getParameter("action"))) {
return new ModelAndView(new RedirectView("index.htm"));
}
@@ -192,9 +194,8 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
ConceptService cs = Context.getConceptService();
if (Context.isAuthenticated()) {
-
ConceptFormBackingObject conceptBackingObject = (ConceptFormBackingObject) obj;
- MessageSourceAccessor msa = getMessageSourceAccessor();
+ MessageSourceAccessor msa = new MessageSourceAccessor(Context.getMessageSourceService());
String action = request.getParameter("action");
if (action.equals(msa.getMessage("general.retire"))) {
@@ -261,6 +262,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
return new ModelAndView(new RedirectView(getSuccessView() + "?conceptId=" + concept.getConceptId()));
} else {
Concept concept = conceptBackingObject.getConceptFromFormData();
+ List conceptAttributeTypes = cs.getAllConceptAttributeTypes();
//if the user is editing a concept, initialise the associated creator property
//this is aimed at avoiding a lazy initialisation exception when rendering
//the jsp after validation has failed
@@ -270,7 +272,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
try {
WebAttributeUtil.handleSubmittedAttributesForType(conceptBackingObject.getConcept(), errors,
- ConceptAttribute.class, request, cs.getAllConceptAttributeTypes());
+ ConceptAttribute.class, request, conceptAttributeTypes);
errors.pushNestedPath("concept");
ValidateUtil.validate(concept, errors);
@@ -397,10 +399,13 @@ protected Map referenceData(HttpServletRequest request) throws E
if (Context.hasPrivilege(PrivilegeConstants.GET_OBS)) {
try {
Concept concept = cs.getConcept(Integer.valueOf(conceptId));
- dataTypeReadOnly = cs.hasAnyObservation(concept);
- if (concept != null && concept.getDatatype().isBoolean()) {
- map.put("isBoolean", true);
- }
+ if (concept != null) {
+ if (concept.getDatatype().isBoolean()) {
+ map.put("isBoolean", true);
+ }
+
+ dataTypeReadOnly = cs.hasAnyObservation(concept);
+ }
}
catch (NumberFormatException ex) {
// nothing to do
diff --git a/omod/src/main/java/org/openmrs/web/controller/ConceptStatsFormController.java b/omod/src/main/java/org/openmrs/web/controller/ConceptStatsFormController.java
index 35c6e8b6..d77132f0 100644
--- a/omod/src/main/java/org/openmrs/web/controller/ConceptStatsFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/ConceptStatsFormController.java
@@ -18,9 +18,9 @@
import java.util.Map;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/FieldGenController.java b/omod/src/main/java/org/openmrs/web/controller/FieldGenController.java
index 0a0a4709..ff0243e6 100644
--- a/omod/src/main/java/org/openmrs/web/controller/FieldGenController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/FieldGenController.java
@@ -13,9 +13,9 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -32,9 +32,9 @@ public ModelAndView handleRequest(HttpServletRequest request, HttpServletRespons
IOException {
// find the field that was identified in the openmrs:fieldGen taglib
- Object uri = request.getAttribute("javax.servlet.include.servlet_path.fieldGen");
+ Object uri = request.getAttribute("jakarta.servlet.include.servlet_path.fieldGen");
if (uri == null) {
- uri = request.getAttribute("javax.servlet.include.servlet_path");
+ uri = request.getAttribute("jakarta.servlet.include.servlet_path");
}
String fieldGenPath = "";
Map model = new HashMap();
diff --git a/omod/src/main/java/org/openmrs/web/controller/ForgotPasswordFormController.java b/omod/src/main/java/org/openmrs/web/controller/ForgotPasswordFormController.java
index 03c77007..3fe6471d 100644
--- a/omod/src/main/java/org/openmrs/web/controller/ForgotPasswordFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/ForgotPasswordFormController.java
@@ -15,10 +15,10 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.lang.RandomStringUtils;
import org.apache.commons.lang.StringUtils;
diff --git a/omod/src/main/java/org/openmrs/web/controller/GlobalPropertyPortletController.java b/omod/src/main/java/org/openmrs/web/controller/GlobalPropertyPortletController.java
index d3ef8215..0607458c 100644
--- a/omod/src/main/java/org/openmrs/web/controller/GlobalPropertyPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/GlobalPropertyPortletController.java
@@ -13,7 +13,7 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.GlobalProperty;
import org.openmrs.api.context.Context;
diff --git a/omod/src/main/java/org/openmrs/web/controller/LegacyCatchAllController.java b/omod/src/main/java/org/openmrs/web/controller/LegacyCatchAllController.java
new file mode 100644
index 00000000..b07ca0aa
--- /dev/null
+++ b/omod/src/main/java/org/openmrs/web/controller/LegacyCatchAllController.java
@@ -0,0 +1,145 @@
+package org.openmrs.web.controller;
+
+
+
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.servlet.ModelAndView;
+import org.springframework.web.servlet.mvc.Controller;
+
+@org.springframework.stereotype.Controller
+@RequestMapping("/**") // handled via PathPattern with /** mapping in XML
+public class LegacyCatchAllController implements Controller {
+
+ @Autowired
+ private Controller springController;
+ @Autowired
+ private Controller fieldGenController;
+ @Autowired
+ private Controller portletController;
+
+ @Autowired
+ private Controller globalPropertyPortletController;
+
+ @Autowired
+ private Controller addressLayoutPortletController;
+
+ @Autowired
+ private Controller nameLayoutPortletController;
+
+ @Autowired
+ private Controller patientProgramsPortletController;
+
+ @Autowired
+ private Controller personRelationshipsPortletController;
+
+ @Autowired
+ private Controller patientEncountersPortletController;
+
+ @Autowired
+ private Controller patientVisitsPortletController;
+
+ @Autowired
+ private Controller personFormEntryPortletController;
+
+ public ModelAndView handleRequest(HttpServletRequest request, HttpServletResponse response) throws Exception {
+ String path = request.getRequestURI();
+ if (path == null) {
+ response.sendError(HttpServletResponse.SC_NOT_FOUND);
+ return null;
+ }
+
+ // Normalize (strip context path if present)
+ String ctx = request.getContextPath();
+ if (ctx != null && !ctx.isEmpty() && path.startsWith(ctx)) {
+ path = path.substring(ctx.length());
+ }
+
+ if (path.endsWith("/globalProperties.portlet")) {
+ return globalPropertyPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/addressLayout.portlet")) {
+ return addressLayoutPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/nameLayout.portlet")) {
+ return nameLayoutPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/patientPrograms.portlet")) {
+ return patientProgramsPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/personRelationships.portlet")) {
+ return personRelationshipsPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/patientEncounters.portlet")) {
+ return patientEncountersPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/patientVisits.portlet")) {
+ return patientVisitsPortletController.handleRequest(request, response);
+ }
+ if (path.endsWith("/personFormEntry.portlet")) {
+ return personFormEntryPortletController.handleRequest(request, response);
+ }
+
+ if (path.endsWith(".field")) {
+ return fieldGenController.handleRequest(request, response);
+ }
+ if (path.endsWith(".htm")) {
+ return springController.handleRequest(request, response);
+ }
+ if (path.endsWith(".portlet")) {
+ return portletController.handleRequest(request, response);
+ }
+
+ // Default fallback – nothing matched
+ response.sendError(HttpServletResponse.SC_NOT_FOUND, "No handler found for " + path);
+ return null;
+ }
+
+
+ public void setSpringController(Controller springController) {
+ this.springController = springController;
+ }
+
+ public void setFieldGenController(Controller fieldGenController) {
+ this.fieldGenController = fieldGenController;
+ }
+
+ public void setPortletController(Controller portletController) {
+ this.portletController = portletController;
+ }
+
+ public void setGlobalPropertyPortletController(Controller globalPropertyPortletController) {
+ this.globalPropertyPortletController = globalPropertyPortletController;
+ }
+
+ public void setAddressLayoutPortletController(Controller addressLayoutPortletController) {
+ this.addressLayoutPortletController = addressLayoutPortletController;
+ }
+
+ public void setNameLayoutPortletController(Controller nameLayoutPortletController) {
+ this.nameLayoutPortletController = nameLayoutPortletController;
+ }
+
+ public void setPatientProgramsPortletController(Controller patientProgramsPortletController) {
+ this.patientProgramsPortletController = patientProgramsPortletController;
+ }
+
+ public void setPersonRelationshipsPortletController(Controller personRelationshipsPortletController) {
+ this.personRelationshipsPortletController = personRelationshipsPortletController;
+ }
+
+ public void setPatientEncountersPortletController(Controller patientEncountersPortletController) {
+ this.patientEncountersPortletController = patientEncountersPortletController;
+ }
+
+ public void setPatientVisitsPortletController(Controller patientVisitsPortletController) {
+ this.patientVisitsPortletController = patientVisitsPortletController;
+ }
+
+ public void setPersonFormEntryPortletController(Controller personFormEntryPortletController) {
+ this.personFormEntryPortletController = personFormEntryPortletController;
+ }
+}
+
diff --git a/omod/src/main/java/org/openmrs/web/controller/OptionsFormController.java b/omod/src/main/java/org/openmrs/web/controller/OptionsFormController.java
index 4cd82527..48d6b5f3 100644
--- a/omod/src/main/java/org/openmrs/web/controller/OptionsFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/OptionsFormController.java
@@ -16,10 +16,10 @@
import java.util.Locale;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
@@ -378,7 +378,7 @@ protected Map referenceData(HttpServletRequest request) throws E
//ignore
}
- hints.add(mss.getMessage("options.login.password.minCharacterCount", new Object[] { minChar }, null));
+ hints.add(mss.getMessage("options.login.password.minCharacterCount", new Object[] { minChar }, Context.getLocale()));
addHint(hints, as.getGlobalProperty(OpenmrsConstants.GP_PASSWORD_CANNOT_MATCH_USERNAME_OR_SYSTEMID),
mss.getMessage("options.login.password.cannotMatchUsername"));
addHint(hints, as.getGlobalProperty(OpenmrsConstants.GP_PASSWORD_REQUIRES_UPPER_AND_LOWER_CASE),
diff --git a/omod/src/main/java/org/openmrs/web/controller/PatientEncountersPortletController.java b/omod/src/main/java/org/openmrs/web/controller/PatientEncountersPortletController.java
index 9eb986a2..7abec7c6 100644
--- a/omod/src/main/java/org/openmrs/web/controller/PatientEncountersPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/PatientEncountersPortletController.java
@@ -11,7 +11,7 @@
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.api.context.Context;
diff --git a/omod/src/main/java/org/openmrs/web/controller/PatientProgramsPortletController.java b/omod/src/main/java/org/openmrs/web/controller/PatientProgramsPortletController.java
index ac4e6ab4..2596a27c 100644
--- a/omod/src/main/java/org/openmrs/web/controller/PatientProgramsPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/PatientProgramsPortletController.java
@@ -12,7 +12,7 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.Location;
import org.openmrs.Program;
diff --git a/omod/src/main/java/org/openmrs/web/controller/PatientVisitsPortletController.java b/omod/src/main/java/org/openmrs/web/controller/PatientVisitsPortletController.java
index b12ed269..1ebcc25a 100644
--- a/omod/src/main/java/org/openmrs/web/controller/PatientVisitsPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/PatientVisitsPortletController.java
@@ -13,7 +13,7 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/PersonFormEntryPortletController.java b/omod/src/main/java/org/openmrs/web/controller/PersonFormEntryPortletController.java
index 3937bf76..1ce760b4 100644
--- a/omod/src/main/java/org/openmrs/web/controller/PersonFormEntryPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/PersonFormEntryPortletController.java
@@ -15,7 +15,7 @@
import java.util.Map;
import java.util.TreeMap;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.Form;
import org.openmrs.Person;
diff --git a/omod/src/main/java/org/openmrs/web/controller/PersonRelationshipsPortletController.java b/omod/src/main/java/org/openmrs/web/controller/PersonRelationshipsPortletController.java
index 9b193122..49161568 100644
--- a/omod/src/main/java/org/openmrs/web/controller/PersonRelationshipsPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/PersonRelationshipsPortletController.java
@@ -12,7 +12,7 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.openmrs.RelationshipType;
import org.openmrs.api.context.Context;
diff --git a/omod/src/main/java/org/openmrs/web/controller/PortletController.java b/omod/src/main/java/org/openmrs/web/controller/PortletController.java
index 959e523c..eb2b9407 100644
--- a/omod/src/main/java/org/openmrs/web/controller/PortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/PortletController.java
@@ -18,10 +18,10 @@
import java.util.Map;
import java.util.UUID;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -103,7 +103,7 @@ public ModelAndView handleRequest(HttpServletRequest request, HttpServletRespons
ConceptService cs = Context.getConceptService();
// find the portlet that was identified in the openmrs:portlet taglib
- Object uri = request.getAttribute("javax.servlet.include.servlet_path");
+ Object uri = request.getAttribute("jakarta.servlet.include.servlet_path");
String portletPath = "";
Map model = null;
{
diff --git a/omod/src/main/java/org/openmrs/web/controller/RedirectController.java b/omod/src/main/java/org/openmrs/web/controller/RedirectController.java
index e57562b5..770e771e 100644
--- a/omod/src/main/java/org/openmrs/web/controller/RedirectController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/RedirectController.java
@@ -11,9 +11,9 @@
import java.io.IOException;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.Controller;
diff --git a/omod/src/main/java/org/openmrs/web/controller/bean/DatatableRequest.java b/omod/src/main/java/org/openmrs/web/controller/bean/DatatableRequest.java
index e4589bd1..32040984 100644
--- a/omod/src/main/java/org/openmrs/web/controller/bean/DatatableRequest.java
+++ b/omod/src/main/java/org/openmrs/web/controller/bean/DatatableRequest.java
@@ -14,7 +14,7 @@
import java.util.Map;
import java.util.Map.Entry;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
/**
* Class dedicated for DataTables. It is a request that can be extracted from
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassFormController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassFormController.java
index 74bcf27b..cd1ad369 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassFormController.java
@@ -9,10 +9,10 @@
*/
package org.openmrs.web.controller.concept;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassListController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassListController.java
index cdd66cd7..bc76664f 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptClassListController.java
@@ -12,10 +12,10 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDatatypeListController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDatatypeListController.java
index 6f492195..ece3fa7f 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDatatypeListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDatatypeListController.java
@@ -12,10 +12,10 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugFormController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugFormController.java
index f10f9009..9dc0a6dc 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugFormController.java
@@ -12,10 +12,10 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugListController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugListController.java
index 952c7c64..072c5901 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptDrugListController.java
@@ -12,8 +12,8 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalFormController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalFormController.java
index 5385c5c4..5493b96e 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalFormController.java
@@ -19,10 +19,10 @@
import java.util.Set;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -74,7 +74,7 @@ protected ModelAndView processFormSubmission(HttpServletRequest request, HttpSer
}
cp.setMappedConcept(c);
- MessageSourceAccessor msa = getMessageSourceAccessor();
+ MessageSourceAccessor msa = new MessageSourceAccessor(Context.getMessageSourceService());
if (action.equals(msa.getMessage("general.cancel"))) {
httpSession.setAttribute(WebConstants.OPENMRS_MSG_ATTR, "general.canceled");
return new ModelAndView(new RedirectView(getSuccessView()));
@@ -121,7 +121,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
String view = getFormView();
Locale locale = Context.getLocale();
- MessageSourceAccessor msa = getMessageSourceAccessor();
+ MessageSourceAccessor msa = new MessageSourceAccessor(Context.getMessageSourceService());
if (Context.isAuthenticated()) {
// this concept proposal
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalListController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalListController.java
index 9dc25cec..085f9bf4 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptProposalListController.java
@@ -16,8 +16,8 @@
import java.util.TreeMap;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceFormController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceFormController.java
index 4da8024d..7b986f88 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceFormController.java
@@ -12,10 +12,10 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceListController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceListController.java
index 6de17d46..a2ba9e00 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptSourceListController.java
@@ -14,8 +14,8 @@
import java.util.Map;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordFormController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordFormController.java
index 0727fafe..639a87d7 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordFormController.java
@@ -11,7 +11,7 @@
import java.util.Locale;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordListController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordListController.java
index 5738700a..39ec545d 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordListController.java
@@ -11,7 +11,7 @@
import java.util.List;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.openmrs.ConceptStopWord;
import org.openmrs.api.ConceptService;
diff --git a/omod/src/main/java/org/openmrs/web/controller/concept/ProposeConceptFormController.java b/omod/src/main/java/org/openmrs/web/controller/concept/ProposeConceptFormController.java
index ce08a58f..f4539988 100644
--- a/omod/src/main/java/org/openmrs/web/controller/concept/ProposeConceptFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/concept/ProposeConceptFormController.java
@@ -14,10 +14,10 @@
import java.util.Locale;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/customdatatype/CustomValueController.java b/omod/src/main/java/org/openmrs/web/controller/customdatatype/CustomValueController.java
index d79b45fb..5131f87d 100644
--- a/omod/src/main/java/org/openmrs/web/controller/customdatatype/CustomValueController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/customdatatype/CustomValueController.java
@@ -12,7 +12,7 @@
import java.io.IOException;
import java.io.OutputStream;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
@@ -49,7 +49,7 @@ public class CustomValueController {
* @return html markup
* @throws IOException
*/
- @RequestMapping(method = RequestMethod.GET, value = "**/viewCustomValue.form")
+ @RequestMapping(method = RequestMethod.GET, value = "viewCustomValue.form")
@ResponseBody
public String viewCustomValue(@RequestParam("handler") String handlerClassname,
@RequestParam(value = "datatype", required = true) String datatypeClassname,
@@ -77,7 +77,7 @@ public String viewCustomValue(@RequestParam("handler") String handlerClassname,
* @param valueReference
* @throws IOException
*/
- @RequestMapping(method = RequestMethod.GET, value = "**/downloadCustomValue.form")
+ @RequestMapping(method = RequestMethod.GET, value = "downloadCustomValue.form")
public void downloadCustomValue(HttpServletResponse response, @RequestParam("handler") String handlerClassname,
@RequestParam(value = "datatype", required = true) String datatypeClassname,
@RequestParam(value = "value", required = true) String valueReference) throws IOException {
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterDisplayController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterDisplayController.java
index 141cd354..e230771e 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterDisplayController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterDisplayController.java
@@ -18,8 +18,8 @@
import java.util.Map;
import java.util.Set;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.apache.commons.logging.Log;
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterFormController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterFormController.java
index 845458a5..9e9a8e64 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterFormController.java
@@ -20,10 +20,10 @@
import java.util.TreeMap;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.lang.ArrayUtils;
import org.apache.commons.logging.Log;
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterRoleFormController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterRoleFormController.java
index f4806c17..a0b9d113 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterRoleFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterRoleFormController.java
@@ -26,8 +26,8 @@
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RequestParam;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpSession;
import java.util.ArrayList;
import java.util.List;
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeFormController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeFormController.java
index 4b2c0961..a78302f5 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeFormController.java
@@ -14,10 +14,10 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeListController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeListController.java
index 3ad7a8c2..88196980 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeListController.java
@@ -12,8 +12,8 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/LocationFormController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/LocationFormController.java
index c5d1b8d7..0a156470 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/LocationFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/LocationFormController.java
@@ -14,10 +14,10 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/encounter/LocationListController.java b/omod/src/main/java/org/openmrs/web/controller/encounter/LocationListController.java
index b6b826b2..333b3ad8 100644
--- a/omod/src/main/java/org/openmrs/web/controller/encounter/LocationListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/encounter/LocationListController.java
@@ -12,10 +12,10 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/AuditFieldController.java b/omod/src/main/java/org/openmrs/web/controller/form/AuditFieldController.java
index 2e181a5a..00e214fd 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/AuditFieldController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/AuditFieldController.java
@@ -9,9 +9,9 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FieldFormController.java b/omod/src/main/java/org/openmrs/web/controller/form/FieldFormController.java
index ce9d8884..4c571fb8 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FieldFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FieldFormController.java
@@ -16,10 +16,10 @@
import java.util.Locale;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FieldListController.java b/omod/src/main/java/org/openmrs/web/controller/form/FieldListController.java
index 2c5a6859..ef1c6d99 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FieldListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FieldListController.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeFormController.java b/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeFormController.java
index 4268e229..6c95ae27 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeFormController.java
@@ -9,10 +9,10 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeListController.java b/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeListController.java
index 0732efd9..8abc2875 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FieldTypeListController.java
@@ -23,10 +23,10 @@
import org.springframework.web.servlet.mvc.SimpleFormController;
import org.springframework.web.servlet.view.RedirectView;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import java.util.List;
import java.util.Vector;
@@ -58,7 +58,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
String success = "";
String error = "";
- MessageSourceAccessor msa = getMessageSourceAccessor();
+ MessageSourceAccessor msa = new MessageSourceAccessor(Context.getMessageSourceService());
String deleted = msa.getMessage("general.deleted");
String notDeleted = msa.getMessage("general.cannot.delete");
String textFieldType = msa.getMessage("FieldType.fieldType");
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FormFormController.java b/omod/src/main/java/org/openmrs/web/controller/form/FormFormController.java
index 43107cde..01ba7cbf 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FormFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FormFormController.java
@@ -17,10 +17,10 @@
import java.util.TreeSet;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -76,7 +76,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
if (Context.isAuthenticated()) {
Form form = (Form) obj;
- MessageSourceAccessor msa = getMessageSourceAccessor();
+ MessageSourceAccessor msa = new MessageSourceAccessor(Context.getMessageSourceService());
String action = request.getParameter("action");
try {
if (action == null) {
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FormListController.java b/omod/src/main/java/org/openmrs/web/controller/form/FormListController.java
index a5e67e5b..542d6ed6 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FormListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FormListController.java
@@ -12,10 +12,10 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/form/FormResourceController.java b/omod/src/main/java/org/openmrs/web/controller/form/FormResourceController.java
index 25f8aad9..4ca9e574 100644
--- a/omod/src/main/java/org/openmrs/web/controller/form/FormResourceController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/form/FormResourceController.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
diff --git a/omod/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java b/omod/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java
index 4156f6b8..e224580d 100644
--- a/omod/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java
@@ -9,10 +9,10 @@
*/
package org.openmrs.web.controller.hl7;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/hl7/Hl7SourceListController.java b/omod/src/main/java/org/openmrs/web/controller/hl7/Hl7SourceListController.java
index c98f9beb..c9c3a80e 100644
--- a/omod/src/main/java/org/openmrs/web/controller/hl7/Hl7SourceListController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/hl7/Hl7SourceListController.java
@@ -12,8 +12,8 @@
import java.util.List;
import java.util.Vector;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/layout/LayoutPortletController.java b/omod/src/main/java/org/openmrs/web/controller/layout/LayoutPortletController.java
index 60cb438e..12125052 100644
--- a/omod/src/main/java/org/openmrs/web/controller/layout/LayoutPortletController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/layout/LayoutPortletController.java
@@ -12,7 +12,7 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/maintenance/CurrentUsersController.java b/omod/src/main/java/org/openmrs/web/controller/maintenance/CurrentUsersController.java
index 8456eb20..08a9dba2 100644
--- a/omod/src/main/java/org/openmrs/web/controller/maintenance/CurrentUsersController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/maintenance/CurrentUsersController.java
@@ -18,8 +18,8 @@
import org.openmrs.web.user.CurrentUsers;
import org.springframework.web.servlet.mvc.SimpleFormController;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
import java.util.List;
/**
diff --git a/omod/src/main/java/org/openmrs/web/controller/maintenance/GlobalPropertyController.java b/omod/src/main/java/org/openmrs/web/controller/maintenance/GlobalPropertyController.java
index 37016c04..cfd912ce 100644
--- a/omod/src/main/java/org/openmrs/web/controller/maintenance/GlobalPropertyController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/maintenance/GlobalPropertyController.java
@@ -14,10 +14,10 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -64,7 +64,7 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
action = "cancel";
}
- if (action.equals(getMessageSourceAccessor().getMessage("general.save"))) {
+ if (action.equals(Context.getMessageSourceService().getMessage("general.save"))) {
HttpSession httpSession = request.getSession();
if (Context.isAuthenticated()) {
diff --git a/omod/src/main/java/org/openmrs/web/controller/maintenance/ImplementationIdFormController.java b/omod/src/main/java/org/openmrs/web/controller/maintenance/ImplementationIdFormController.java
index 0a84beea..4755a97e 100644
--- a/omod/src/main/java/org/openmrs/web/controller/maintenance/ImplementationIdFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/maintenance/ImplementationIdFormController.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.maintenance;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/maintenance/QuickReportsController.java b/omod/src/main/java/org/openmrs/web/controller/maintenance/QuickReportsController.java
index f71814bf..bdec0a9f 100644
--- a/omod/src/main/java/org/openmrs/web/controller/maintenance/QuickReportsController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/maintenance/QuickReportsController.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.controller.maintenance;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/maintenance/ServerLogController.java b/omod/src/main/java/org/openmrs/web/controller/maintenance/ServerLogController.java
index 6ab5ecae..7dad2e3d 100644
--- a/omod/src/main/java/org/openmrs/web/controller/maintenance/ServerLogController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/maintenance/ServerLogController.java
@@ -15,9 +15,9 @@
import java.util.Collections;
import java.util.List;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/maintenance/SettingsController.java b/omod/src/main/java/org/openmrs/web/controller/maintenance/SettingsController.java
index 9ff721f3..0ff3c3a0 100644
--- a/omod/src/main/java/org/openmrs/web/controller/maintenance/SettingsController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/maintenance/SettingsController.java
@@ -15,8 +15,8 @@
import java.util.SortedSet;
import java.util.TreeSet;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.lang.StringUtils;
import org.apache.log4j.Logger;
diff --git a/omod/src/main/java/org/openmrs/web/controller/observation/ObsFormController.java b/omod/src/main/java/org/openmrs/web/controller/observation/ObsFormController.java
index 691a68e5..d4866a58 100644
--- a/omod/src/main/java/org/openmrs/web/controller/observation/ObsFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/observation/ObsFormController.java
@@ -14,10 +14,10 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/observation/PersonObsFormController.java b/omod/src/main/java/org/openmrs/web/controller/observation/PersonObsFormController.java
index f252f60c..c44f0259 100644
--- a/omod/src/main/java/org/openmrs/web/controller/observation/PersonObsFormController.java
+++ b/omod/src/main/java/org/openmrs/web/controller/observation/PersonObsFormController.java
@@ -13,7 +13,7 @@
import java.util.Comparator;
import java.util.List;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/controller/observation/handler/WebMediaHandler.java b/omod/src/main/java/org/openmrs/web/controller/observation/handler/WebMediaHandler.java
index b0d9fabd..15dcf1f4 100644
--- a/omod/src/main/java/org/openmrs/web/controller/observation/handler/WebMediaHandler.java
+++ b/omod/src/main/java/org/openmrs/web/controller/observation/handler/WebMediaHandler.java
@@ -9,6 +9,7 @@
*/
package org.openmrs.web.controller.observation.handler;
+import java.io.File;
import java.util.Locale;
import java.util.List;
import java.util.ArrayList;
@@ -65,7 +66,7 @@ public Obs getObs(Obs obs, String view) {
if (ComplexObsHandler.HTML_VIEW.equals(view)) {
String mediaTag = "";
- String mimeType = OpenmrsUtil.getFileMimeType(getComplexDataFile(obs));
+ String mimeType = OpenmrsUtil.getFileMimeType(new File(parseDataKey(obs)));
if (mimeType.contains("video")) {
mediaTag = "
*
- * @see javax.servlet.jsp.tagext.TagSupport#doStartTag()
+ * @see jakarta.servlet.jsp.tagext.TagSupport#doStartTag()
* @should include body for user with the privilege
* @should skip body for user without the privilege
* @should skip body for user with the privilege if inverse is true
diff --git a/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationByPrefixTag.java b/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationByPrefixTag.java
index be76994f..d5a325bf 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationByPrefixTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationByPrefixTag.java
@@ -13,10 +13,10 @@
import java.util.HashSet;
import java.util.Set;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.jsp.JspException;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.jsp.JspException;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
@@ -42,7 +42,7 @@ public class RequireConfigurationByPrefixTag extends TagSupport {
private String configurationPage;
/**
- * @see javax.servlet.jsp.tagext.TagSupport#doStartTag()
+ * @see jakarta.servlet.jsp.tagext.TagSupport#doStartTag()
*/
public int doStartTag() throws JspException {
diff --git a/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationTag.java b/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationTag.java
index 77f68b60..cae5ae70 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/RequireConfigurationTag.java
@@ -11,10 +11,10 @@
import java.io.IOException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.jsp.JspException;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.jsp.JspException;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
@@ -39,7 +39,7 @@ public class RequireConfigurationTag extends TagSupport {
private String configurationPage;
/**
- * @see javax.servlet.jsp.tagext.TagSupport#doStartTag()
+ * @see jakarta.servlet.jsp.tagext.TagSupport#doStartTag()
* @should redirect if any properties are not set
* @should not be sensitive to extraneous whitespace
* @should not be sensitive to empty values
diff --git a/omod/src/main/java/org/openmrs/web/taglib/RequireTag.java b/omod/src/main/java/org/openmrs/web/taglib/RequireTag.java
index 4ab88543..0d9e036e 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/RequireTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/RequireTag.java
@@ -13,10 +13,10 @@
import java.util.ArrayList;
import java.util.List;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -69,7 +69,7 @@ public class RequireTag extends TagSupport {
*
* Returns SKIP_PAGE if the user doesn't have the privilege and SKIP_BODY if it does.
*
- * @see javax.servlet.jsp.tagext.TagSupport#doStartTag()
+ * @see jakarta.servlet.jsp.tagext.TagSupport#doStartTag()
* @should allow user with the privilege
* @should allow user to have any privilege
* @should allow user with all privileges
@@ -293,7 +293,7 @@ private void addMissingPrivilege(String p) {
}
/**
- * @see javax.servlet.jsp.tagext.TagSupport#doEndTag()
+ * @see jakarta.servlet.jsp.tagext.TagSupport#doEndTag()
*/
public int doEndTag() {
missingPrivilegesBuffer = null;
diff --git a/omod/src/main/java/org/openmrs/web/taglib/ShowGraphTag.java b/omod/src/main/java/org/openmrs/web/taglib/ShowGraphTag.java
index e91387e6..ad8e3007 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/ShowGraphTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/ShowGraphTag.java
@@ -13,9 +13,9 @@
import java.io.IOException;
import java.util.List;
-import javax.servlet.jsp.JspException;
-import javax.servlet.jsp.JspTagException;
-import javax.servlet.jsp.tagext.BodyTagSupport;
+import jakarta.servlet.jsp.JspException;
+import jakarta.servlet.jsp.JspTagException;
+import jakarta.servlet.jsp.tagext.BodyTagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -87,7 +87,7 @@ public int doStartTag() throws JspException {
}
/**
- * @see javax.servlet.jsp.tagext.Tag#doEndTag()
+ * @see jakarta.servlet.jsp.tagext.Tag#doEndTag()
*/
public int doEndTag() throws JspException {
try {
diff --git a/omod/src/main/java/org/openmrs/web/taglib/SummaryTest.java b/omod/src/main/java/org/openmrs/web/taglib/SummaryTest.java
index 87d800f7..722a5791 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/SummaryTest.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/SummaryTest.java
@@ -20,7 +20,7 @@
import java.util.Set;
import java.util.StringTokenizer;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/taglib/TimePatternTag.java b/omod/src/main/java/org/openmrs/web/taglib/TimePatternTag.java
index 42fc2fa8..f94ace9c 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/TimePatternTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/TimePatternTag.java
@@ -13,7 +13,7 @@
import org.apache.commons.logging.LogFactory;
import org.openmrs.api.context.Context;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.jsp.tagext.TagSupport;
import java.text.SimpleDateFormat;
/**
@@ -41,7 +41,7 @@ public class TimePatternTag extends TagSupport {
/**
* Does the actual working of printing the time pattern
*
- * @see javax.servlet.jsp.tagext.TagSupport#doStartTag()
+ * @see jakarta.servlet.jsp.tagext.TagSupport#doStartTag()
*/
@Override
public int doStartTag() {
diff --git a/omod/src/main/java/org/openmrs/web/taglib/UserPropertyTag.java b/omod/src/main/java/org/openmrs/web/taglib/UserPropertyTag.java
index b943570e..be8cb3a0 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/UserPropertyTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/UserPropertyTag.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.taglib;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/taglib/UserWidgetTag.java b/omod/src/main/java/org/openmrs/web/taglib/UserWidgetTag.java
index 99793182..1558f39e 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/UserWidgetTag.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/UserWidgetTag.java
@@ -11,8 +11,8 @@
import java.io.IOException;
-import javax.servlet.jsp.JspWriter;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.jsp.JspWriter;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java b/omod/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java
index 6552c28d..cc39fa47 100644
--- a/omod/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java
+++ b/omod/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java
@@ -12,8 +12,8 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.jsp.JspException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.jsp.JspException;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/omod/src/main/java/org/openmrs/web/user/CurrentUsers.java b/omod/src/main/java/org/openmrs/web/user/CurrentUsers.java
index 202ba9e2..b53a8897 100644
--- a/omod/src/main/java/org/openmrs/web/user/CurrentUsers.java
+++ b/omod/src/main/java/org/openmrs/web/user/CurrentUsers.java
@@ -16,8 +16,8 @@
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.stream.Collectors;
-import javax.servlet.ServletContext;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletContext;
+import jakarta.servlet.http.HttpSession;
import org.apache.commons.lang.StringUtils;
import org.openmrs.User;
diff --git a/omod/src/main/java/org/openmrs/web/xss/XSSFilter.java b/omod/src/main/java/org/openmrs/web/xss/XSSFilter.java
index c3857ffa..91adae28 100644
--- a/omod/src/main/java/org/openmrs/web/xss/XSSFilter.java
+++ b/omod/src/main/java/org/openmrs/web/xss/XSSFilter.java
@@ -11,17 +11,18 @@
import java.io.IOException;
-import javax.servlet.Filter;
-import javax.servlet.FilterChain;
-import javax.servlet.FilterConfig;
-import javax.servlet.ServletException;
-import javax.servlet.ServletRequest;
-import javax.servlet.ServletResponse;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.Filter;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.FilterConfig;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
-import org.apache.commons.fileupload.servlet.ServletFileUpload;
import org.springframework.web.multipart.support.DefaultMultipartHttpServletRequest;
+import static org.apache.commons.fileupload2.jakarta.JakartaServletFileUpload.isMultipartContent;
+
public class XSSFilter implements Filter {
@Override
@@ -29,7 +30,7 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
ServletException {
if (!"GET".equalsIgnoreCase(((HttpServletRequest) request).getMethod())) {
- if (ServletFileUpload.isMultipartContent((HttpServletRequest) request)) {
+ if (isMultipartContent((HttpServletRequest) request)) {
request = new XSSMultipartRequestWrapper((DefaultMultipartHttpServletRequest) request);
} else {
request = new XSSRequestWrapper((HttpServletRequest) request);
diff --git a/omod/src/main/java/org/openmrs/web/xss/XSSRequestWrapper.java b/omod/src/main/java/org/openmrs/web/xss/XSSRequestWrapper.java
index c6306b0f..765d7ad2 100644
--- a/omod/src/main/java/org/openmrs/web/xss/XSSRequestWrapper.java
+++ b/omod/src/main/java/org/openmrs/web/xss/XSSRequestWrapper.java
@@ -13,9 +13,10 @@
import java.io.IOException;
import java.nio.charset.StandardCharsets;
-import javax.servlet.ServletInputStream;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletRequestWrapper;
+import jakarta.servlet.ReadListener;
+import jakarta.servlet.ServletInputStream;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequestWrapper;
import org.apache.commons.io.IOUtils;
import org.owasp.encoder.Encode;
@@ -57,17 +58,33 @@ public String getParameter(String name) {
@Override
public ServletInputStream getInputStream() throws IOException {
- String requestBody = IOUtils.toString(super.getInputStream(), StandardCharsets.UTF_8.name());
+ String requestBody = IOUtils.toString(super.getInputStream(), StandardCharsets.UTF_8);
String sanitizedBody = Encode.forHtmlContent(requestBody);
return new ServletInputStream() {
-
+
private final ByteArrayInputStream byteArrayInputStream = new ByteArrayInputStream(sanitizedBody.getBytes());
-
+
@Override
public int read() throws IOException {
return byteArrayInputStream.read();
}
+
+
+ @Override
+ public boolean isFinished() {
+ return byteArrayInputStream.available() == 0;
+ }
+
+ @Override
+ public boolean isReady() {
+ return true;
+ }
+
+ @Override
+ public void setReadListener(ReadListener readListener) {
+
+ }
};
}
}
diff --git a/omod/src/main/java/org/openmrs/web/xss/XSSUtil.java b/omod/src/main/java/org/openmrs/web/xss/XSSUtil.java
index 8fa40916..cf57c0af 100644
--- a/omod/src/main/java/org/openmrs/web/xss/XSSUtil.java
+++ b/omod/src/main/java/org/openmrs/web/xss/XSSUtil.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.xss;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.apache.commons.lang3.StringUtils;
import org.owasp.encoder.Encode;
diff --git a/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractFormController.java b/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractFormController.java
index 1ef9ce06..4f26a856 100644
--- a/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractFormController.java
+++ b/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractFormController.java
@@ -28,10 +28,10 @@
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpSession;
import org.springframework.validation.BindException;
import org.springframework.validation.Errors;
diff --git a/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractWizardFormController.java b/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractWizardFormController.java
index 41a5d2a4..9014f8bb 100644
--- a/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractWizardFormController.java
+++ b/omod/src/main/java/org/springframework/web/servlet/mvc/AbstractWizardFormController.java
@@ -33,9 +33,9 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.springframework.validation.BindException;
import org.springframework.validation.Errors;
diff --git a/omod/src/main/java/org/springframework/web/servlet/mvc/BaseCommandController.java b/omod/src/main/java/org/springframework/web/servlet/mvc/BaseCommandController.java
index 1901f6f0..87219ae4 100644
--- a/omod/src/main/java/org/springframework/web/servlet/mvc/BaseCommandController.java
+++ b/omod/src/main/java/org/springframework/web/servlet/mvc/BaseCommandController.java
@@ -26,7 +26,7 @@
*/
package org.springframework.web.servlet.mvc;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.springframework.beans.BeanUtils;
import org.springframework.beans.PropertyEditorRegistrar;
@@ -515,7 +515,7 @@ protected boolean useDirectFieldAccess() {
*/
protected void initBinder(HttpServletRequest request, ServletRequestDataBinder binder) throws Exception {
if (this.webBindingInitializer != null) {
- this.webBindingInitializer.initBinder(binder, new ServletWebRequest(request));
+ this.webBindingInitializer.initBinder(binder);
}
}
diff --git a/omod/src/main/java/org/springframework/web/servlet/mvc/SimpleFormController.java b/omod/src/main/java/org/springframework/web/servlet/mvc/SimpleFormController.java
index 13137c20..f5401adb 100644
--- a/omod/src/main/java/org/springframework/web/servlet/mvc/SimpleFormController.java
+++ b/omod/src/main/java/org/springframework/web/servlet/mvc/SimpleFormController.java
@@ -28,9 +28,9 @@
import java.util.Map;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.springframework.validation.BindException;
import org.springframework.validation.Errors;
diff --git a/omod/src/main/resources/webModuleApplicationContext.xml b/omod/src/main/resources/webModuleApplicationContext.xml
index 597fe981..237bc371 100644
--- a/omod/src/main/resources/webModuleApplicationContext.xml
+++ b/omod/src/main/resources/webModuleApplicationContext.xml
@@ -11,39 +11,23 @@
-->
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.springframework.org/schema/beans
+ http://www.springframework.org/schema/beans/spring-beans-3.0.xsd">
-
-
+
+
+
+
+
- 100
+
patientForm
@@ -64,7 +48,6 @@
addPerson
- portletController
moduleListController
modulePropertiesFormController
@@ -133,109 +116,73 @@
forgotPasswordForm
- globalPropertyPortletController
- addressLayoutPortletController
- nameLayoutPortletController
- patientProgramsPortletController
- personRelationshipsPortletController
- patientEncountersPortletController
- patientVisitsPortletController
- personFormEntryPortletController
-
- fieldGenController
-
visitTypeList
visitTypeForm
visitAttributeTypeList
visitAttributeTypeForm
providerAttributeTypeList
- providerAttributeTypeForm
+ providerAttributeTypeForm
- springController
-
+ legacyCatchAllController
+
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- theme
-
-
-
-
-
-
+
- patient
- /module/legacyui/admin/patients/patientForm
- patient.form
+
+
+
- tribeForm
- /module/legacyui/admin/patients/tribeList
- tribe.list
+
+
+
- patientIdentifierTypeList
- /module/legacyui/admin/patients/patientIdentifierTypeList
- patientIdentifierType.list
+
+
+
- patientIdentifierType
-
-
-
- /module/legacyui/admin/patients/patientIdentifierTypeForm
- patientIdentifierType.list
+
+
+
+
- patient1
- /module/legacyui/admin/patients/mergePatientsForm
- mergePatients.form
+
+
+
@@ -246,70 +193,66 @@
- command
- /module/legacyui/admin/users/user
- user.htm
+
+
+
- roleList
- /module/legacyui/admin/users/roleList
- role.list
+
+
+
- role
-
-
-
- /module/legacyui/admin/users/roleForm
- role.list
+
+
+
+
- privilegeList
- /module/legacyui/admin/users/privilegeList
- privilege.list
+
+
+
- privilege
-
-
-
- /module/legacyui/admin/users/privilegeForm
- privilege.list
+
+
+
+
- alertList
- /module/legacyui/admin/users/alertList
- alert.list
+
+
+
- alert
- /module/legacyui/admin/users/alertForm
- alert.list
+
+
+
- moduleList
- /module/legacyui/admin/modules/moduleList
- module.list
+
+
+
- moduleProperties
- /module/legacyui/admin/modules/modulePropertiesForm
- moduleProperties.form
+
+
+
@@ -318,9 +261,9 @@
- people
- /module/legacyui/admin/person/addPerson
- admin/person/newPerson.form
+
+
+
@@ -339,98 +282,92 @@
- taskList
- /module/legacyui/admin/scheduler/schedulerList
- scheduler.list
+
+
+
- task
- /module/legacyui/admin/scheduler/schedulerForm
- scheduler.list
-
-
-
+
+
+
+
- command
- /admin/observations/personObsForm
- personObs.form
+
+
+
- person
- /module/legacyui/admin/person/personForm
- person.form
-
+
+
+
+
- relationshipTypeList
- /module/legacyui/admin/person/relationshipTypeList
- relationshipType.list
+
+
+
- relationshipType
- /module/legacyui/admin/person/relationshipTypeForm
- relationshipType.list
+
+
+
- relationshipTypeList
- /module/legacyui/admin/person/relationshipTypeViewForm
- relationshipType.list
+
+
+
- personAttributeType
- /module/legacyui/admin/person/personAttributeTypeForm
- personAttributeType.list
-
+
+
+
+
- encounter
- /module/legacyui/admin/encounters/encounterForm
- encounter.form
+
+
+
- encounterTypeList
- /module/legacyui/admin/encounters/encounterTypeList
- encounterType.list
+
+
+
- encounterType
-
-
-
- /module/legacyui/admin/encounters/encounterTypeForm
- encounterType.list
+
+
+
+
- locationList
- /module/legacyui/admin/locations/locationList
- location.list
+
+
+
- location
-
-
-
- /module/legacyui/admin/locations/locationForm
- location.list
+
+
+
+
- command
-
-
-
- /module/legacyui/dictionary/conceptForm
- concept.form
+
+
+
+
- concept
- /module/legacyui/dictionary/conceptStatsForm
- conceptStats.form
+
+
+
- command
- /module/legacyui/dictionary/concept
- concept.htm
+
+
+
- conceptDrugList
- /admin/concepts/conceptDrugList
- conceptDrug.list
+
+
+
- drug
-
-
-
- /admin/concepts/conceptDrugForm
- conceptDrug.list
+
+
+
+
- conceptClassList
- /admin/concepts/conceptClassList
- conceptClass.list
+
+
+
- conceptClass
-
-
-
- /admin/concepts/conceptClassForm
- conceptClass.list
+
+
+
+
- conceptDatatypeList
- /admin/concepts/conceptDatatypeList
- conceptDatatype.list
+
+
+
- conceptProposalMap
- /admin/concepts/conceptProposalList
- conceptProposal.list
+
+
+
- conceptProposal
- /admin/concepts/conceptProposalForm
- conceptProposal.list
+
+
+
- conceptProposal
- /admin/concepts/proposeConceptForm
- conceptProposal.list
+
+
+
- conceptSourceList
- /admin/concepts/conceptSourceList
- conceptSource.list
+
+
+
- conceptSource
-
-
-
- /admin/concepts/conceptSourceForm
- conceptSource.list
+
+
+
+
- formList
- /module/legacyui/admin/forms/formList
- form.list
+
+
+
- form
- /module/legacyui/admin/forms/formSchemaDesignForm
- form.list
+
+
+
- form
- /module/legacyui/admin/forms/formEditForm
-
-
-
- form.list
+
+
+
+
- fieldList
- /module/legacyui/admin/forms/fieldList
- field.list
+
+
+
- field
-
-
-
- /module/legacyui/admin/forms/fieldForm
- field.list
+
+
+
+
- /module/legacyui/admin/forms/auditFieldForm
- auditField.form
+
+
- fieldTypeList
- /module/legacyui/admin/forms/fieldTypeList
- fieldType.list
+
+
+
- fieldType
-
-
-
- /module/legacyui/admin/forms/fieldTypeForm
- fieldType.list
+
+
+
+
- programList
- /module/legacyui/admin/programs/programList
- program.list
+
+
+
- program
-
-
-
- /module/legacyui/admin/programs/programForm
- program.list
+
+
+
+
- workflow
- /module/legacyui/admin/programs/workflowForm
- program.list
+
+
+
- stateConversionList
- /module/legacyui/admin/programs/conversionList
- conversion.list
+
+
+
- conversion
-
-
-
- /module/legacyui/admin/programs/conversionForm
- conversion.list
+
+
+
+
- hl7SourceList
- /module/legacyui/admin/hl7/hl7SourceList
- hl7Source.list
+
+
+
- hl7Source
-
-
-
- /module/legacyui/admin/hl7/hl7SourceForm
- hl7Source.list
+
+
+
+
- /remotecommunication/postHl7Form
+
- opts
- org.openmrs.web.OptionsForm
- /module/legacyui/optionsForm
- options.form
+
+
+
+
- person
- /personDashboardForm
- personDashboard.form
+
+
+
- globalProps
- /module/legacyui/admin/maintenance/globalPropsForm
- globalProps.form
+
+
+
- logLines
- /module/legacyui/admin/maintenance/serverLog
- serverLog.form
+
+
+
- implId
- /module/legacyui/admin/maintenance/implementationIdForm
- implementationid.form
+
+
+
- currentUsers
- /module/legacyui/admin/maintenance/currentUsers
- currentUsers.list
+
+
+
- forgotPassword
- /forgotPasswordForm
- forgotPassword.form
+
+
+
- visitTypeList
- /admin/visits/visitTypeList
- visitType.list
+
+
+
- visitType
-
-
-
- /admin/visits/visitTypeForm
- visitType.list
+
+
+
+
- visitAttributeTypeList
- /admin/visits/visitAttributeTypeList
- visitAttributeType.list
+
+
+
- visitAttributeType
-
-
-
- /admin/visits/visitAttributeTypeForm
- visitAttributeType.list
+
+
+
+
- obs
- /module/legacyui/admin/observations/obsForm
- ../encounters/encounter.form
-
-
-
+
+
+
+
- providerAttributeTypeList
- /module/legacyui/admin/provider/providerAttributeTypeList
- providerAttributeType.list
+
+
+
- providerAttributeType
-
-
-
- /module/legacyui/admin/provider/providerAttributeTypeForm
- providerAttributeType.list
+
+
+
+
- short
+
@@ -780,8 +689,8 @@
- Formato de Nombres en Espana
- spain
+
+
PersonName.givenName
@@ -806,8 +715,8 @@
- Formato de Nombres en Latino America
- latinamerica
+
+
PersonName.firstName
@@ -835,8 +744,8 @@
- "Given Family" Format
- givenfamily
+
+
PersonName.givenName
@@ -858,8 +767,8 @@
- Short Name Format
- short
+
+
PersonName.givenName
@@ -884,8 +793,8 @@
- Long Name Format
- long
+
+
PersonName.prefix
@@ -979,32 +888,6 @@
-
-
-
-
-
@@ -1017,32 +900,30 @@
- themes/defaults
+
-
-
- themes/
-
+
+
-
- green
+
+
- theme
+
-
+
- lang
+
diff --git a/omod/src/main/webapp/admin/concepts/conceptAttributeType.jsp b/omod/src/main/webapp/admin/concepts/conceptAttributeType.jsp
index a1a4e67a..3a1604a3 100644
--- a/omod/src/main/webapp/admin/concepts/conceptAttributeType.jsp
+++ b/omod/src/main/webapp/admin/concepts/conceptAttributeType.jsp
@@ -1,3 +1,4 @@
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
<%@ include file="/WEB-INF/view/module/legacyui/template/include.jsp" %>
diff --git a/omod/src/main/webapp/admin/concepts/conceptAttributeTypes.jsp b/omod/src/main/webapp/admin/concepts/conceptAttributeTypes.jsp
index 7739d4d6..8add8db2 100644
--- a/omod/src/main/webapp/admin/concepts/conceptAttributeTypes.jsp
+++ b/omod/src/main/webapp/admin/concepts/conceptAttributeTypes.jsp
@@ -1,3 +1,4 @@
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
<%@ include file="/WEB-INF/view/module/legacyui/template/include.jsp" %>
diff --git a/omod/src/main/webapp/admin/concepts/conceptClassForm.jsp b/omod/src/main/webapp/admin/concepts/conceptClassForm.jsp
index 4b683cb4..b76d6ab4 100644
--- a/omod/src/main/webapp/admin/concepts/conceptClassForm.jsp
+++ b/omod/src/main/webapp/admin/concepts/conceptClassForm.jsp
@@ -1,3 +1,4 @@
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
<%@ include file="/WEB-INF/view/module/legacyui/template/include.jsp" %>
diff --git a/omod/src/main/webapp/admin/concepts/conceptClassList.jsp b/omod/src/main/webapp/admin/concepts/conceptClassList.jsp
index e3c2d5c7..4f4dcf44 100644
--- a/omod/src/main/webapp/admin/concepts/conceptClassList.jsp
+++ b/omod/src/main/webapp/admin/concepts/conceptClassList.jsp
@@ -1,3 +1,4 @@
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
<%@ include file="/WEB-INF/view/module/legacyui/template/include.jsp" %>
diff --git a/omod/src/main/webapp/admin/concepts/conceptDatatypeList.jsp b/omod/src/main/webapp/admin/concepts/conceptDatatypeList.jsp
index f7423225..aa2b345e 100644
--- a/omod/src/main/webapp/admin/concepts/conceptDatatypeList.jsp
+++ b/omod/src/main/webapp/admin/concepts/conceptDatatypeList.jsp
@@ -1,3 +1,4 @@
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
<%@ include file="/WEB-INF/view/module/legacyui/template/include.jsp" %>
diff --git a/omod/src/main/webapp/admin/concepts/conceptDrugForm.jsp b/omod/src/main/webapp/admin/concepts/conceptDrugForm.jsp
index ddad5f91..23de21cb 100644
--- a/omod/src/main/webapp/admin/concepts/conceptDrugForm.jsp
+++ b/omod/src/main/webapp/admin/concepts/conceptDrugForm.jsp
@@ -4,15 +4,15 @@
<%@ include file="/WEB-INF/view/module/legacyui/template/header.jsp" %>
<%@ include file="localHeader.jsp" %>
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
diff --git a/omod/src/main/webapp/template/headerMinimal.jsp b/omod/src/main/webapp/template/headerMinimal.jsp
index 469259cd..f3edb4d2 100644
--- a/omod/src/main/webapp/template/headerMinimal.jsp
+++ b/omod/src/main/webapp/template/headerMinimal.jsp
@@ -1,3 +1,4 @@
+<%@ taglib prefix="c" uri="jakarta.tags.core" %>
<%@ page pageEncoding="UTF-8" contentType="text/html; charset=UTF-8" %>
@@ -15,10 +16,9 @@
%>
+ xmlns:c="jakarta.tags.core"
+ xmlns:jsp="https://jakarta.ee/xml/ns/jakartaee"
+ xmlns:openmrs="urn:jsptld:/WEB-INF/view/module/legacyui/taglibs/openmrs.tld">
diff --git a/omod/src/main/webapp/template/include.jsp b/omod/src/main/webapp/template/include.jsp
index 20034b79..66eea688 100644
--- a/omod/src/main/webapp/template/include.jsp
+++ b/omod/src/main/webapp/template/include.jsp
@@ -1,9 +1,4 @@
-<%@ taglib prefix="c" uri="/WEB-INF/view/module/legacyui/taglibs/c-rt.tld" %>
<%@ taglib prefix="openmrs" uri="/WEB-INF/view/module/legacyui/taglibs/openmrs.tld" %>
<%@ taglib prefix="openmrs_tag" tagdir="/WEB-INF/tags/module/legacyui" %>
-<%@ taglib prefix="page" uri="/WEB-INF/view/module/legacyui/taglibs/page.tld" %>
-<%@ taglib prefix="request" uri="/WEB-INF/view/module/legacyui/taglibs/request.tld" %>
-<%@ taglib prefix="response" uri="/WEB-INF/view/module/legacyui/taglibs/response.tld" %>
-<%@ taglib prefix="spring" uri="/WEB-INF/view/module/legacyui/taglibs/spring.tld" %>
-<%@ taglib prefix="fn" uri="/WEB-INF/view/module/legacyui/taglibs/fn.tld" %>
-<%@ taglib prefix="form" uri="/WEB-INF/view/module/legacyui/taglibs/spring-form.tld" %>
\ No newline at end of file
+<%@ taglib prefix="spring" uri="http://www.springframework.org/tags" %>
+<%@ taglib prefix="form" uri="http://www.springframework.org/tags/form" %>
\ No newline at end of file
diff --git a/omod/src/main/webapp/uncaughtException.jsp b/omod/src/main/webapp/uncaughtException.jsp
index 53f29c91..2ad63658 100644
--- a/omod/src/main/webapp/uncaughtException.jsp
+++ b/omod/src/main/webapp/uncaughtException.jsp
@@ -79,7 +79,7 @@
try {
// The Servlet spec guarantees this attribute will be available
- //Throwable exception = (Throwable) request.getAttribute("javax.servlet.error.exception");
+ //Throwable exception = (Throwable) request.getAttribute("jakarta.servlet.error.exception");
if (exception != null) {
%>
diff --git a/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormControllerTest.java b/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormControllerTest.java
index 8ee56947..01a42c48 100644
--- a/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormControllerTest.java
@@ -16,8 +16,8 @@
import java.util.Calendar;
import java.util.Date;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
diff --git a/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormTest.java b/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormTest.java
index 435b72cf..982a3783 100644
--- a/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormTest.java
+++ b/omod/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormTest.java
@@ -11,7 +11,7 @@
import static org.junit.Assert.assertNotNull;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.junit.Test;
import org.openmrs.web.test.BaseModuleWebContextSensitiveTest;
diff --git a/omod/src/test/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandlerTest.java b/omod/src/test/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandlerTest.java
index e9c227bf..f1cee9fc 100644
--- a/omod/src/test/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandlerTest.java
+++ b/omod/src/test/java/org/openmrs/web/attribute/handler/RegexValidatedTextDatatypeHandlerTest.java
@@ -14,7 +14,7 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.junit.Rule;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/ConceptFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/ConceptFormControllerTest.java
index d7687f31..cb5ff144 100644
--- a/omod/src/test/java/org/openmrs/web/controller/ConceptFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/ConceptFormControllerTest.java
@@ -9,6 +9,7 @@
*/
package org.openmrs.web.controller;
+import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.greaterThan;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;
@@ -16,17 +17,13 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
import java.util.Collection;
import java.util.Locale;
-import java.util.Set;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
@@ -35,9 +32,7 @@
import org.openmrs.ConceptAnswer;
import org.openmrs.ConceptAttribute;
import org.openmrs.ConceptAttributeType;
-import org.openmrs.ConceptClass;
import org.openmrs.ConceptComplex;
-import org.openmrs.ConceptDatatype;
import org.openmrs.ConceptDescription;
import org.openmrs.ConceptMap;
import org.openmrs.ConceptMapType;
@@ -54,12 +49,12 @@
import org.openmrs.util.LocaleUtility;
import org.openmrs.util.OpenmrsConstants;
import org.openmrs.web.controller.ConceptFormController.ConceptFormBackingObject;
-import org.openmrs.web.controller.concept.ConceptReferenceRange;
-import org.openmrs.web.controller.mappper.ConceptFormMapper;
import org.openmrs.web.test.BaseModuleWebContextSensitiveTest;
import org.openmrs.web.test.WebTestHelper;
import org.openmrs.web.test.WebTestHelper.Response;
+import org.springframework.beans.factory.ObjectFactory;
import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.mock.web.MockHttpSession;
@@ -77,6 +72,10 @@ public class ConceptFormControllerTest extends BaseModuleWebContextSensitiveTest
@Autowired
ConceptService conceptService;
+
+ @Autowired
+ @Qualifier("conceptForm")
+ ObjectFactory conceptFormProvider;
private Locale britishEn;
@@ -97,14 +96,14 @@ public void updateSearchIndex() {
*/
@Test
public void shouldGetConcept() throws Exception {
-
+
MockHttpServletRequest request = new MockHttpServletRequest("GET", "");
request.setParameter("conceptId", "3");
HttpServletResponse response = new MockHttpServletResponse();
-
- ConceptFormController controller = (ConceptFormController) applicationContext.getBean("conceptForm");
-
+
+ ConceptFormController controller = conceptFormProvider.getObject();
+
ModelAndView modelAndView = controller.handleRequest(request, response);
// make sure there is an "conceptId" filled in on the concept
@@ -126,7 +125,7 @@ public void shouldNotDeleteConceptsWhenConceptsAreLocked() throws Exception {
ConceptService cs = Context.getConceptService();
// set up the controller
- ConceptFormController controller = (ConceptFormController) applicationContext.getBean("conceptForm");
+ ConceptFormController controller = conceptFormProvider.getObject();
controller.setApplicationContext(applicationContext);
controller.setSuccessView("index.htm");
controller.setFormView("concept.form");
@@ -158,37 +157,37 @@ public void shouldNotDeleteConceptsWhenConceptsAreLocked() throws Exception {
*/
@Test
public void shouldAddConceptWithOnlyNameSpecified() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- Collection actualNames = actualConcept.getNames();
- assertEquals(1, actualNames.size());
- assertNull(actualConcept.getShortNameInLocale(britishEn));
- assertNotNull(actualConcept.getDescription(britishEn));
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(1, actualNames.size());
+ assertNull(actualConcept.getShortNameInLocale(britishEn));
+ assertNotNull(actualConcept.getDescription(britishEn));
+ }
/**
* This tests a concept form being submitted with also a short name supplied
@@ -197,40 +196,40 @@ public void shouldAddConceptWithOnlyNameSpecified() throws Exception {
*/
@Test
public void shouldAddConceptWithNameAndShortNameSpecified() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- Collection actualNames = actualConcept.getNames();
- assertEquals(2, actualNames.size());
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- assertEquals(1, actualConcept.getShortNames().size());
- assertNotNull(actualConcept.getShortNameInLocale(britishEn));
- assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(2, actualNames.size());
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ assertEquals(1, actualConcept.getShortNames().size());
+ assertNotNull(actualConcept.getShortNameInLocale(britishEn));
+ assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
+ }
/**
* Tests a concept form being submitted with name/shortname/description all filled in
@@ -239,44 +238,44 @@ public void shouldAddConceptWithNameAndShortNameSpecified() throws Exception {
*/
@Test
public void shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToCodeConcepts() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
- final String EXPECTED_DESCRIPTION = "this is not really a concept";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("concept.datatype", "4");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- Collection actualNames = actualConcept.getNames();
- assertEquals(2, actualNames.size());
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- assertNotNull(actualConcept.getShortNameInLocale(britishEn));
- assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
-
- assertNotNull(actualConcept.getDescription(britishEn));
- assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+ final String EXPECTED_DESCRIPTION = "this is not really a concept";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("concept.datatype", "4");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(2, actualNames.size());
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ assertNotNull(actualConcept.getShortNameInLocale(britishEn));
+ assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
+
+ assertNotNull(actualConcept.getDescription(britishEn));
+ assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
+ }
/**
* Tests a concept form being submitted with a name and description for numeric type of concepts
@@ -285,44 +284,44 @@ public void shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToCodeCon
*/
@Test
public void shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToNumericConcepts() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
- final String EXPECTED_DESCRIPTION = "this is not really a concept";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- Collection actualNames = actualConcept.getNames();
- assertEquals(2, actualNames.size());
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- assertNotNull(actualConcept.getShortNameInLocale(britishEn));
- assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
-
- assertNotNull(actualConcept.getDescription(britishEn));
- assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+ final String EXPECTED_DESCRIPTION = "this is not really a concept";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(2, actualNames.size());
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ assertNotNull(actualConcept.getShortNameInLocale(britishEn));
+ assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
+
+ assertNotNull(actualConcept.getDescription(britishEn));
+ assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
+ }
/**
* Test adding a concept with a preferred name, short name, description and synonyms.
@@ -331,56 +330,56 @@ public void shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToNumeric
*/
@Test
public void shouldAddConceptWithAllNamingSpecified() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
- final String EXPECTED_DESCRIPTION = "this is not really a concept";
- final String EXPECTED_SYNONYM_A = "phantom";
- final String EXPECTED_SYNONYM_B = "imaginary";
- final String EXPECTED_SYNONYM_C = "mock";
-
- AdministrationService as = Context.getAdministrationService();
- GlobalProperty gp = as.getGlobalPropertyObject(OpenmrsConstants.GLOBAL_PROPERTY_LOCALE_ALLOWED_LIST);
- gp.setPropertyValue("en_GB, en_US");
- as.saveGlobalProperty(gp);
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
- mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
- mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- Collection actualNames = actualConcept.getNames();
- assertEquals(5, actualNames.size());
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- assertNotNull(actualConcept.getShortNameInLocale(britishEn));
- assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
-
- assertNotNull(actualConcept.getDescription(britishEn));
- assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
-
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+ final String EXPECTED_DESCRIPTION = "this is not really a concept";
+ final String EXPECTED_SYNONYM_A = "phantom";
+ final String EXPECTED_SYNONYM_B = "imaginary";
+ final String EXPECTED_SYNONYM_C = "mock";
+
+ AdministrationService as = Context.getAdministrationService();
+ GlobalProperty gp = as.getGlobalPropertyObject(OpenmrsConstants.GLOBAL_PROPERTY_LOCALE_ALLOWED_LIST);
+ gp.setPropertyValue("en_GB, en_US");
+ as.saveGlobalProperty(gp);
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
+ mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
+ mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(5, actualNames.size());
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ assertNotNull(actualConcept.getShortNameInLocale(britishEn));
+ assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
+
+ assertNotNull(actualConcept.getDescription(britishEn));
+ assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
+
+ }
/**
* Test adding a concept with a preferred name, short name, description and synonyms.
@@ -389,48 +388,48 @@ public void shouldAddConceptWithAllNamingSpecified() throws Exception {
*/
@Test
public void shouldUpdateConceptWithNameAlreadyInSynonymList() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
- final String EXPECTED_DESCRIPTION = "this is not really a concept";
- final String EXPECTED_SYNONYM_A = "phantom";
- final String EXPECTED_SYNONYM_B = EXPECTED_PREFERRED_NAME;
- final String EXPECTED_SYNONYM_C = "mock";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
- mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
- mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- Collection actualNames = actualConcept.getNames();
- assertEquals(4, actualNames.size());
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- assertNotNull(actualConcept.getShortNameInLocale(britishEn));
- assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
-
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+ final String EXPECTED_DESCRIPTION = "this is not really a concept";
+ final String EXPECTED_SYNONYM_A = "phantom";
+ final String EXPECTED_SYNONYM_B = EXPECTED_PREFERRED_NAME;
+ final String EXPECTED_SYNONYM_C = "mock";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
+ mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
+ mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(4, actualNames.size());
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ assertNotNull(actualConcept.getShortNameInLocale(britishEn));
+ assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
+
+ }
/**
* Test adding a concept with a preferred name, short name, description and synonyms.
@@ -439,48 +438,48 @@ public void shouldUpdateConceptWithNameAlreadyInSynonymList() throws Exception {
*/
@Test
public void shouldUpdateConceptWithShortNameAlreadyInSynonymList() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
- final String EXPECTED_DESCRIPTION = "this is not really a concept";
- final String EXPECTED_SYNONYM_A = "phantom";
- final String EXPECTED_SYNONYM_B = EXPECTED_SHORT_NAME;
- final String EXPECTED_SYNONYM_C = "mock";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
- mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
- mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- Collection actualNames = actualConcept.getNames();
- assertEquals(4, actualNames.size());
- assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
- assertNotNull(actualConcept.getShortNameInLocale(britishEn));
- assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
-
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+ final String EXPECTED_DESCRIPTION = "this is not really a concept";
+ final String EXPECTED_SYNONYM_A = "phantom";
+ final String EXPECTED_SYNONYM_B = EXPECTED_SHORT_NAME;
+ final String EXPECTED_SYNONYM_C = "mock";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
+ mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
+ mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ Collection actualNames = actualConcept.getNames();
+ assertEquals(4, actualNames.size());
+ assertEquals(EXPECTED_PREFERRED_NAME, actualConcept.getFullySpecifiedName(britishEn).getName());
+ assertNotNull(actualConcept.getShortNameInLocale(britishEn));
+ assertEquals(EXPECTED_SHORT_NAME, actualConcept.getShortNameInLocale(britishEn).getName());
+
+ }
/**
* Test updating a concept by adding a name
@@ -489,32 +488,32 @@ public void shouldUpdateConceptWithShortNameAlreadyInSynonymList() throws Except
*/
@Test
public void shouldUpdateConceptByAddingName() throws Exception {
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept already exists
- Concept concept = cs.getConcept(3);
- assertNotNull(concept);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", concept.getConceptId().toString());
- mockRequest.setParameter("namesByLocale[en_GB].name", "new name");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- updateSearchIndex();
-
- Concept actualConcept = cs.getConceptByName("new name");
- assertNotNull(actualConcept);
- assertEquals(concept.getConceptId(), actualConcept.getConceptId());
- }
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept already exists
+ Concept concept = cs.getConcept(3);
+ assertNotNull(concept);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", concept.getConceptId().toString());
+ mockRequest.setParameter("namesByLocale[en_GB].name", "new name");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ updateSearchIndex();
+
+ Concept actualConcept = cs.getConceptByName("new name");
+ assertNotNull(actualConcept);
+ assertEquals(concept.getConceptId(), actualConcept.getConceptId());
+ }
/**
* Test removing short name by adding a blank short name
@@ -523,42 +522,42 @@ public void shouldUpdateConceptByAddingName() throws Exception {
*/
@Test
public void shouldVoidShortName() throws Exception {
- final String CONCEPT_NAME = "default concept name";
-
- ConceptService cs = Context.getConceptService();
-
- final Concept concept = new Concept();
- concept.addName(new ConceptName(CONCEPT_NAME, britishEn));
- concept.setShortName(new ConceptName("shortname", britishEn));
- concept.addDescription(new ConceptDescription("some description", null));
- concept.setDatatype(Context.getConceptService().getConceptDatatype(1));
- concept.setConceptClass(Context.getConceptService().getConceptClass(1));
- cs.saveConcept(concept);
-
- Concept actualConcept = cs.getConceptByName(CONCEPT_NAME);
- assertThat(actualConcept.getShortNameInLocale(britishEn), is(notNullValue()));
- assertThat(actualConcept.getShortNames().size(), greaterThan(0));
- assertThat(actualConcept.getNames().size(), is(2));
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", concept.getConceptId().toString());
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", " ");
- mockRequest.setParameter("concept.datatype", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
-
- actualConcept = cs.getConceptByName(CONCEPT_NAME);
- assertThat(actualConcept.getShortNameInLocale(britishEn), is(nullValue()));
- assertThat(actualConcept.getShortNames().size(), is(0));
- assertThat(actualConcept.getNames().size(), is(1));
- }
+ final String CONCEPT_NAME = "default concept name";
+
+ ConceptService cs = Context.getConceptService();
+
+ final Concept concept = new Concept(3);
+ concept.addName(new ConceptName(CONCEPT_NAME, britishEn));
+ concept.setShortName(new ConceptName("shortname", britishEn));
+ concept.addDescription(new ConceptDescription("some description", null));
+ concept.setDatatype(Context.getConceptService().getConceptDatatype(1));
+ concept.setConceptClass(Context.getConceptService().getConceptClass(1));
+ cs.saveConcept(concept);
+
+ Concept actualConcept = cs.getConceptByName(CONCEPT_NAME);
+ assertThat(actualConcept.getShortNameInLocale(britishEn), is(notNullValue()));
+ assertThat(actualConcept.getShortNames().size(), greaterThan(0));
+ assertThat(actualConcept.getNames().size(), is(2));
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", concept.getConceptId().toString());
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", " ");
+ mockRequest.setParameter("concept.datatype", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+
+ actualConcept = cs.getConceptByName(CONCEPT_NAME);
+ assertThat(actualConcept.getShortNameInLocale(britishEn), is(nullValue()));
+ assertThat(actualConcept.getShortNames().size(), is(0));
+ assertThat(actualConcept.getNames().size(), is(1));
+ }
/**
* Test adding a concept with a preferred name, short name, description and synonyms.
@@ -567,54 +566,54 @@ public void shouldVoidShortName() throws Exception {
*/
@Test
public void shouldReplacePreviousDescription() throws Exception {
- final String EXPECTED_PREFERRED_NAME = "no such concept";
- final String EXPECTED_SHORT_NAME = "nonesuch";
- final String ORIGINAL_DESCRIPTION = "this is indescribable";
- final String EXPECTED_DESCRIPTION = "this is not really a concept";
- final String EXPECTED_SYNONYM_A = "phantom";
- final String EXPECTED_SYNONYM_B = EXPECTED_SHORT_NAME;
- final String EXPECTED_SYNONYM_C = "mock";
-
- ConceptService cs = Context.getConceptService();
-
- // first, add the concept with an original description
- Concept conceptToUpdate = new Concept();
- conceptToUpdate.addName(new ConceptName("demo name", Context.getLocale()));
- ConceptDescription originalConceptDescription = new ConceptDescription();
- originalConceptDescription.setLocale(britishEn);
- originalConceptDescription.setDescription(ORIGINAL_DESCRIPTION);
- conceptToUpdate.addDescription(originalConceptDescription);
- conceptToUpdate.setDatatype(Context.getConceptService().getConceptDatatype(1));
- conceptToUpdate.setConceptClass(Context.getConceptService().getConceptClass(1));
- cs.saveConcept(conceptToUpdate);
-
- // then submit changes through the controller
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
- mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
- mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
- mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
-
- assertNotNull(actualConcept.getDescription(britishEn));
- assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
- }
+ final String EXPECTED_PREFERRED_NAME = "no such concept";
+ final String EXPECTED_SHORT_NAME = "nonesuch";
+ final String ORIGINAL_DESCRIPTION = "this is indescribable";
+ final String EXPECTED_DESCRIPTION = "this is not really a concept";
+ final String EXPECTED_SYNONYM_A = "phantom";
+ final String EXPECTED_SYNONYM_B = EXPECTED_SHORT_NAME;
+ final String EXPECTED_SYNONYM_C = "mock";
+
+ ConceptService cs = Context.getConceptService();
+
+ // first, add the concept with an original description
+ Concept conceptToUpdate = new Concept();
+ conceptToUpdate.addName(new ConceptName("demo name", Context.getLocale()));
+ ConceptDescription originalConceptDescription = new ConceptDescription();
+ originalConceptDescription.setLocale(britishEn);
+ originalConceptDescription.setDescription(ORIGINAL_DESCRIPTION);
+ conceptToUpdate.addDescription(originalConceptDescription);
+ conceptToUpdate.setDatatype(Context.getConceptService().getConceptDatatype(1));
+ conceptToUpdate.setConceptClass(Context.getConceptService().getConceptClass(1));
+ cs.saveConcept(conceptToUpdate);
+
+ // then submit changes through the controller
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("synonymsByLocale[en_GB][0].name", EXPECTED_SYNONYM_A);
+ mockRequest.setParameter("synonymsByLocale[en_GB][1].name", EXPECTED_SYNONYM_B);
+ mockRequest.setParameter("synonymsByLocale[en_GB][2].name", EXPECTED_SYNONYM_C);
+ mockRequest.setParameter("shortNamesByLocale[en_GB].name", EXPECTED_SHORT_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", EXPECTED_DESCRIPTION);
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+
+ assertNotNull(actualConcept.getDescription(britishEn));
+ assertEquals(EXPECTED_DESCRIPTION, actualConcept.getDescription(britishEn).getDescription());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -622,44 +621,44 @@ public void shouldReplacePreviousDescription() throws Exception {
@Test
@Verifies(value = "should copy numeric values into numeric concepts", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldCopyNumericValuesIntoNumericConcepts() throws Exception {
- final Double EXPECTED_LOW_ABSOLUTE = 50.0;
- final Double EXPECTED_LOW_CRITICAL = 103.0;
- final Double EXPECTED_LOW_NORMAL = 105.0;
- final Double EXPECTED_HI_NORMAL = 110.0;
- final Double EXPECTED_HI_CRITICAL = 117.0;
- final Double EXPECTED_HI_ABSOLUTE = 150.0;
-
- ConceptService cs = Context.getConceptService();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("namesByLocale[en_GB].name", "WEIGHT (KG)");
- mockRequest.setParameter("conceptId", "5089");
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
- mockRequest.setParameter("lowAbsolute", EXPECTED_LOW_ABSOLUTE.toString());
- mockRequest.setParameter("lowCritical", EXPECTED_LOW_CRITICAL.toString());
- mockRequest.setParameter("lowNormal", EXPECTED_LOW_NORMAL.toString());
- mockRequest.setParameter("hiNormal", EXPECTED_HI_NORMAL.toString());
- mockRequest.setParameter("hiCritical", EXPECTED_HI_CRITICAL.toString());
- mockRequest.setParameter("hiAbsolute", EXPECTED_HI_ABSOLUTE.toString());
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- ConceptNumeric concept = (ConceptNumeric) cs.getConcept(5089);
- Assert.assertEquals(EXPECTED_LOW_NORMAL, concept.getLowNormal());
- Assert.assertEquals(EXPECTED_HI_NORMAL, concept.getHiNormal());
- Assert.assertEquals(EXPECTED_LOW_ABSOLUTE, concept.getLowAbsolute());
- Assert.assertEquals(EXPECTED_HI_ABSOLUTE, concept.getHiAbsolute());
- Assert.assertEquals(EXPECTED_LOW_CRITICAL, concept.getLowCritical());
- Assert.assertEquals(EXPECTED_HI_CRITICAL, concept.getHiCritical());
- }
+ final Double EXPECTED_LOW_ABSOLUTE = 50.0;
+ final Double EXPECTED_LOW_CRITICAL = 103.0;
+ final Double EXPECTED_LOW_NORMAL = 105.0;
+ final Double EXPECTED_HI_NORMAL = 110.0;
+ final Double EXPECTED_HI_CRITICAL = 117.0;
+ final Double EXPECTED_HI_ABSOLUTE = 150.0;
+
+ ConceptService cs = Context.getConceptService();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("namesByLocale[en_GB].name", "WEIGHT (KG)");
+ mockRequest.setParameter("conceptId", "5089");
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+ mockRequest.setParameter("lowAbsolute", EXPECTED_LOW_ABSOLUTE.toString());
+ mockRequest.setParameter("lowCritical", EXPECTED_LOW_CRITICAL.toString());
+ mockRequest.setParameter("lowNormal", EXPECTED_LOW_NORMAL.toString());
+ mockRequest.setParameter("hiNormal", EXPECTED_HI_NORMAL.toString());
+ mockRequest.setParameter("hiCritical", EXPECTED_HI_CRITICAL.toString());
+ mockRequest.setParameter("hiAbsolute", EXPECTED_HI_ABSOLUTE.toString());
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ ConceptNumeric concept = (ConceptNumeric) cs.getConcept(5089);
+ assertEquals(EXPECTED_LOW_NORMAL, concept.getLowNormal());
+ assertEquals(EXPECTED_HI_NORMAL, concept.getHiNormal());
+ assertEquals(EXPECTED_LOW_ABSOLUTE, concept.getLowAbsolute());
+ assertEquals(EXPECTED_HI_ABSOLUTE, concept.getHiAbsolute());
+ assertEquals(EXPECTED_LOW_CRITICAL, concept.getLowCritical());
+ assertEquals(EXPECTED_HI_CRITICAL, concept.getHiCritical());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -667,31 +666,31 @@ public void onSubmit_shouldCopyNumericValuesIntoNumericConcepts() throws Excepti
@Test
@Verifies(value = "should display numeric values from table", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldDisplayNumericValuesFromTable() throws Exception {
- final Double EXPECTED_LOW_ABSOLUTE = 0.0;
- final Double EXPECTED_LOW_CRITICAL = 99.0;
- final Double EXPECTED_LOW_NORMAL = 445.0;
- final Double EXPECTED_HI_NORMAL = 1497.0;
- final Double EXPECTED_HI_CRITICAL = 1800.0;
- final Double EXPECTED_HI_ABSOLUTE = 2500.0;
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("GET");
- mockRequest.setParameter("conceptId", "5497");
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
-
- assertNotNull(mav);
- ConceptFormBackingObject formBackingObject = (ConceptFormBackingObject) mav.getModel().get("command");
-
- Assert.assertEquals(EXPECTED_LOW_NORMAL, formBackingObject.getLowNormal());
- Assert.assertEquals(EXPECTED_HI_NORMAL, formBackingObject.getHiNormal());
- Assert.assertEquals(EXPECTED_LOW_ABSOLUTE, formBackingObject.getLowAbsolute());
- Assert.assertEquals(EXPECTED_HI_ABSOLUTE, formBackingObject.getHiAbsolute());
- Assert.assertEquals(EXPECTED_LOW_CRITICAL, formBackingObject.getLowCritical());
- Assert.assertEquals(EXPECTED_HI_CRITICAL, formBackingObject.getHiCritical());
- }
+ final Double EXPECTED_LOW_ABSOLUTE = 0.0;
+ final Double EXPECTED_LOW_CRITICAL = 99.0;
+ final Double EXPECTED_LOW_NORMAL = 445.0;
+ final Double EXPECTED_HI_NORMAL = 1497.0;
+ final Double EXPECTED_HI_CRITICAL = 1800.0;
+ final Double EXPECTED_HI_ABSOLUTE = 2500.0;
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("GET");
+ mockRequest.setParameter("conceptId", "5497");
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+
+ assertNotNull(mav);
+ ConceptFormBackingObject formBackingObject = (ConceptFormBackingObject) mav.getModel().get("command");
+
+ assertEquals(EXPECTED_LOW_NORMAL, formBackingObject.getLowNormal());
+ assertEquals(EXPECTED_HI_NORMAL, formBackingObject.getHiNormal());
+ assertEquals(EXPECTED_LOW_ABSOLUTE, formBackingObject.getLowAbsolute());
+ assertEquals(EXPECTED_HI_ABSOLUTE, formBackingObject.getHiAbsolute());
+ assertEquals(EXPECTED_LOW_CRITICAL, formBackingObject.getLowCritical());
+ assertEquals(EXPECTED_HI_CRITICAL, formBackingObject.getHiCritical());
+ }
/**
* This tests removing a concept set
@@ -700,27 +699,27 @@ public void onSubmit_shouldDisplayNumericValuesFromTable() throws Exception {
*/
@Test
public void shouldRemoveConceptSet() throws Exception {
- ConceptService cs = Context.getConceptService();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", "23");
- mockRequest.setParameter("namesByLocale[en_GB].name", "FOOD CONSTRUCT");
- mockRequest.setParameter("concept.datatype", "4");
- mockRequest.setParameter("concept.class", "10");
- mockRequest.setParameter("concept.conceptSets", "18 19");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept concept = cs.getConcept(23);
- assertNotNull(concept);
- assertEquals(2, concept.getConceptSets().size());
- }
+ ConceptService cs = Context.getConceptService();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", "23");
+ mockRequest.setParameter("namesByLocale[en_GB].name", "FOOD CONSTRUCT");
+ mockRequest.setParameter("concept.datatype", "4");
+ mockRequest.setParameter("concept.class", "10");
+ mockRequest.setParameter("concept.conceptSets", "18 19");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept concept = cs.getConcept(23);
+ assertNotNull(concept);
+ assertEquals(2, concept.getConceptSets().size());
+ }
/**
* This tests removing an answer
@@ -729,27 +728,27 @@ public void shouldRemoveConceptSet() throws Exception {
*/
@Test
public void shouldRemoveConceptAnswer() throws Exception {
- ConceptService cs = Context.getConceptService();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", "21");
- mockRequest.setParameter("namesByLocale[en_GB].name", "FOOD ASSISTANCE FOR ENTIRE FAMILY");
- mockRequest.setParameter("concept.datatype", "2");
- mockRequest.setParameter("concept.class", "7");
- mockRequest.setParameter("concept.answers", "7 8");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept concept = cs.getConcept(21);
- assertNotNull(concept);
- assertEquals(2, concept.getAnswers(false).size());
- }
+ ConceptService cs = Context.getConceptService();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", "21");
+ mockRequest.setParameter("namesByLocale[en_GB].name", "FOOD ASSISTANCE FOR ENTIRE FAMILY");
+ mockRequest.setParameter("concept.datatype", "2");
+ mockRequest.setParameter("concept.class", "7");
+ mockRequest.setParameter("concept.answers", "7 8");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept concept = cs.getConcept(21);
+ assertNotNull(concept);
+ assertEquals(2, concept.getAnswers(false).size());
+ }
/**
* This test makes sure that all answers are deleted if the user changes this concept's datatype
@@ -759,27 +758,27 @@ public void shouldRemoveConceptAnswer() throws Exception {
*/
@Test
public void shouldRemoveConceptAnswersIfDatatypeChangedFromCoded() throws Exception {
- ConceptService cs = Context.getConceptService();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", "4"); // this must be a concept id that is not used in an observation in order to be changed
- mockRequest.setParameter("namesByLocale[en_GB].name", "CIVIL STATUS");
- mockRequest.setParameter("concept.datatype", "1"); // set it to something other than "Coded"
- mockRequest.setParameter("concept.class", "10");
- mockRequest.setParameter("concept.answers", "5 6");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept concept = cs.getConcept(4);
- assertNotNull(concept);
- assertEquals(0, concept.getAnswers(false).size());
- }
+ ConceptService cs = Context.getConceptService();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", "4"); // this must be a concept id that is not used in an observation in order to be changed
+ mockRequest.setParameter("namesByLocale[en_GB].name", "CIVIL STATUS");
+ mockRequest.setParameter("concept.datatype", "1"); // set it to something other than "Coded"
+ mockRequest.setParameter("concept.class", "10");
+ mockRequest.setParameter("concept.answers", "5 6");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept concept = cs.getConcept(4);
+ assertNotNull(concept);
+ assertEquals(0, concept.getAnswers(false).size());
+ }
/**
* This test makes sure that ConceptComplex objects can be edited
@@ -788,49 +787,47 @@ public void shouldRemoveConceptAnswersIfDatatypeChangedFromCoded() throws Except
*/
@Test
public void shouldEditConceptComplex() throws Exception {
- executeDataSet("org/openmrs/api/include/ObsServiceTest-complex.xml");
-
- ConceptService cs = Context.getConceptService();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", "8473");
- mockRequest.setParameter("namesByLocale[en_GB].name", "A complex concept");
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
- mockRequest.setParameter("concept.datatype", "13");
- mockRequest.setParameter("concept.class", "5");
- mockRequest.setParameter("handlerKey", "TextHandler"); // switching it from an ImageHandler to a TextHandler
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept concept = cs.getConcept(8473);
- assertEquals(ConceptComplex.class, concept.getClass());
- ConceptComplex complex = (ConceptComplex) concept;
- assertEquals("TextHandler", complex.getHandler());
- }
+ executeDataSet("org/openmrs/api/include/ObsServiceTest-complex.xml");
+
+ ConceptService cs = Context.getConceptService();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", "8473");
+ mockRequest.setParameter("namesByLocale[en_GB].name", "A complex concept");
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
+ mockRequest.setParameter("concept.datatype", "13");
+ mockRequest.setParameter("concept.class", "5");
+ mockRequest.setParameter("handlerKey", "TextHandler"); // switching it from an ImageHandler to a TextHandler
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept concept = cs.getConcept(8473);
+ assertEquals(ConceptComplex.class, concept.getClass());
+ ConceptComplex complex = (ConceptComplex) concept;
+ assertEquals("TextHandler", complex.getHandler());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
*/
@Test
- @Verifies(value = "should return a concept with a null id if no match is found", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldReturnAConceptWithANullIdIfNoMatchIsFound() throws Exception {
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- mockRequest.setMethod("GET");
- mockRequest.setParameter("conceptId", "57432223");
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- ConceptFormBackingObject formBackingObject = (ConceptFormBackingObject) mav.getModel().get("command");
- assertNotNull(formBackingObject.getConcept());
- assertNull(formBackingObject.getConcept().getConceptId());
- }
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ mockRequest.setMethod("GET");
+ mockRequest.setParameter("conceptId", "57432223");
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ ConceptFormBackingObject formBackingObject = (ConceptFormBackingObject) mav.getModel().get("command");
+ assertNotNull(formBackingObject.getConcept());
+ assertNull(formBackingObject.getConcept().getConceptId());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -838,26 +835,26 @@ public void onSubmit_shouldReturnAConceptWithANullIdIfNoMatchIsFound() throws Ex
@Test
@Verifies(value = "should set the local preferred name", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldSetTheLocalPreferredName() throws Exception {
- ConceptService cs = Context.getConceptService();
- Concept concept = cs.getConcept(5497);
- //sanity check, the current preferred Name should be different from what will get set in the form
- Assert.assertNotSame("CD3+CD4+ABS CNT", concept.getPreferredName(britishEn).getName());
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", "5497");
- mockRequest.setParameter("preferredNamesByLocale[en_GB]", "CD3+CD4+ABS CNT");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Assert.assertEquals("CD3+CD4+ABS CNT", concept.getPreferredName(britishEn).getName());
- //preferred name should be the new one that has been set from the form
- Assert.assertEquals(true, concept.getPreferredName(britishEn).isLocalePreferred());
- }
+ ConceptService cs = Context.getConceptService();
+ Concept concept = cs.getConcept(5497);
+ //sanity check, the current preferred Name should be different from what will get set in the form
+ Assert.assertNotSame("CD3+CD4+ABS CNT", concept.getPreferredName(britishEn).getName());
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", "5497");
+ mockRequest.setParameter("preferredNamesByLocale[en_GB]", "CD3+CD4+ABS CNT");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ assertEquals("CD3+CD4+ABS CNT", concept.getPreferredName(britishEn).getName());
+ //preferred name should be the new one that has been set from the form
+ assertEquals(true, concept.getPreferredName(britishEn).isLocalePreferred());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -865,28 +862,28 @@ public void onSubmit_shouldSetTheLocalPreferredName() throws Exception {
@Test
@Verifies(value = "should void a synonym marked as preferred when it is removed", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldVoidASynonymMarkedAsPreferredWhenItIsRemoved() throws Exception {
- ConceptService cs = Context.getConceptService();
- Concept concept = cs.getConcept(5497);
- //mark one of the synonyms as preferred
- ConceptName preferredName = new ConceptName("pref name", britishEn);
- preferredName.setLocalePreferred(true);
- concept.addName(preferredName);
- cs.saveConcept(concept);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", "5497");
- //remove the synonym that is marked as preferred
- mockRequest.setParameter("synonymsByLocale[en_GB][0].voided", "true");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Assert.assertEquals(true, preferredName.isVoided());
- }
+ ConceptService cs = Context.getConceptService();
+ Concept concept = cs.getConcept(5497);
+ //mark one of the synonyms as preferred
+ ConceptName preferredName = new ConceptName("pref name", britishEn);
+ preferredName.setLocalePreferred(true);
+ concept.addName(preferredName);
+ cs.saveConcept(concept);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", "5497");
+ //remove the synonym that is marked as preferred
+ mockRequest.setParameter("synonymsByLocale[en_GB][0].voided", "true");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ assertEquals(true, preferredName.isVoided());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -894,30 +891,30 @@ public void onSubmit_shouldVoidASynonymMarkedAsPreferredWhenItIsRemoved() throws
@Test
@Verifies(value = "should add a new Concept map to an existing concept", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldAddANewConceptMapToAnExistingConcept() throws Exception {
- ConceptService cs = Context.getConceptService();
- int conceptId = 3;
-
- // make sure the concept already exists
- Concept concept = cs.getConcept(conceptId);
- assertNotNull(concept);
- int initialConceptMappingCount = concept.getConceptMappings().size();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", concept.getConceptId().toString());
- mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "1");
- mockRequest.setParameter("conceptMappings[0].conceptMapType", "3");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- assertEquals(initialConceptMappingCount + 1, cs.getConcept(conceptId).getConceptMappings().size());
- }
+ ConceptService cs = Context.getConceptService();
+ int conceptId = 3;
+
+ // make sure the concept already exists
+ Concept concept = cs.getConcept(conceptId);
+ assertNotNull(concept);
+ int initialConceptMappingCount = concept.getConceptMappings().size();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", concept.getConceptId().toString());
+ mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "1");
+ mockRequest.setParameter("conceptMappings[0].conceptMapType", "3");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ assertEquals(initialConceptMappingCount + 1, cs.getConcept(conceptId).getConceptMappings().size());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -925,34 +922,34 @@ public void onSubmit_shouldAddANewConceptMapToAnExistingConcept() throws Excepti
@Test
@Verifies(value = "should add a new Concept map when creating a concept", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldAddANewConceptMapWhenCreatingAConcept() throws Exception {
- ConceptService cs = Context.getConceptService();
- final String conceptName = "new concept";
- // make sure the concept doesn't already exist
- Concept newConcept = cs.getConceptByName(conceptName);
- assertNull(newConcept);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("namesByLocale[en_GB].name", conceptName);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("concept.conceptClass", "1");
- mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "1");
- mockRequest.setParameter("conceptMappings[0].conceptMapType", "3");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept createdConcept = cs.getConceptByName(conceptName);
- assertNotNull(createdConcept);
- Assert.assertEquals(1, createdConcept.getConceptMappings().size());
- }
+ ConceptService cs = Context.getConceptService();
+ final String conceptName = "new concept";
+ // make sure the concept doesn't already exist
+ Concept newConcept = cs.getConceptByName(conceptName);
+ assertNull(newConcept);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("namesByLocale[en_GB].name", conceptName);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("concept.conceptClass", "1");
+ mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "1");
+ mockRequest.setParameter("conceptMappings[0].conceptMapType", "3");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept createdConcept = cs.getConceptByName(conceptName);
+ assertNotNull(createdConcept);
+ assertEquals(1, createdConcept.getConceptMappings().size());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -960,30 +957,30 @@ public void onSubmit_shouldAddANewConceptMapWhenCreatingAConcept() throws Except
@Test
@Verifies(value = "should ignore new concept map row if the user did not select a term", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldIgnoreNewConceptMapRowIfTheUserDidNotSelectATerm() throws Exception {
- ConceptService cs = Context.getConceptService();
- int conceptId = 3;
-
- // make sure the concept already exists
- Concept concept = cs.getConcept(conceptId);
- assertNotNull(concept);
- int initialConceptMappingCount = concept.getConceptMappings().size();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", concept.getConceptId().toString());
- mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "");
- mockRequest.setParameter("conceptMappings[0].conceptMapType", "");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- assertEquals(initialConceptMappingCount, cs.getConcept(conceptId).getConceptMappings().size());
- }
+ ConceptService cs = Context.getConceptService();
+ int conceptId = 3;
+
+ // make sure the concept already exists
+ Concept concept = cs.getConcept(conceptId);
+ assertNotNull(concept);
+ int initialConceptMappingCount = concept.getConceptMappings().size();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", concept.getConceptId().toString());
+ mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "");
+ mockRequest.setParameter("conceptMappings[0].conceptMapType", "");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ assertEquals(initialConceptMappingCount, cs.getConcept(conceptId).getConceptMappings().size());
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -991,32 +988,32 @@ public void onSubmit_shouldIgnoreNewConceptMapRowIfTheUserDidNotSelectATerm() th
@Test
@Verifies(value = "should remove a concept map from an existing concept", method = "onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)")
public void onSubmit_shouldRemoveAConceptMapFromAnExistingConcept() throws Exception {
- ConceptService cs = Context.getConceptService();
- int conceptId = 5089;
-
- // make sure the concept already exists and has some concept mappings
- Concept concept = cs.getConcept(conceptId);
- assertNotNull(concept);
- Collection maps = concept.getConceptMappings();
- int initialConceptMappingCount = maps.size();
- assertTrue(initialConceptMappingCount > 0);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", concept.getConceptId().toString());
- //remove the first row
- mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- assertEquals(initialConceptMappingCount - 1, cs.getConcept(conceptId).getConceptMappings().size());
- }
+ ConceptService cs = Context.getConceptService();
+ int conceptId = 5089;
+
+ // make sure the concept already exists and has some concept mappings
+ Concept concept = cs.getConcept(conceptId);
+ assertNotNull(concept);
+ Collection maps = concept.getConceptMappings();
+ int initialConceptMappingCount = maps.size();
+ assertTrue(initialConceptMappingCount > 0);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", concept.getConceptId().toString());
+ //remove the first row
+ mockRequest.setParameter("conceptMappings[0].conceptReferenceTerm", "");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ assertEquals(initialConceptMappingCount - 1, cs.getConcept(conceptId).getConceptMappings().size());
+ }
/**
* @see ConceptFormController#validateConceptUsesPersistedObjects(Concept,BindException)
@@ -1103,39 +1100,39 @@ public void onSubmit_shouldNotSaveChangesIfThereAreValidationErrors() throws Exc
@Test
public void shouldRemoveConceptDescriptionIfRemovedFromUI() throws Exception {
- ConceptService cs = Context.getConceptService();
- final String espaniol = "es";
- AdministrationService as = Context.getAdministrationService();
- GlobalProperty gp = as.getGlobalPropertyObject(OpenmrsConstants.GLOBAL_PROPERTY_LOCALE_ALLOWED_LIST);
- gp.setPropertyValue("en_GB, " + espaniol);
- as.saveGlobalProperty(gp);
- // make sure the concept already exists
- Concept concept = cs.getConcept(3);
- assertNotNull(concept);
- Locale spanish = LocaleUtility.fromSpecification(espaniol);
- assertNotNull(concept.getDescription(britishEn, true));
- assertNull(concept.getDescription(spanish, true));
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- MockHttpServletResponse response = new MockHttpServletResponse();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", concept.getConceptId().toString());
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", "");
- mockRequest.setParameter("descriptionsByLocale[es].description", "new spanish description");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConcept(3);
- assertNotNull(actualConcept);
- assertNull(concept.getDescription(britishEn, true));
- assertNotNull(concept.getDescription(spanish, true));
- }
+ ConceptService cs = Context.getConceptService();
+ final String espaniol = "es";
+ AdministrationService as = Context.getAdministrationService();
+ GlobalProperty gp = as.getGlobalPropertyObject(OpenmrsConstants.GLOBAL_PROPERTY_LOCALE_ALLOWED_LIST);
+ gp.setPropertyValue("en_GB, " + espaniol);
+ as.saveGlobalProperty(gp);
+ // make sure the concept already exists
+ Concept concept = cs.getConcept(3);
+ assertNotNull(concept);
+ Locale spanish = LocaleUtility.fromSpecification(espaniol);
+ assertNotNull(concept.getDescription(britishEn, true));
+ assertNull(concept.getDescription(spanish, true));
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ MockHttpServletResponse response = new MockHttpServletResponse();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", concept.getConceptId().toString());
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", "");
+ mockRequest.setParameter("descriptionsByLocale[es].description", "new spanish description");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, response);
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConcept(3);
+ assertNotNull(actualConcept);
+ assertNull(concept.getDescription(britishEn, true));
+ assertNotNull(concept.getDescription(spanish, true));
+ }
/**
* @see ConceptFormBackingObject#getConceptFromFormData()
@@ -1143,37 +1140,37 @@ public void shouldRemoveConceptDescriptionIfRemovedFromUI() throws Exception {
@Test
@Verifies(value = "should set concept on concept answers", method = "getConceptFromFormData()")
public void getConceptFromFormData_shouldSetConceptOnConceptAnswers() throws Exception {
- int conceptId = 21;
-
- Concept concept = conceptService.getConcept(conceptId);
- assertNotNull(concept);
-
- int initialCount = concept.getAnswers().size();
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "Save Concept");
- mockRequest.setParameter("conceptId", "21");
- mockRequest.setParameter("namesByLocale[en].name", concept.getName().getName());
- mockRequest.setParameter("concept.datatype", "2");
- mockRequest.setParameter("concept.answers", "7 8 22 5089");
-
- ConceptFormBackingObject cb = conceptFormController.formBackingObject(mockRequest);
-
- // Bind the request parameters
- ServletRequestDataBinder srdb = new ServletRequestDataBinder(cb);
- conceptFormController.initBinder(mockRequest, srdb);
- srdb.bind(mockRequest);
-
- Concept parsedConcept = cb.getConceptFromFormData();
-
- assertEquals(initialCount + 1, parsedConcept.getAnswers().size());
- for (ConceptAnswer ca : parsedConcept.getAnswers()) {
- assertNotNull(ca.getConcept());
- }
- }
+ int conceptId = 21;
+
+ Concept concept = conceptService.getConcept(conceptId);
+ assertNotNull(concept);
+
+ int initialCount = concept.getAnswers().size();
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "Save Concept");
+ mockRequest.setParameter("conceptId", "21");
+ mockRequest.setParameter("namesByLocale[en].name", concept.getName().getName());
+ mockRequest.setParameter("concept.datatype", "2");
+ mockRequest.setParameter("concept.answers", "7 8 22 5089");
+
+ ConceptFormBackingObject cb = conceptFormController.formBackingObject(mockRequest);
+
+ // Bind the request parameters
+ ServletRequestDataBinder srdb = new ServletRequestDataBinder(cb);
+ conceptFormController.initBinder(mockRequest, srdb);
+ srdb.bind(mockRequest);
+
+ Concept parsedConcept = cb.getConceptFromFormData();
+
+ assertEquals(initialCount + 1, parsedConcept.getAnswers().size());
+ for (ConceptAnswer ca : parsedConcept.getAnswers()) {
+ assertNotNull(ca.getConcept());
+ }
+ }
/**
* @see ConceptFormController#onSubmit(HttpServletRequest,HttpServletResponse,Object,BindException)
@@ -1213,32 +1210,32 @@ public void onSubmit_shouldEditShortNameWhenThereAreMultipleAllowedLocales() thr
*/
@Test
public void shouldSaveConceptAttribute() throws Exception {
- executeDataSet(CONCEPT_ATTRIBUTES_XML);
- ConceptService cs = Context.getConceptService();
- ConceptAttributeType conceptAttributeType = cs.getConceptAttributeType(1);
-
- final Integer conceptId = 5089;
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
-
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("conceptId", conceptId.toString());
- mockRequest.setParameter("attribute." + conceptAttributeType.getId() + ".new[1]", "2014-03-12");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConcept(conceptId);
- assertNotNull(actualConcept);
- final Collection attributes = actualConcept.getAttributes();
- assertEquals(1, attributes.size());
- final ConceptAttribute conceptAttribute = attributes.iterator().next();
- assertEquals("2014-03-12", conceptAttribute.getValueReference());
- }
+ executeDataSet(CONCEPT_ATTRIBUTES_XML);
+ ConceptService cs = Context.getConceptService();
+ ConceptAttributeType conceptAttributeType = cs.getConceptAttributeType(1);
+
+ final Integer conceptId = 5089;
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("conceptId", conceptId.toString());
+ mockRequest.setParameter("attribute." + conceptAttributeType.getId() + ".new[1]", "2014-03-12");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConcept(conceptId);
+ assertNotNull(actualConcept);
+ final Collection attributes = actualConcept.getAttributes();
+ assertEquals(1, attributes.size());
+ final ConceptAttribute conceptAttribute = attributes.iterator().next();
+ assertEquals("2014-03-12", conceptAttribute.getValueReference());
+ }
/**
* @verifies should add new concept attributes on creating concept
@@ -1246,96 +1243,96 @@ public void shouldSaveConceptAttribute() throws Exception {
*/
@Test
public void shouldSaveConceptAttributeOnCreatingConcept() throws Exception {
- executeDataSet(CONCEPT_ATTRIBUTES_XML);
- final String EXPECTED_PREFERRED_NAME = "concept with attribute";
-
- ConceptService cs = Context.getConceptService();
-
- // make sure the concept doesn't already exist
- Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNull(conceptToAdd);
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
-
- MockHttpServletRequest mockRequest = new MockHttpServletRequest();
- mockRequest.setMethod("POST");
- mockRequest.setParameter("action", "");
- mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
- mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
- mockRequest.setParameter("concept.datatype", "1");
- mockRequest.setParameter("attribute.1.new[0]", "2011-04-25");
- mockRequest.setParameter("concept.conceptClass", "1");
-
- ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
- assertNotNull(mav);
- assertTrue(mav.getModel().isEmpty());
-
- Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
- assertNotNull(actualConcept);
- final Collection attributes = actualConcept.getAttributes();
- assertEquals(1, attributes.size());
- final ConceptAttribute conceptAttribute = attributes.iterator().next();
- assertEquals("2011-04-25", conceptAttribute.getValueReference());
- }
+ executeDataSet(CONCEPT_ATTRIBUTES_XML);
+ final String EXPECTED_PREFERRED_NAME = "concept with attribute";
+
+ ConceptService cs = Context.getConceptService();
+
+ // make sure the concept doesn't already exist
+ Concept conceptToAdd = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNull(conceptToAdd);
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+
+ MockHttpServletRequest mockRequest = new MockHttpServletRequest();
+ mockRequest.setMethod("POST");
+ mockRequest.setParameter("action", "");
+ mockRequest.setParameter("namesByLocale[en_GB].name", EXPECTED_PREFERRED_NAME);
+ mockRequest.setParameter("descriptionsByLocale[en_GB].description", "some description");
+ mockRequest.setParameter("concept.datatype", "1");
+ mockRequest.setParameter("attribute.1.new[0]", "2011-04-25");
+ mockRequest.setParameter("concept.conceptClass", "1");
+
+ ModelAndView mav = conceptFormController.handleRequest(mockRequest, new MockHttpServletResponse());
+ assertNotNull(mav);
+ assertTrue(mav.getModel().isEmpty());
+
+ Concept actualConcept = cs.getConceptByName(EXPECTED_PREFERRED_NAME);
+ assertNotNull(actualConcept);
+ final Collection attributes = actualConcept.getAttributes();
+ assertEquals(1, attributes.size());
+ final ConceptAttribute conceptAttribute = attributes.iterator().next();
+ assertEquals("2011-04-25", conceptAttribute.getValueReference());
+ }
/**
* @verifies not void or change attributeList if the attribute values are same
*/
@Test
public void shouldNotVoidOrChangeAttributeListIfTheAttributeValuesAreSame() throws Exception {
- executeDataSet(CONCEPT_ATTRIBUTES_XML);
- Concept concept = Context.getConceptService().getConcept(3);
- final int existingConceptAttributeId = 1;
- ConceptAttributeType conceptAttributeType = Context.getConceptService().getConceptAttributeType(
- existingConceptAttributeId);
- conceptAttributeType.setName("concept joined date");
-
- //assert there is one concept attribute
- assertEquals(1, concept.getAttributes().size());
- assertEquals("2011-04-25", concept.getAttributes().iterator().next().getValueReference());
-
- MockHttpServletRequest mockHttpServletRequest = new MockHttpServletRequest();
- mockHttpServletRequest.setMethod("POST");
- mockHttpServletRequest.setParameter("action", "");
- mockHttpServletRequest.setParameter("conceptId", "3");
- mockHttpServletRequest.setParameter("attribute." + conceptAttributeType.getId() + ".existing["
- + existingConceptAttributeId + "]", "2011-04-25");
- BindException errors = new BindException(concept, "concept");
-
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- conceptFormController.handleRequest(mockHttpServletRequest, new MockHttpServletResponse());
-
- Assert.assertEquals(1, concept.getAttributes().size());
- Assert.assertFalse(((ConceptAttribute) (concept.getAttributes().toArray()[0])).getVoided());
- Assert.assertFalse(errors.hasErrors());
- }
+ executeDataSet(CONCEPT_ATTRIBUTES_XML);
+ Concept concept = Context.getConceptService().getConcept(3);
+ final int existingConceptAttributeId = 1;
+ ConceptAttributeType conceptAttributeType = Context.getConceptService().getConceptAttributeType(
+ existingConceptAttributeId);
+ conceptAttributeType.setName("concept joined date");
+
+ //assert there is one concept attribute
+ assertEquals(1, concept.getAttributes().size());
+ assertEquals("2011-04-25", concept.getAttributes().iterator().next().getValueReference());
+
+ MockHttpServletRequest mockHttpServletRequest = new MockHttpServletRequest();
+ mockHttpServletRequest.setMethod("POST");
+ mockHttpServletRequest.setParameter("action", "");
+ mockHttpServletRequest.setParameter("conceptId", "3");
+ mockHttpServletRequest.setParameter("attribute." + conceptAttributeType.getId() + ".existing["
+ + existingConceptAttributeId + "]", "2011-04-25");
+ BindException errors = new BindException(concept, "concept");
+
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ conceptFormController.handleRequest(mockHttpServletRequest, new MockHttpServletResponse());
+
+ assertEquals(1, concept.getAttributes().size());
+ Assert.assertFalse(((ConceptAttribute) (concept.getAttributes().toArray()[0])).getVoided());
+ Assert.assertFalse(errors.hasErrors());
+ }
/**
* @verifies set attributes to void if the values is not set
*/
@Test
public void shouldSetAttributesToVoidIfTheValueIsNotSet() throws Exception {
- executeDataSet(CONCEPT_ATTRIBUTES_XML);
- Concept concept = Context.getConceptService().getConcept(3);
- final int existingConceptAttributeId = 1;
- ConceptAttributeType conceptAttributeType = Context.getConceptService().getConceptAttributeType(
- existingConceptAttributeId);
- conceptAttributeType.setName("concept type");
- MockHttpServletRequest mockHttpServletRequest = new MockHttpServletRequest();
- //If value is not set then void all the attributes.
- mockHttpServletRequest.setMethod("POST");
- mockHttpServletRequest.setParameter("action", "");
- mockHttpServletRequest.setParameter("conceptId", "3");
- mockHttpServletRequest.setParameter("attribute." + conceptAttributeType.getId() + ".existing["
- + existingConceptAttributeId + "]", "");
- BindException errors = new BindException(concept, "concept");
- ConceptFormController conceptFormController = (ConceptFormController) applicationContext.getBean("conceptForm");
- conceptFormController.handleRequest(mockHttpServletRequest, new MockHttpServletResponse());
-
- Assert.assertEquals(1, concept.getAttributes().size());
- Assert.assertTrue(((ConceptAttribute) (concept.getAttributes().toArray()[0])).getVoided());
- Assert.assertFalse(errors.hasErrors());
- }
+ executeDataSet(CONCEPT_ATTRIBUTES_XML);
+ Concept concept = Context.getConceptService().getConcept(3);
+ final int existingConceptAttributeId = 1;
+ ConceptAttributeType conceptAttributeType = Context.getConceptService().getConceptAttributeType(
+ existingConceptAttributeId);
+ conceptAttributeType.setName("concept type");
+ MockHttpServletRequest mockHttpServletRequest = new MockHttpServletRequest();
+ //If value is not set then void all the attributes.
+ mockHttpServletRequest.setMethod("POST");
+ mockHttpServletRequest.setParameter("action", "");
+ mockHttpServletRequest.setParameter("conceptId", "3");
+ mockHttpServletRequest.setParameter("attribute." + conceptAttributeType.getId() + ".existing["
+ + existingConceptAttributeId + "]", "");
+ BindException errors = new BindException(concept, "concept");
+ ConceptFormController conceptFormController = conceptFormProvider.getObject();
+ conceptFormController.handleRequest(mockHttpServletRequest, new MockHttpServletResponse());
+
+ assertEquals(1, concept.getAttributes().size());
+ assertTrue(((ConceptAttribute) (concept.getAttributes().toArray()[0])).getVoided());
+ Assert.assertFalse(errors.hasErrors());
+ }
/**
* To be uncommented when the openmrs-core version in this module is ultimately changed to 2.7.0
diff --git a/omod/src/test/java/org/openmrs/web/controller/ForgotPasswordFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/ForgotPasswordFormControllerTest.java
index c81ee123..e5021dd5 100644
--- a/omod/src/test/java/org/openmrs/web/controller/ForgotPasswordFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/ForgotPasswordFormControllerTest.java
@@ -12,7 +12,7 @@
import java.util.ArrayList;
import java.util.List;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
diff --git a/omod/src/test/java/org/openmrs/web/controller/GlobalPropertyPortletControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/GlobalPropertyPortletControllerTest.java
index 80d2832f..cc6569a5 100644
--- a/omod/src/test/java/org/openmrs/web/controller/GlobalPropertyPortletControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/GlobalPropertyPortletControllerTest.java
@@ -14,7 +14,7 @@
import java.util.List;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import junit.framework.Assert;
diff --git a/omod/src/test/java/org/openmrs/web/controller/OptionsFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/OptionsFormControllerTest.java
index 66d14a9f..04949690 100644
--- a/omod/src/test/java/org/openmrs/web/controller/OptionsFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/OptionsFormControllerTest.java
@@ -16,12 +16,12 @@
import java.net.BindException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
import org.openmrs.GlobalProperty;
import org.openmrs.User;
import org.openmrs.api.context.Context;
@@ -30,8 +30,8 @@
import org.openmrs.util.OpenmrsConstants;
import org.openmrs.util.Security;
import org.openmrs.web.OptionsForm;
-import org.openmrs.web.test.BaseModuleWebContextSensitiveTest;
import org.openmrs.web.test.WebTestHelper;
+import org.openmrs.web.test.jupiter.BaseModuleWebContextSensitiveTest;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
@@ -49,7 +49,7 @@ public class OptionsFormControllerTest extends BaseModuleWebContextSensitiveTest
@Autowired
private WebTestHelper testHelper;
- @Before
+ @BeforeEach
public void setUp() {
Context.authenticate("admin", "test");
user = Context.getAuthenticatedUser();
diff --git a/omod/src/test/java/org/openmrs/web/controller/PortletControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/PortletControllerTest.java
index 57fa86dd..6d1178c0 100644
--- a/omod/src/test/java/org/openmrs/web/controller/PortletControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/PortletControllerTest.java
@@ -12,8 +12,8 @@
import java.util.HashMap;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
@@ -42,7 +42,7 @@ private Map getModelFromController(Integer patientId) throws Exc
request.setAttribute(WebConstants.INIT_REQ_UNIQUE_ID, "1");
request.getSession().setAttribute(WebConstants.OPENMRS_PORTLET_LAST_REQ_ID, "0");
- request.setAttribute("javax.servlet.include.servlet_path", "testPortlet");
+ request.setAttribute("jakarta.servlet.include.servlet_path", "testPortlet");
request.setAttribute("org.openmrs.portlet.parameters", new HashMap());
request.setAttribute("org.openmrs.portlet.patientId", patientId);
diff --git a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptProposalFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptProposalFormControllerTest.java
index 50ddbcdc..28a75f87 100644
--- a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptProposalFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptProposalFormControllerTest.java
@@ -15,8 +15,8 @@
import java.util.List;
import java.util.Locale;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import junit.framework.Assert;
diff --git a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptSourceFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptSourceFormControllerTest.java
index 3e118f1b..c7bb7d23 100644
--- a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptSourceFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptSourceFormControllerTest.java
@@ -11,8 +11,8 @@
import java.net.BindException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordFormControllerTest.java
index fae5cc7d..e6e852fc 100644
--- a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordFormControllerTest.java
@@ -11,7 +11,7 @@
import java.util.Locale;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordListControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordListControllerTest.java
index 140fe055..9b7e8e3e 100644
--- a/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordListControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/concept/ConceptStopWordListControllerTest.java
@@ -11,7 +11,7 @@
import java.util.List;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterFormControllerTest.java
index 1616b6e0..c5d0b645 100644
--- a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterFormControllerTest.java
@@ -9,7 +9,6 @@
*/
package org.openmrs.web.controller.encounter;
-import org.apache.struts.mock.MockHttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
import org.openmrs.Encounter;
@@ -17,8 +16,8 @@
import org.openmrs.api.context.Context;
import org.openmrs.test.Verifies;
import org.openmrs.web.test.BaseModuleWebContextSensitiveTest;
-import org.openmrs.web.test.BaseWebContextSensitiveTest;
import org.springframework.mock.web.MockHttpServletRequest;
+import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.validation.BindException;
import java.util.List;
diff --git a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterRoleFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterRoleFormControllerTest.java
index d8281b54..4d4471af 100644
--- a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterRoleFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterRoleFormControllerTest.java
@@ -11,7 +11,7 @@
import java.util.List;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeFormControllerTest.java
index a1156794..a190473c 100644
--- a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeFormControllerTest.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.controller.encounter;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeListControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeListControllerTest.java
index 1a7a2474..bc7962b4 100644
--- a/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeListControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/encounter/EncounterTypeListControllerTest.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.encounter;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Test;
import org.openmrs.test.Verifies;
diff --git a/omod/src/test/java/org/openmrs/web/controller/encounter/LocationFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/encounter/LocationFormControllerTest.java
index b9875236..68620bc3 100644
--- a/omod/src/test/java/org/openmrs/web/controller/encounter/LocationFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/encounter/LocationFormControllerTest.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.encounter;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/form/FieldFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/form/FieldFormControllerTest.java
index aed57e5a..bf968ece 100644
--- a/omod/src/test/java/org/openmrs/web/controller/form/FieldFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/form/FieldFormControllerTest.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/form/FieldTypeListControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/form/FieldTypeListControllerTest.java
index ee52c62a..7e6f2f53 100644
--- a/omod/src/test/java/org/openmrs/web/controller/form/FieldTypeListControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/form/FieldTypeListControllerTest.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/form/FormFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/form/FormFormControllerTest.java
index a08ffc6b..d619fd5e 100644
--- a/omod/src/test/java/org/openmrs/web/controller/form/FormFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/form/FormFormControllerTest.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.controller.form;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
diff --git a/omod/src/test/java/org/openmrs/web/controller/maintenance/GlobalPropertyControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/maintenance/GlobalPropertyControllerTest.java
index 23a6585f..76e0c7fd 100644
--- a/omod/src/test/java/org/openmrs/web/controller/maintenance/GlobalPropertyControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/maintenance/GlobalPropertyControllerTest.java
@@ -11,8 +11,8 @@
import java.util.Locale;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
@@ -22,6 +22,7 @@
import org.openmrs.api.context.Context;
import org.openmrs.web.test.BaseModuleWebContextSensitiveTest;
import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.context.MessageSource;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
@@ -29,7 +30,6 @@
public class GlobalPropertyControllerTest extends BaseModuleWebContextSensitiveTest {
- @Autowired
private MessageSource messageSource;
@Autowired
@@ -39,6 +39,7 @@ public class GlobalPropertyControllerTest extends BaseModuleWebContextSensitiveT
@Before
public void before() {
+ messageSource = Context.getMessageSourceService();
administrationService = Context.getAdministrationService();
}
diff --git a/omod/src/test/java/org/openmrs/web/controller/observation/ObsFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/observation/ObsFormControllerTest.java
index 68c215b6..ae375f19 100644
--- a/omod/src/test/java/org/openmrs/web/controller/observation/ObsFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/observation/ObsFormControllerTest.java
@@ -13,7 +13,7 @@
import java.util.List;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/patient/PatientDashboardControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/patient/PatientDashboardControllerTest.java
index 1bc1bf1a..dfcaa92c 100644
--- a/omod/src/test/java/org/openmrs/web/controller/patient/PatientDashboardControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/patient/PatientDashboardControllerTest.java
@@ -16,7 +16,7 @@
import java.lang.reflect.Method;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.junit.Before;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/patient/PatientFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/patient/PatientFormControllerTest.java
index 0b683336..07a94b35 100644
--- a/omod/src/test/java/org/openmrs/web/controller/patient/PatientFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/patient/PatientFormControllerTest.java
@@ -23,7 +23,7 @@
import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
/**
* Consists of unit tests for the PatientFormController
diff --git a/omod/src/test/java/org/openmrs/web/controller/patient/PatientIdentifierTypeFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/patient/PatientIdentifierTypeFormControllerTest.java
index 7f5d47af..82ac5831 100644
--- a/omod/src/test/java/org/openmrs/web/controller/patient/PatientIdentifierTypeFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/patient/PatientIdentifierTypeFormControllerTest.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.controller.patient;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
diff --git a/omod/src/test/java/org/openmrs/web/controller/person/AddPersonControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/person/AddPersonControllerTest.java
index 2a7c2f7b..42641af3 100644
--- a/omod/src/test/java/org/openmrs/web/controller/person/AddPersonControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/person/AddPersonControllerTest.java
@@ -13,8 +13,8 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Test;
import org.openmrs.web.test.BaseModuleWebContextSensitiveTest;
diff --git a/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeFormControllerTest.java
index 6e4738e9..64bdbb87 100644
--- a/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeFormControllerTest.java
@@ -9,7 +9,7 @@
*/
package org.openmrs.web.controller.person;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Before;
diff --git a/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeListControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeListControllerTest.java
index cb5753c0..b589f4ca 100644
--- a/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeListControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/person/PersonAttributeTypeListControllerTest.java
@@ -11,7 +11,7 @@
import java.util.List;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/controller/program/ProgramFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/program/ProgramFormControllerTest.java
index c114d72a..71eaec5c 100644
--- a/omod/src/test/java/org/openmrs/web/controller/program/ProgramFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/program/ProgramFormControllerTest.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.controller.program;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.junit.Assert;
import org.junit.Test;
@@ -62,6 +62,8 @@ public void onSubmit_shouldEditExistingWorkflowsWithinPrograms() throws Exceptio
ProgramFormController controller = (ProgramFormController) applicationContext.getBean("programForm");
controller.handleRequest(request, new MockHttpServletResponse());
+
+ Context.clearSession();
Assert.assertEquals(2, Context.getProgramWorkflowService().getProgram(3).getWorkflows().size());
diff --git a/omod/src/test/java/org/openmrs/web/controller/program/WorkflowFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/program/WorkflowFormControllerTest.java
index d6d66eca..8b0d7784 100644
--- a/omod/src/test/java/org/openmrs/web/controller/program/WorkflowFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/program/WorkflowFormControllerTest.java
@@ -18,8 +18,8 @@
import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.web.servlet.ModelAndView;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
/**
* Tests the {@link WorkflowFormController} class.
diff --git a/omod/src/test/java/org/openmrs/web/controller/user/ChangePasswordFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/user/ChangePasswordFormControllerTest.java
index 88935aa1..0496658b 100644
--- a/omod/src/test/java/org/openmrs/web/controller/user/ChangePasswordFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/user/ChangePasswordFormControllerTest.java
@@ -13,7 +13,7 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
-import javax.servlet.http.HttpSession;
+import jakarta.servlet.http.HttpSession;
import org.junit.Test;
import org.openmrs.User;
diff --git a/omod/src/test/java/org/openmrs/web/controller/user/UserFormControllerTest.java b/omod/src/test/java/org/openmrs/web/controller/user/UserFormControllerTest.java
index 8f79e6d1..e10a9e81 100644
--- a/omod/src/test/java/org/openmrs/web/controller/user/UserFormControllerTest.java
+++ b/omod/src/test/java/org/openmrs/web/controller/user/UserFormControllerTest.java
@@ -25,7 +25,7 @@
import org.springframework.validation.BindException;
import org.springframework.web.context.request.ServletWebRequest;
import org.springframework.web.context.request.WebRequest;
-import javax.servlet.http.HttpServletResponse;
+import jakarta.servlet.http.HttpServletResponse;
/**
* Tests the {@link oldUserFormController} class.
diff --git a/omod/src/test/java/org/openmrs/web/dwr/DWRConceptServiceTest.java b/omod/src/test/java/org/openmrs/web/dwr/DWRConceptServiceTest.java
index 0d96097e..836286bf 100644
--- a/omod/src/test/java/org/openmrs/web/dwr/DWRConceptServiceTest.java
+++ b/omod/src/test/java/org/openmrs/web/dwr/DWRConceptServiceTest.java
@@ -14,6 +14,7 @@
import java.util.List;
import java.util.Locale;
+import org.hibernate.Hibernate;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
@@ -209,7 +210,8 @@ public void findConceptAnswers_shouldSearchForConceptAnswersInAllSearchLocales()
User user = Context.getAuthenticatedUser();
user.setUserProperty(OpenmrsConstants.USER_PROPERTY_PROFICIENT_LOCALES, "en_GB, en_US, pl");
Context.getUserService().saveUser(user);
-
+ Context.clearSession();
+
Concept answer1 = Context.getConceptService().getConcept(7);
answer1.addName(new ConceptName("TAK", new Locale("pl")));
Context.getConceptService().saveConcept(answer1);
@@ -250,6 +252,7 @@ public void findConceptAnswers_shouldNotReturnDuplicates() throws Exception {
User user = Context.getAuthenticatedUser();
user.setUserProperty(OpenmrsConstants.USER_PROPERTY_PROFICIENT_LOCALES, "en_GB, en_US, pl");
Context.getUserService().saveUser(user);
+ Context.clearSession();
Concept answer1 = Context.getConceptService().getConcept(7);
answer1.addName(new ConceptName("TAK", new Locale("pl")));
diff --git a/omod/src/test/java/org/openmrs/web/servlet/DownloadDictionaryServletTest.java b/omod/src/test/java/org/openmrs/web/servlet/DownloadDictionaryServletTest.java
index e29b030a..cd6ffc4e 100644
--- a/omod/src/test/java/org/openmrs/web/servlet/DownloadDictionaryServletTest.java
+++ b/omod/src/test/java/org/openmrs/web/servlet/DownloadDictionaryServletTest.java
@@ -12,7 +12,7 @@
import java.util.Arrays;
import java.util.List;
-import javax.annotation.Resource;
+import jakarta.annotation.Resource;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/servlet/ShowGraphServletTest.java b/omod/src/test/java/org/openmrs/web/servlet/ShowGraphServletTest.java
index 809ffe91..e7010bc5 100644
--- a/omod/src/test/java/org/openmrs/web/servlet/ShowGraphServletTest.java
+++ b/omod/src/test/java/org/openmrs/web/servlet/ShowGraphServletTest.java
@@ -12,7 +12,7 @@
import java.util.Calendar;
import java.util.Date;
-import javax.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletRequest;
import org.jfree.chart.JFreeChart;
import org.junit.Assert;
diff --git a/omod/src/test/java/org/openmrs/web/taglib/ForEachEncounterTagTest.java b/omod/src/test/java/org/openmrs/web/taglib/ForEachEncounterTagTest.java
index 881d0580..0e88e3c3 100644
--- a/omod/src/test/java/org/openmrs/web/taglib/ForEachEncounterTagTest.java
+++ b/omod/src/test/java/org/openmrs/web/taglib/ForEachEncounterTagTest.java
@@ -12,8 +12,8 @@
import java.util.ArrayList;
import java.util.List;
-import javax.servlet.jsp.tagext.BodyTag;
-import javax.servlet.jsp.tagext.Tag;
+import jakarta.servlet.jsp.tagext.BodyTag;
+import jakarta.servlet.jsp.tagext.Tag;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/java/org/openmrs/web/taglib/FormatTagTest.java b/omod/src/test/java/org/openmrs/web/taglib/FormatTagTest.java
index a05e6581..bd1dc889 100644
--- a/omod/src/test/java/org/openmrs/web/taglib/FormatTagTest.java
+++ b/omod/src/test/java/org/openmrs/web/taglib/FormatTagTest.java
@@ -11,8 +11,8 @@
import java.util.Locale;
-import javax.servlet.jsp.PageContext;
-import javax.servlet.jsp.tagext.Tag;
+import jakarta.servlet.jsp.PageContext;
+import jakarta.servlet.jsp.tagext.Tag;
import org.hamcrest.Matchers;
import org.junit.Assert;
diff --git a/omod/src/test/java/org/openmrs/web/taglib/OpenmrsMessageTagTest.java b/omod/src/test/java/org/openmrs/web/taglib/OpenmrsMessageTagTest.java
index 3598bc9a..c7d65f6b 100644
--- a/omod/src/test/java/org/openmrs/web/taglib/OpenmrsMessageTagTest.java
+++ b/omod/src/test/java/org/openmrs/web/taglib/OpenmrsMessageTagTest.java
@@ -11,8 +11,8 @@
import java.util.Locale;
-import javax.servlet.jsp.PageContext;
-import javax.servlet.jsp.tagext.TagSupport;
+import jakarta.servlet.jsp.PageContext;
+import jakarta.servlet.jsp.tagext.TagSupport;
import org.junit.Assert;
import org.junit.Before;
diff --git a/omod/src/test/java/org/openmrs/web/taglib/PrivilegeTagTest.java b/omod/src/test/java/org/openmrs/web/taglib/PrivilegeTagTest.java
index 40a2b717..3800d0a1 100644
--- a/omod/src/test/java/org/openmrs/web/taglib/PrivilegeTagTest.java
+++ b/omod/src/test/java/org/openmrs/web/taglib/PrivilegeTagTest.java
@@ -19,7 +19,7 @@
import static org.hamcrest.core.Is.is;
-import javax.servlet.jsp.tagext.Tag;
+import jakarta.servlet.jsp.tagext.Tag;
/**
* Tests for the {@link PrivilegeTag} taglib controller.
diff --git a/omod/src/test/java/org/openmrs/web/taglib/RequireTagTest.java b/omod/src/test/java/org/openmrs/web/taglib/RequireTagTest.java
index e54485e6..b8996197 100644
--- a/omod/src/test/java/org/openmrs/web/taglib/RequireTagTest.java
+++ b/omod/src/test/java/org/openmrs/web/taglib/RequireTagTest.java
@@ -9,8 +9,8 @@
*/
package org.openmrs.web.taglib;
-import javax.servlet.jsp.PageContext;
-import javax.servlet.jsp.tagext.Tag;
+import jakarta.servlet.jsp.PageContext;
+import jakarta.servlet.jsp.tagext.Tag;
import org.junit.Assert;
import org.junit.Test;
diff --git a/omod/src/test/resources/org/openmrs/web/include/SchedulerFormControllerTest.xml b/omod/src/test/resources/org/openmrs/web/include/SchedulerFormControllerTest.xml
index ef71acac..f5a14e51 100644
--- a/omod/src/test/resources/org/openmrs/web/include/SchedulerFormControllerTest.xml
+++ b/omod/src/test/resources/org/openmrs/web/include/SchedulerFormControllerTest.xml
@@ -11,5 +11,5 @@
-->
-
+
diff --git a/omod/src/test/resources/org/openmrs/web/include/TaskHelperTest.xml b/omod/src/test/resources/org/openmrs/web/include/TaskHelperTest.xml
index 3043801c..1e0b5e7a 100644
--- a/omod/src/test/resources/org/openmrs/web/include/TaskHelperTest.xml
+++ b/omod/src/test/resources/org/openmrs/web/include/TaskHelperTest.xml
@@ -11,5 +11,5 @@
-->
-
+
diff --git a/omod/src/test/resources/org/openmrs/web/taglib/include/PrivilegeTagTest.xml b/omod/src/test/resources/org/openmrs/web/taglib/include/PrivilegeTagTest.xml
index 959f1795..4bbf2b44 100644
--- a/omod/src/test/resources/org/openmrs/web/taglib/include/PrivilegeTagTest.xml
+++ b/omod/src/test/resources/org/openmrs/web/taglib/include/PrivilegeTagTest.xml
@@ -11,9 +11,9 @@
-->
-
-
-
+
+
+
diff --git a/omod/src/test/resources/org/openmrs/web/taglib/include/RequireTagTest.xml b/omod/src/test/resources/org/openmrs/web/taglib/include/RequireTagTest.xml
index c227b66b..2c9430d6 100644
--- a/omod/src/test/resources/org/openmrs/web/taglib/include/RequireTagTest.xml
+++ b/omod/src/test/resources/org/openmrs/web/taglib/include/RequireTagTest.xml
@@ -14,9 +14,9 @@
-
-
-
+
+
+
diff --git a/pom.xml b/pom.xml
index 3ba4e895..9567575b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -45,9 +45,9 @@
- 2.7.3
+ 3.0.0-SNAPSHOT
UTF-8
- 8
+ 21
@@ -69,6 +69,28 @@
${openmrsPlatformVersion}
jar
provided
+
+
+ commons-fileupload
+ commons-fileupload
+
+
+ taglibs
+ response
+
+
+ taglibs
+ request
+
+
+ taglibs
+ standard
+
+
+ taglibs
+ page
+
+
@@ -101,13 +123,7 @@
1.0.12
-
- javax.servlet
- jsp-api
- 2.0
- provided
-
-
+
@@ -173,43 +189,6 @@
@{project.version}
-
- com.mycila
- license-maven-plugin
- 3.0
-
-
-
- **/*.java
- **/*.txt
- **/*.xml
-
-
- license-header.txt
- .git/**
- tools/formatter/**
-
- .idea/**
- target/**
- bin/**
- tmp/**
- .settings/**
- .externalToolBuilders/
- build/
- bin/
- dist/
-
-
-
-
- format-license-header
- process-sources
-
- format
-
-
-
-
net.revelc.code.formatter
formatter-maven-plugin