Yep, the strings would be coming from your own code rather than living inside this library. Right now the ShopifyOrderFilter looks something like this:

public class ShopifyOrderFilter : BaseFilter
{
  ...
  public ShopifyFulfillmentStatus FulfillmentStatus { get; set; }
  ...
}

And it gets used like this:

var filter = new ShopifyOrderFilter()
{
  FulfillmentStatus = ShopifyFulfillmentStatus.Fulfilled
}

As it is right now, you don't have any way to fix that FulfillmentStatus when the expected values are changed (unless you're using the source code), because they're hardcoded in the lib. It wants that enum rather than the raw string that gets sent to the Shopify API behind the scenes.

If I switched it to strings, the class would look like this instead:

public class ShopifyOrderFilter : BaseFilter
{
  ...
  public string FulfillmentStatus { get; set; }
  ...
}

And it would be used like this in your app:

...

var filter = new ShopifyOrderFilter()
{
  FulfillmentStatus = "Whatever string you want"
}

Since that string is coming from your own app, you'd be able to quickly update it and change the string rather than wait for a new ShopifySharp release.

Uh oh!

ShopifyOrderStatus Enums need updating #64

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions