-
-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
Milestone
Description
The list/count filter classes have a bunch of duplication going on. List filter classes should instead be replaced by a generic ShopifyListFilter class that contains the following props:
public long SinceId
public int Page
public string FieldsIt will inherit from a ShopifyCountFilter class, which contains the following props:
public DateTime CreatedAtMin
public DateTime CreatedAtMax
public DateTime UpdatedAtMin
public DateTime UpdatedAtMaxAlmost every count and list command uses the properties in these two classes. The exceptions are those that either can't be filtered, or those that use all of these properties plus a couple of custom properties that are specific to their objects. Instead of doing something sensible, we've somehow (entirely my fault!) ended up with a bunch of different classes that repeat these common properties.
This would be a breaking change, though, so I'm marking it for Version 2.