这是indexloc提供的服务,不要输入任何密码
Skip to content

Clean up the filter classes for .Count and .List commands. #21

@nozzlegear

Description

@nozzlegear

The list/count filter classes have a bunch of duplication going on. List filter classes should instead be replaced by a generic ShopifyListFilter class that contains the following props:

public long SinceId

public int Page

public string Fields

It will inherit from a ShopifyCountFilter class, which contains the following props:

public DateTime CreatedAtMin

public DateTime CreatedAtMax

public DateTime UpdatedAtMin

public DateTime UpdatedAtMax

Almost every count and list command uses the properties in these two classes. The exceptions are those that either can't be filtered, or those that use all of these properties plus a couple of custom properties that are specific to their objects. Instead of doing something sensible, we've somehow (entirely my fault!) ended up with a bunch of different classes that repeat these common properties.

This would be a breaking change, though, so I'm marking it for Version 2.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions