Make DynamoDB table creation optional, add permission for S3 locking #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello @nozaq, thank you for the excellent module. I would very much appreciate it, if you could take a look at this PR, it adds a couple of features necessary for Terraform 1.11+ 🙌 |
Author
|
Hi @nozaq, any chance of a review? I'd hate to have to use a forked version of the repo. |
f95fd9a to
f52b1df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of Terraform 1.11, DynamoDB table locking has been deprecated, and native S3 locking via the
use_lockfileargument has become the recommended locking option.https://github.com/hashicorp/terraform/blob/v1.11/CHANGELOG.md#1110-february-27-2025
https://developer.hashicorp.com/terraform/language/backend/s3
The PR adds a self-explanatory
create_dynamodb_tablevariable (set tofalseby default, to maintain backward compatibility) along with aterraform_iam_policy_add_lockfile_permissionsvariable that controls whether the extra S3 permission required for S3 state locking is added to the Terraform policy. It also includes a policy refactor and tflint configuration refresh.The PR fixes the following issue:
#128