这是indexloc提供的服务,不要输入任何密码
Skip to content

DynamoDB reader is using dynamoDbParams against documentClient #147

@ceilfors

Description

@ceilfors

Describe the bug
DynamoDB reader for laconia batch is using documentClient, but the params is passed is as dynamoDbParams.

To Reproduce
Create a reader with dynamoDb params ExpressionAttributeValues format:

dynamoDb({
  operation: "QUERY",
  dynamoDbParams: {
    TableName: "Music",
    Limit: 1,
    ExpressionAttributeValues: {
      ":a": { "S": "Bar" }
    },
  }
});

Expected behavior
dynamoDbParams must be renamed to documentClientParams

    ExpressionAttributeValues: {
      ":a": "Bar" 
    },

Actual behavior
The reader would break because of the following code:

    ExpressionAttributeValues: {
      ":a": { "S": "Bar" }
    },

Additional context

This is a breaking change. Deprecate dynamoDbParams instead or removing them.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions