feature(f.promisify): Add F.Promisify type #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millsp
requested changes
Nov 18, 2019
|
Cool, I'll add tests - might take me a few days as I'm pretty busy at the moment, gonna ping you when I'm done. Cheers! |
|
@pirix-gh I've added test + changed the implementation to handle promise flattening, which kinda should be handled by TS on its own, but unfortunately it is not and the issue about it is in their tracker |
millsp
reviewed
Nov 21, 2019
| @@ -12,4 +12,6 @@ import {Return} from './Return' | |||
| * type test0 = F.Promisify<(a: number) => number> // (a: number) => Promise<number> | |||
| * ``` | |||
| */ | |||
| export type Promisify<F extends Function> = (...args: Parameters<F>) => Promise<Return<F>> | |||
| export type Promisify<F extends Function> = Return<F> extends Promise<any> | |||
millsp
approved these changes
Nov 21, 2019
|
🎉 Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Pull Request
tstfolder)npm testGonna add tests once you give me a green light on this one - I've created this PR rather quickly, but looks that understanding how tests are actually written might take a little bit more time, so I've postponed it for now.
Why have you made changes?
It was a useful type that I have used in my project and thought it might find its home here as well.
Is there any breaking changes?